[YANGTOOLS-504] Need to bump iana-afi-safi module version to be greater than 2014.0.0 Created: 15/Sep/15  Updated: 10/Apr/22  Resolved: 22/Sep/15

Status: Resolved
Project: yangtools
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Jeff Liu Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 4309

 Description   

org.opendaylight.odlparent.featuretest.SingleFeatureTest checks for module version and requires all module versions to be greater than 2014.0.0. However iana-afi-safi is currently versioned as 130704, therefore it failed the SingleFeatureTest if any module is trying to use it.

Error message is below. We need to bump up the iana-afi-safi module version to be greater than 140000.

<error message="Unresolved constraint in bundle org.opendaylight.bgpcep.util [111]: Unable to resolve 111.0: missing requirement [111.0] osgi.wiring.package; (&(osgi.wiring.package=org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.iana.afn.safi.rev130704)(version>=2013.7.0)(!(version>=2014.0.0)))" type="org.osgi.framework.BundleException"><![CDATA[org.osgi.framework.BundleException: Unresolved constraint in bundle org.opendaylight.bgpcep.util [111]: Unable to resolve 111.0: missing requirement [111.0] osgi.wiring.package; (&(osgi.wiring.package=org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.iana.afn.safi.rev130704)(version>=2013.7.0)(!(version>=2014.0.0)))
at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:3974)
at org.apache.felix.framework.Felix.startBundle(Felix.java:2037)
at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:955)
at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:942)
at org.apache.karaf.features.internal.FeaturesServiceImpl.startBundle(FeaturesServiceImpl.java:477)
at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:435)
at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:375)
at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:364)
at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:347)
at Proxy2e4b5728_150f_4198_a4a0_23ad6bc5f869.installFeature(Unknown Source)
at org.opendaylight.odlparent.featuretest.SingleFeatureTest.installFeature(SingleFeatureTest.java:205)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.ops4j.pax.exam.invoker.junit.internal.ContainerTestRunner.runChild(ContainerTestRunner.java:68)
at org.ops4j.pax.exam.invoker.junit.internal.ContainerTestRunner.runChild(ContainerTestRunner.java:37)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)

 Comments   
Comment by Martin Ciglan [ 16/Sep/15 ]

Hi Jeff

Could you please specify steps to reproduce this issue? Just to clarify it. Many thanks.

Comment by Tony Tkacik [ 16/Sep/15 ]

This seems as some private build of BGP PCEP, since single feature test in bgpcep project does not report this issue.

Comment by Jeff Liu [ 16/Sep/15 ]

in my draft change 26945, I'm trying to use the address-famiily and subesquent-address-family in iana-afi-safi yang module, that's when the SingleFeatureTest failed. The class generated by yangtool is versioned as rev130704, which is smaller than 140000. It seems SingleFeatureTest requires all module/classes to be greater than 140000.

you can checkout my 26945 draft change, and run the SingleFeatureTest to reproduce the error.

Comment by Robert Varga [ 17/Sep/15 ]

This is a problem with your changeset: you are introducing a dependency on iana-anf-safi, but you have not updated the BMP feature definition to pull it in, hence the failure.

Comment by Robert Varga [ 17/Sep/15 ]

Actually I spoke too soon, the problem is that iana-afn-safi is not included in the models features.

Comment by Robert Varga [ 17/Sep/15 ]

https://git.opendaylight.org/gerrit/27099
https://git.opendaylight.org/gerrit/27100

Generated at Wed Feb 07 20:53:26 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.