[YANGTOOLS-630] Parser: Refine without sub-statements should not be invalid Created: 08/Jul/16  Updated: 10/Apr/22  Resolved: 15/Jul/16

Status: Resolved
Project: yangtools
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Vratko Polak Assignee: Vratko Polak
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 6173

 Description   

Looking at specification of Yang 1.0 [0] or Yang 1.1 [1], it is NOT written that the refine statement has to perform at least one refinement. But the current parser deliberately throws an exception when an empty refine statement is encountered.

It should be possible to allow such empty refine statements without any obvious downside.
Issue Type set to Improvement, since the specification does NOT strictly imply that an empty refine statement is valid, either.

Example model to follow shortly.

[0] https://tools.ietf.org/html/rfc6020#section-7.12.2
[1] https://tools.ietf.org/html/draft-ietf-netmod-rfc6020bis-10#section-7.13.2

 Comments   
Comment by Vratko Polak [ 08/Jul/16 ]

Example module: https://git.opendaylight.org/gerrit/41551

Comment by Vratko Polak [ 08/Jul/16 ]

Attempted fix: https://git.opendaylight.org/gerrit/41552

Comment by Vratko Polak [ 15/Jul/16 ]

Do we want the fix to get into Beryllium? Before SR3?

Comment by Peter Kajsa [ 15/Jul/16 ]

https://git.opendaylight.org/gerrit/#/c/41880

Generated at Wed Feb 07 20:53:50 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.