[YANGTOOLS-713] Make YangStatementParserListenerImpl a Visitor Created: 11/Nov/16 Updated: 26/Feb/18 Resolved: 26/Feb/18 |
|
| Status: | Resolved |
| Project: | yangtools |
| Component/s: | parser |
| Affects Version/s: | None |
| Fix Version/s: | 2.0.2 |
| Type: | Improvement | ||
| Reporter: | Robert Varga | Assignee: | Robert Varga |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| Issue Links: |
|
||||||||
| Description |
|
We currently keep a list of statements to be skipped, which does not look like the right approach. Consider switching to visitor pattern, which allows us to control walking explictly. |
| Comments |
| Comment by Robert Varga [ 25/Feb/18 ] |
|
As it turns out a visitor is a good next step, but we really do not even need that, as our logic works on statements and their children only. |
| Comment by Robert Varga [ 25/Feb/18 ] |
|
Patch series: https://git.opendaylight.org/gerrit/68675 https://git.opendaylight.org/gerrit/68676 https://git.opendaylight.org/gerrit/68677 https://git.opendaylight.org/gerrit/68678
|