Eliminate duplicate DescriptionEffectiveStatementImpl objects (YANGTOOLS-694)

[YANGTOOLS-724] Make AbstractEffectiveDataSchemaNode.augmenting private and final Created: 01/Dec/16  Updated: 10/Apr/22  Resolved: 28/Jun/19

Status: Resolved
Project: yangtools
Component/s: None
Affects Version/s: None
Fix Version/s: 3.0.3

Type: Sub-task
Reporter: Peter Kajsa Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Issue Links:
Blocks
blocks YANGTOOLS-853 Fix EffectiveStatement namespace impl... Confirmed

 Description   

The augmenting flag not being final is a side-effect of how choice introduces implicit case statements. This is a rather unfortunate leak, which is preventing us from modifying structure inlining. Make sure implicit case statements are created when children effective statements are introduced, without having to reset the flag.



 Comments   
Comment by Robert Varga [ 13/Nov/17 ]

Partial fix delivered to 2.0.0 – the field is now guarded via a deprecated method.

Comment by Robert Varga [ 27/Feb/18 ]

This issue comes actually from statement copy operations not honoring implicit statements and copy history. https://git.opendaylight.org/gerrit/68838 is a work-in-progress patch to fix this issue. The full patch needs to address the choice/augment mess and eliminate the use of ImplicitCaseSchemaNode – which is a band-aid fixing up the root cause (which again is copy operation doing the wrong thing).

Generated at Wed Feb 07 20:54:07 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.