Eliminate duplicate DescriptionEffectiveStatementImpl objects
(YANGTOOLS-694)
|
|
| Status: | Resolved |
| Project: | yangtools |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Sub-task | ||
| Reporter: | Igor Foltin | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| Issue Links: |
|
||||||||
| Description |
|
Prerequisite.get() is used across several yang-parser-impl classes which utilize InferenceAction. In some places, the returned StmtContext needs to be downcasted to StatementContextBase in order to perform necessary operations with it later. |
| Comments |
| Comment by Robert Varga [ 07/Jun/17 ] |
|
I am not sure about the direction here. StatementContextBase is an implementation thing, we already have most operations executing on StmtContext {.Mutable}. We need to list out the operations executed on StatementContextBase and re-evaluate them in terms of inclusion into parser.spi.meta. The reason for this is very simple: parser.spi.meta is the interface spec, parser.stmt.reactor is the implementation (BuildGlobalContext is a NamespaceBehaviour.Registry). Hence there should be no dependencies going from spi to reactor – which is the case of StatementContextBase. This is important when addressing |