Operating System: All
Platform: All

Please can you also attach yang models causing this issue or at least all parts from them required to replication of the bug.

Thanks.

Attachment test-augment-statement1.yang has been added with description: test-augment-statement1.yang

Attachment test-augment-statement2.yang has been added with description: test-augment-statement2.yang

Attachment test-augment-statement3.yang has been added with description: test-augment-statement3.yang

Hi guys,
I have pushed three sample yang models.

Hi,

I looked at the 3 sample YANGs you provided and here's what's wrong with them.

The problem lies in the module test-augment-statement3 in the augment target path:

augment "/s1:top/s1:bar2" {
container cont-s3-aug {
}
}

The bar2 node should actually be prefixed with s2. This node was augmented into the s1:top container node from the test-augment-statement2 module
which means it is bound to that module's namespace. So you have to use the prefix of the test-augment-statement2 module.

Thanks, that's my mistake. I just did not notice the prefix of the augmented node.
So it seems the same problem of GengXingyuan's yang model,
in:
"augment "/stateful:pcrpt/stateful:pcrpt-message/stateful:reports/stateful:path/endpoints-obj/address-family""
properly before endpoints-obj and address-family, there should be added with the prefix "pcep:".

Could you please confirm that the problem was solved ? If yes, I would like to close this bug.

Problem remain after using the right prefix.

Because of our maven-repo's error.

module pcep-test {
yang-version 1;

namespace "urn:pcep:test:augment:statement1";
prefix pmsg;
organization "pcep.test.type.org";

import yang-ext

import pcep-types

import odl-pcep-ietf-stateful07

revision "2017-07-10";

augment "/stateful:pcrpt/stateful:pcrpt-message/stateful:reports/stateful:path"

augment "/stateful:pcrpt/stateful:pcrpt-message/stateful:reports/stateful:path/pcep:endpoints-obj/pcep:address-family" {
ext:augment-identifier rpt-generalized-endpoint-obj;
case pcep-topology-provider {
container pcepaug {
leaf aaa

}
}
}
}

module pcep-test {
yang-version 1;

namespace "urn:pcep:test:augment:statement1";
prefix pmsg;
organization "pcep.test.type.org";

import yang-ext

import pcep-types

import odl-pcep-ietf-stateful07

revision "2017-07-10";

augment "/stateful:pcrpt/stateful:pcrpt-message/stateful:reports/stateful:path"

augment "/stateful:pcrpt/stateful:pcrpt-message/stateful:reports/stateful:path/endpoints-obj/address-family" {
ext:augment-identifier rpt-generalized-endpoint-obj;
case pcep-topology-provider {
container pcepaug {
leaf aaa

}
}
}
}

Caused by: org.opendaylight.yangtools.yang.parser.spi.meta.InferenceException: Augment target 'Absolute

' not found [at META-INF/yang/pcep-test.yang:19:4]
at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition$1.prerequisiteFailed(AugmentStatementImpl.java:187)
at org.opendaylight.yangtools.yang.parser.stmt.reactor.ModifierImpl.failModifier(ModifierImpl.java:87)
at org.opendaylight.yangtools.yang.parser.stmt.reactor.SourceSpecificContext.failModifiers(SourceSpecificContext.java:341)
... 35 more

code is stable/carbon branch

[ERROR] yang-to-sources: Unable to parse yang files from E:\oscp\netconf\opendaylight\netconf\models\ietf-netconf\src\main\yang
org.opendaylight.yangtools.yang.parser.spi.meta.SomeModifiersUnresolvedException: Some of EFFECTIVE_MODEL modifiers for statements were not resolved.
at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.addSourceExceptions(BuildGlobalContext.java:303)
at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.completePhaseActions(BuildGlobalContext.java:343)
at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.buildEffective(BuildGlobalContext.java:200)
at org.opendaylight.yangtools.yang.parser.stmt.reactor.CrossSourceStatementReactor$BuildAction.buildEffective(CrossSourceStatementReactor.java:128)
at org.opendaylight.yangtools.yang.parser.stmt.reactor.CrossSourceStatementReactor$BuildAction.buildEffective(CrossSourceStatementReactor.java:145)
at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.processYang(YangToSourcesProcessor.java:191)
at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.execute(YangToSourcesProcessor.java:95)
at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesProcessor.conditionalExecute(YangToSourcesProcessor.java:118)
at org.opendaylight.yangtools.yang2sources.plugin.YangToSourcesMojo.execute(YangToSourcesMojo.java:119)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.opendaylight.yangtools.yang.parser.spi.meta.InferenceException: Yang model processing phase EFFECTIVE_MODEL failed [at META-INF\yang\pcep-test.yang:1:0]
at org.opendaylight.yangtools.yang.parser.stmt.reactor.SourceSpecificContext.failModifiers(SourceSpecificContext.java:306)
at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.addSourceExceptions(BuildGlobalContext.java:268)
... 30 more
Caused by: org.opendaylight.yangtools.yang.parser.spi.meta.InferenceException: Augment target 'Absolute

' not found [at META-INF\yang\pcep-test.yang:19:4]
at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition$1.prerequisiteFailed(AugmentStatementImpl.java:185)
at org.opendaylight.yangtools.yang.parser.stmt.reactor.ModifierImpl.failModifier(ModifierImpl.java:93)
at org.opendaylight.yangtools.yang.parser.stmt.reactor.SourceSpecificContext.failModifiers(SourceSpecificContext.java:294)

This is because choice address-family's mandatory is true in pcep-types.yang
after delete "mandatory true;",it's ok.

grouping endpoints {
choice address-family {
mandatory true;

case ipv4-case {
container ipv4 {
leaf source-ipv4-address

leaf destination-ipv4-address

}
}
case ipv6-case {
container ipv6 {
leaf source-ipv6-address

leaf destination-ipv6-address

}
}
}
}

So then the first augment below is invalid, because it is augment of the mandatory choice "address-family" into the target node (stateful:path) in another module. Therefore the augment is not performed (please see log, there should be an error or a warn about this)

augment "/stateful:pcrpt/stateful:pcrpt-message/stateful:reports/stateful:path"

and in consequence the following second augment below is not resolved, because the choice has not been added by the first augment and the exception was thrown:

augment "/stateful:pcrpt/stateful:pcrpt-message/stateful:reports/stateful:path/endpoints-obj/address-family" {
ext:augment-identifier rpt-generalized-endpoint-obj;
case generalized-endpoint-obj

}

For more info please see: https://tools.ietf.org/html/rfc6020#section-7.15
"If the target node is in another module, then nodes added by the
augmentation MUST NOT be mandatory nodes (see Section 3.1)."

Therefore I am closing this bug as invalid.