[YANGTOOLS-820] Clean up ModuleIdentifier use in yang-parser-impl Created: 16/Oct/17 Updated: 10/Apr/22 Resolved: 20/Nov/17 |
|
| Status: | Verified |
| Project: | yangtools |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.0.0 |
| Type: | Bug | ||
| Reporter: | Robert Varga | Assignee: | Robert Varga |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| Issue Links: |
|
||||||||
| External issue ID: | 9296 | ||||||||
| Description |
|
YANG parser's use of ModuleIdentifier is muddling its definition, because it is using weird wildcards to express import/belongs to statements – specifically it is using constants to express 'no revision'. These should be handled via a ModuleIdentifier matcher class, so that the wildcard match is correctly expressed and we can eliminate SimpleDateFormatUtil's DEFAULT_DATE_REV, DEFAULT_DATE_IMP and DEFAULT_BELONGS_TO_DATE. |
| Comments |
| Comment by Robert Varga [ 26/Oct/17 ] |
|
The blocking part has been resolved with reactor-side support for predicate-based selection. It is clear that ModuleIdentifier is not really needed because SourceIdentifier is solving the same problem with cleaner interactions. What remains is to migrate users to SourceIdentifier and kill ModuleIdentifier. |