[YANGTOOLS-83] Unnecessary import of RoutingContext Created: 18/Feb/14  Updated: 10/Apr/22  Resolved: 01/Jul/14

Status: Resolved
Project: yangtools
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement
Reporter: Robert Varga Assignee: Jozef Gloncak
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


 Description   

In the controller project, the flow service model (sal-flow.yang), the following snippet:

notification node-error-notification {
uses error:error-message;
uses tr:transaction-aware;
uses tr:transaction-metadata;
choice object-reference {
case flow-ref{
leaf flow-ref

{ type types:flow-ref; }

}
case group-ref{
leaf group-ref

{ type group-type:group-ref; }

}
case meter-ref{
leaf meter-ref

{ type meter-type:meter-ref; }

}
}
leaf node

{ ext:context-reference "inv:node-context"; type inv:node-ref; }

}

Results in unused:

import org.opendaylight.yangtools.yang.binding.annotations.RoutingContext;

being emitted in NodeErrorNotificationBuilder. This pollutes eclipse with warnings.

 Comments   
Comment by Jozef Gloncak [ 24/Feb/14 ]

Working on it.

Comment by Jozef Gloncak [ 24/Feb/14 ]

Following solution was proposed:
https://git.opendaylight.org/gerrit/#/c/5448/

Comment by Jozef Gloncak [ 29/Apr/14 ]

patch set 7
https://git.opendaylight.org/gerrit/#/c/5448/

still working on it.

Comment by Jozef Gloncak [ 30/Apr/14 ]

patch set 13

Comment by Jozef Gloncak [ 30/Apr/14 ]

patch set 15

for Class, StringBuilder and String classes always fully qualified name is used. It can happen that interface with name Class, StringBuilder or String is generated in other package (is child element in YANG) and then is included in including interface (parent YANG element) in which name conflict would occure.

Comment by Jozef Gloncak [ 30/Jun/14 ]

patch set 18 was uploaded.

importedName method is called also for every java.lang belonging class and these classes are now printed in fully qualified format.

Comment by Jozef Gloncak [ 01/Jul/14 ]

merged on 01JUL2014

Generated at Wed Feb 07 20:52:13 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.