[YANGTOOLS-844] Restconf fails for network-topology Created: 16/Jan/18  Updated: 10/Apr/22  Resolved: 17/Jan/18

Status: Resolved
Project: yangtools
Component/s: None
Affects Version/s: 2.0.0
Fix Version/s: 2.0.1

Type: Bug Priority: Highest
Reporter: Vishal Thapar Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: csit, netvirt, ovsdb
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

With the current yangtools/odlparent bump, restconf calls to perform any operation on network-topology models fails. This impacts OVSDB plugin as it uses network-topology for everything. This also impacts all OVSDB, Genius and Netvirt CSIT.

Issue seems to be loading two versions of network-topology models. Following 'fix' [1] to explicitly specify revision in OVSDB allowed me to get some things working in OVSDB plugin, restconf is still failing. Earlier same code was working even with 2 revisions of same model.

To check multiple revisions, load karaf from ovsdb/southbound-karaf distro and run 'bundle:find-class NetworkTopology' Curated output of same as follows:

ietf-topology-isis (265)
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopology.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyBuilder$1.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyBuilder$NetworkTopologyImpl.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyBuilder.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyData.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopology.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyBuilder$1.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyBuilder$NetworkTopologyImpl.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyBuilder.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyData.class

ietf-topology-l3-unicast-igp (266)
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopology.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyBuilder$1.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyBuilder$NetworkTopologyImpl.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyBuilder.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyData.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopology.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyBuilder$1.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyBuilder$NetworkTopologyImpl.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyBuilder.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyData.class

ietf-topology-ospf (267)
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopology.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyBuilder$1.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyBuilder$NetworkTopologyImpl.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyBuilder.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev131021/NetworkTopologyData.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopology.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyBuilder$1.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyBuilder$NetworkTopologyImpl.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyBuilder.class
org/opendaylight/yang/gen/v1/urn/tbd/params/xml/ns/yang/network/topology/rev130712/NetworkTopologyData.class

 

[1] https://git.opendaylight.org/gerrit/#/c/67191

 Comments   
Comment by Michael Vorburger [ 16/Jan/18 ]

FTR: Tom in https://lists.opendaylight.org/pipermail/yangtools-dev/2018-January/002091.html pointed to https://git.opendaylight.org/gerrit/#/c/66536/2/impl/src/main/java/org/opendaylight/jsonrpc/impl/Util.java ...

Comment by Robert Varga [ 17/Jan/18 ]

This a yangtools issue, as the SchemaContext implementations do not honour getModules() and related contracts.

Comment by Robert Varga [ 17/Jan/18 ]

https://git.opendaylight.org/gerrit/67212

Comment by Robert Varga [ 17/Jan/18 ]

This will need mdsal fix when integrated: https://git.opendaylight.org/gerrit/67242

Generated at Wed Feb 07 20:54:28 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.