[YANGTOOLS-914] ImmutableNodes.fromInstanceId() fails with YangInstanceIdentifier.EMPTY Created: 02/Nov/18  Updated: 04/Nov/18  Resolved: 04/Nov/18

Status: Resolved
Project: yangtools
Component/s: data-impl
Affects Version/s: 2.0.0
Fix Version/s: 2.1.3, 2.0.6.5, 2.0.13

Type: Bug Priority: Medium
Reporter: Claudio David Gasparini Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Merge of dto with create Parent set to true, will end on NoSuchElementException, when the dto path is the root.

public static final InstanceIdentifier<RoutingPolicy> ROUTING_POLICY_IID
= InstanceIdentifier.create(RoutingPolicy.class);

wtx.merge(LogicalDatastoreType.CONFIGURATION, ROUTING_POLICY_IID, routingPolicy,
WriteTransaction.CREATE_MISSING_PARENTS);

can be reproduced using patch[0] and running

OpenconfigRoutingPolicyLoaderTest

[0]https://git.opendaylight.org/gerrit/#/c/77460/

 

 

 

java.util.NoSuchElementException
 at com.google.common.collect.AbstractIndexedListIterator.next(AbstractIndexedListIterator.java:75)
 at org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNodes.fromInstanceId(ImmutableNodes.java:199)
 at org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNodes.fromInstanceId(ImmutableNodes.java:167)
 at org.opendaylight.mdsal.binding.dom.adapter.BindingToNormalizedNodeCodec.instanceIdentifierToNode(BindingToNormalizedNodeCodec.java:449)
 at org.opendaylight.mdsal.binding.dom.adapter.AbstractWriteTransaction.ensureParentsByMerge(AbstractWriteTransaction.java:125)
 at org.opendaylight.mdsal.binding.dom.adapter.AbstractWriteTransaction.merge(AbstractWriteTransaction.java:55)
 at org.opendaylight.bgpcep.config.loader.routing.policy.OpenconfigRoutingPolicyLoader.loadConfiguration(OpenconfigRoutingPolicyLoader.java:73)
 at org.opendaylight.bgpcep.config.loader.impl.ConfigLoaderImpl.handleConfigFile(ConfigLoaderImpl.java:93)
 at org.opendaylight.bgpcep.config.loader.impl.ConfigLoaderImpl.registerConfigFile(ConfigLoaderImpl.java:159)
 at org.opendaylight.bgpcep.config.loader.routing.policy.OpenconfigRoutingPolicyLoader.init(OpenconfigRoutingPolicyLoader.java:51)
 at org.opendaylight.bgpcep.config.loader.routing.policy.AbstractOpenconfigRoutingPolicyLoaderTest.setUp(AbstractOpenconfigRoutingPolicyLoaderTest.java:29)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:498)
 at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
 at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
 at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
 at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
 at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
 at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
 at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
 at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
 at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
 at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
 at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
 at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)

 

 

 



 Comments   
Comment by Robert Varga [ 02/Nov/18 ]

cdgasparini this is an improvement as, really, what parents do you want to create for a single-entry InstanceIdentifier?

Generated at Wed Feb 07 20:54:40 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.