[YANGTOOLS-942] Turn AutomaticLifecycleMixin into a ModificationApplyOperation Created: 30/Jan/19 Updated: 06/Feb/19 Resolved: 05/Feb/19 |
|
| Status: | Resolved |
| Project: | yangtools |
| Component/s: | data-impl |
| Affects Version/s: | None |
| Fix Version/s: | 3.0.0 |
| Type: | Improvement | Priority: | Medium |
| Reporter: | Robert Varga | Assignee: | Robert Varga |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Epic Link: | unlabeled-YANGTOOLS-940 | ||||||||||||||||
| Description |
|
The way AutomaticLifecycleMixin is plugged into the overall machinery requires subclassing and overriding of checkApplicable() and apply() methods. These are main entrypoints, which are not invoked from SchemaAwareApplyOperation, hence turning the mixin into a delegating wrapper should reduce the need for subclassing and result in better performance due to fewer implementations existing. |
| Comments |
| Comment by Robert Varga [ 05/Feb/19 ] |
|
This actually hurts performance in microbenchmarks. YANGTOOLS-943 is an alternative approach. |