[YANGTOOLS-947] Split out ModificationApplyOperation.verifyStructure() into two methods Created: 31/Jan/19 Updated: 05/Feb/19 Resolved: 05/Feb/19 |
|
| Status: | Resolved |
| Project: | yangtools |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.0.0, 2.0.17, 2.1.9 |
| Type: | Improvement | Priority: | Medium |
| Reporter: | Robert Varga | Assignee: | Robert Varga |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Epic Link: | unlabeled-YANGTOOLS-940 |
| Description |
|
This method is heavily overloaded, with a total of 8 implementations, most of which are doing the same thing. Furthermore the original call sites use a static true/false flag, which is indicative the two calls really are separate, with verifyChildren=true including the case of verifyChildren=false. Further confusion arises from recursivelyVerifyStructure(), which seems to be an unconditional variant of verifyStructure(verifyChildren=true). |