https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/AAA-171 aaa <p>Following <a href="https://git.opendaylight.org/gerrit/#/c/69415/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/69415/</a> (I think), and in development of <a href="https://git.opendaylight.org/gerrit/#/c/68767/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/68767/</a> Patch Set 5 after having gotten <a href="https://jira.opendaylight.org/browse/AAA-170" title="WebServer service API cannot be injected with @OsgiService annotation" class="issue-link" data-issue-key="AAA-170">AAA-170</a> out of the way, the SFT of odl-neutron-service deadlocks (see attached x3 jstack*.txt) in org.opendaylight.aaa.shiro.web.env.KarafIniWebEnvironment.init() when waiting for CompletableFuture.get, without any other relevant errors in karaf.log.</p> <p>Before anyone (Ryan) jumps in and starts reverting stuff, and because this is only seen in a not yet merged in dev Gerrit in Neutron, we should better understand what is really going on here - because AAA itself does seem to work; I suspect I may have made a mistake in Neutron, but I don't see which.</p> AAA-171

Remove KarafIniWebEnvironmentLoaderListener to avoid deadlock at org.opendaylight.aaa.shiro.web.env.KarafIniWebEnvironment.init() CompletableFuture.get

Bug Medium Resolved Won't Do Unassigned Michael Vorburger Fri, 16 Mar 2018 14:07:23 +0000 Mon, 27 Mar 2023 08:35:01 +0000 Sat, 4 Mar 2023 10:15:44 +0000 0 1 <p>Hit this again in <a href="https://git.opendaylight.org/gerrit/#/c/68767/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/68767/</a> ... it seems that the programmatic use of the @Deprecated <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/warning.png" height="16" width="16" align="absmiddle" alt="" border="0"/> :</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> .addListener(<span class="code-keyword">new</span> KarafIniWebEnvironmentLoaderListener())</pre> </div></div> <p>in a typical <tt>WebInitializer</tt> kind of class leads to this deadlock in the @Deprecated <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/warning.png" height="16" width="16" align="absmiddle" alt="" border="0"/> <tt>KarafIniWebEnvironment</tt>, at least some times; not sure if always.</p> <p>This problem gets fixed (doesn't happen anymore) in <a href="https://git.opendaylight.org/gerrit/#/c/69566/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/69566/</a> (which extends c/68767), because that, via the <tt>WebContextSecurer</tt> interface and <tt>ShiroWebContextSecurer</tt> impl, uses the <tt>ShiroWebEnvironmentLoaderListener</tt> instead of the <tt>KarafIniWebEnvironmentLoaderListener</tt>, and therefore the <tt>AAAIniWebEnvironment</tt> instead of the KarafIniWebEnvironment. This <tt>AAAIniWebEnvironment</tt> does not (have to) use <tt>AAAShiroProvider.INSTANCE_FUTURE.get()</tt> anymore, which is what's causing this deadlock.</p> <p>To move forward in Neutron for the short-term, I've combined c/68767 and c/69566 into <a href="https://git.opendaylight.org/gerrit/#/c/70339/" class="external-link" target="_blank" rel="nofollow noopener">c/70339</a> to go directly from web.xml to the new programmatic registration including WebContextSecurer (the 2 split changes where just to illustrate; my goal was always both).</p> <p>In the medium term, ideally still for the Fluorine release, we should probably compeltely remove the <tt>KarafIniWebEnvironmentLoaderListener</tt> and <tt>KarafIniWebEnvironment</tt> ... once we have switched over all projects requiring AAA from web.xml to the new programmatic registration mechanism.</p> Development Rank 0|i03br3: