[BGPCEP-1003] NPEs are meaningful on JDK17+

Thu, 7 Apr 2022 08:40:10 +0000

This is biting openjdk17 verify jobs in bgp-parser-impl:

[ERROR] testParseEmptyIpv4Attribute  Time elapsed: 0.005 s  <<< FAILURE!
java.lang.AssertionError: expected null, but was:<Cannot invoke "org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.next.hop.c.next.hop.ipv4.next.hop._case.Ipv4NextHop.getGlobal()" because the return value of "org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.next.hop.c.next.hop.Ipv4NextHopCase.getIpv4NextHop()" is null>
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotNull(Assert.java:756)
        at org.junit.Assert.assertNull(Assert.java:738)
        at org.junit.Assert.assertNull(Assert.java:748)
        at org.opendaylight.protocol.bgp.parser.impl.message.update.NextHopAttributeParserTest.testParseEmptyIpv4Attribute(NextHopAttributeParserTest.java:85)

The problem is that we have Helpful NullPointerExceptions in place, hence the message is not null.

OpenDaylight JIRA

[BGPCEP-1003] NPEs are meaningful on JDK17+