OpenDaylight JIRA

OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us

8.20.10

820010

22-06-2022

[BGPCEP-151] pcc-mock: enhancemnets https://jira.opendaylight.org/browse/BGPCEP-151 bgpcep <p>Minor changes, fixes and enhacements related to pcc-mock, by users requirements.</p> <p>Operating System: Linux<br/> Platform: PC</p> BGPCEP-151

pcc-mock: enhancemnets

Improvement Resolved Done Unassigned Milos Fabian Thu, 16 Oct 2014 15:26:51 +0000 Tue, 16 Nov 2021 06:24:53 +0000 Tue, 16 Nov 2021 06:24:52 +0000 Bugzilla Migration PCEP 0 5 <p>TODO - reported LSPs should contian at leat one hop path.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/12782/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/12782/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/12025/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/12025/</a></p> <p>Could you also add ability to configure </p> <p>-d, --deadtimer <N> (optional, default 0) - DeadTimer value in seconds<br/> -ka, --keepalive <N> (optional, deafult 30) - KeepAlive timer value in seconds</p> <p>(In reply to Hill from comment #3)<br/> > Could you also add ability to configure <br/> > <br/> > -d, --deadtimer <N> (optional, default 0) - DeadTimer value in seconds<br/> > -ka, --keepalive <N> (optional, deafult 30) - KeepAlive timer value in<br/> > seconds</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/13449/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/13449/</a></p> <p>TODO - enable a tunnel initiation and removal</p> <p>Will tunnel update be added?</p> <p>(In reply to Hill from comment #6)<br/> > Will tunnel update be added?</p> <p>Tunnel updating is already possible.</p> <p>More enhancements, to resemble behavior of routers better:</p> <ul> <li>Refuse remove-lsp on lsps present at start of pcc-mock, as if they were created by router CLI.</li> <li>When multiple remote addresses are provided, only the first one gets delegation flag set.</li> <li>Support "undelegate" request from remoteAddress for CLI-tunnels, re-delegate immediatelly to the next remoteAddress in cyclic order (if D was set, otherwise PcErr).</li> <li>Support "undelegate" and "get delegation" for instantiated tunnels, delete tunnel if not delegated certain (configurable) time.</li> </ul> <p>*pcc-mock support tunnel initiate and remove:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/15257/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/15257/</a></p> <p>*pcc-mock configurable port numbers:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/15112/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/15112/</a></p> <p>One more enhancement that may be useful for various stress tests, but most urgently for TCPMD5 testing:</p> <ul> <li>argument --reconnect <number><br/> specifying how many seconds to wait after TCP session went down (no matter if before or after negotiation) before PCC tries to reconnect. Without providing this argument, pcc-mock should never reconnect.</li> </ul> <p>(In reply to Vratko Polák from comment #10)<br/> > One more enhancement that may be useful for various stress tests, but most<br/> > urgently for TCPMD5 testing:<br/> > * argument --reconnect <number><br/> > specifying how many seconds to wait after TCP session went down (no matter<br/> > if before or after negotiation) before PCC tries to reconnect. Without<br/> > providing this argument, pcc-mock should never reconnect.</p> <p>*reconnect strategy<br/> <a href="https://git.opendaylight.org/gerrit/#/c/17800/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/17800/</a></p> <p>> but most urgently for TCPMD5 testing</p> <p>Actual TCPMD5 testing revealed that the behavior is different.<br/> When pcc-mock is using a password, but ODL is using no password (or wrong password), pcc-mock gets stuck in what looks like "creating TCPMD5 connection" phase. When ODL is re-configured to use the correct password, it does not affect this connection attempt, pcc-mock is still stuck. Ctrl+c and starting pcc-mock leads to successful PCEP connection established.</p> <p>I am not sure yet what the correct course of action is, but this new pcc-mock feature would be useful:</p> <ul> <li>--connection-timeout <seconds><br/> specifies time pcc-mock should spend in "creating TCP(MD5) connection" phase. 0 means "wait forever" and is default value.<br/> After time is out, destroy the channel and act according to reconnect strategy.</li> </ul> <p>Failures in this suite track deficiencies of current pcc-mock behavior: <a href="https://jenkins.opendaylight.org/releng/view/CSIT-Jobs/job/bgpcep-csit-1node-cds-userfeatures-only-stable-lithium/lastSuccessfulBuild/robot/bgpcep-userfeatures.txt/Pcepuser/" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/releng/view/CSIT-Jobs/job/bgpcep-csit-1node-cds-userfeatures-only-stable-lithium/lastSuccessfulBuild/robot/bgpcep-userfeatures.txt/Pcepuser/</a></p> <p>Perhaps it was a mistake to specify user-facing feature tests in <a href="https://wiki.opendaylight.org/view/BGP_LS_PCEP:Lithium_Feature_Tests#How_to_test" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.opendaylight.org/view/BGP_LS_PCEP:Lithium_Feature_Tests#How_to_test</a><br/> to rely on a not-yet-implemented behavior, but it is now a part of Lithium formal process, and the results are publicly visible.</p> <p>So perhaps it is worth fixing pcc-mock to make sure nobody thinks failures are due to PCEP functionality in ODL.</p> <p>(In reply to Vratko Polák from comment #12)<br/> > Actual TCPMD5 testing revealed that the behavior is different.<br/> > When pcc-mock is using a password, but ODL is using no password (or wrong<br/> > password), pcc-mock gets stuck in what looks like "creating TCPMD5<br/> > connection" phase. When ODL is re-configured to use the correct password, it<br/> > does not affect this connection attempt, pcc-mock is still stuck. Ctrl+c and<br/> > starting pcc-mock leads to successful PCEP connection established.</p> <p>I retract this paragraph.<br/> Maybe the issue was there, but was fixed since then.<br/> Maybe <a href="https://jira.opendaylight.org/browse/CONTROLLER-1361" title="Restconf attempt to change TCPMD5 password for PCEP client fails silently" class="issue-link" data-issue-key="CONTROLLER-1361"><del>CONTROLLER-1361</del></a> (which was active at time the paragraph was written) confused me.<br/> Either way, RC1 build from 2015-06-16 works equally well with or without pcc-mock restart: Connection is established as soon as ODL is re-configured to use correct password.</p> <p>From pcc-mock side, default flag issue remains (which is entirely my fault, as I have not mentioned it explicitly before). The issue manifests as this diff between expected <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/forbidden.png" height="16" width="16" align="absmiddle" alt="" border="0"/> and actual <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/add.png" height="16" width="16" align="absmiddle" alt="" border="0"/> jsons from pcep-topology:</p> <ul class="alternate" type="square"> <li>"operational": "up",<br/> + "operational": "down",<br/> "plsp-id": 1,<br/> "processing-rule": false,<br/> "remove": false,</li> <li>"sync": true,<br/> + "sync": false,</li> </ul> <p>Real devices usually report the <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/add.png" height="16" width="16" align="absmiddle" alt="" border="0"/> state first (without ERO), then proceed on setting up LSP and finally report the <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/forbidden.png" height="16" width="16" align="absmiddle" alt="" border="0"/> state with ERO. For Lithium tests, the simplest action is to make pcc-mock send only one report, the <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/forbidden.png" height="16" width="16" align="absmiddle" alt="" border="0"/> state with ERO.</p> <p>(In reply to Vratko Polák from comment #8)<br/> > More enhancements, to resemble behavior of routers better:<br/> > * Refuse remove-lsp on lsps present at start of pcc-mock, as if they were<br/> > created by router CLI.<br/> > * When multiple remote addresses are provided, only the first one gets<br/> > delegation flag set.<br/> > * Support "undelegate" request from remoteAddress for CLI-tunnels,<br/> > re-delegate immediatelly to the next remoteAddress in cyclic order (if D was<br/> > set, otherwise PcErr).<br/> > * Support "undelegate" and "get delegation" for instantiated tunnels, delete<br/> > tunnel if not delegated certain (configurable) time.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/22853/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/22853/</a></p> <p>This discrepancy still prevents CSIT jobs to get good passrate:</p> <ul class="alternate" type="square"> <li>"sync": true,<br/> + "sync": false,</li> </ul> <p>> the simplest action is to make pcc-mock send only one report, the <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/forbidden.png" height="16" width="16" align="absmiddle" alt="" border="0"/> state with ERO.</p> <p>I just realized another discrepancy was never mentioned here (my fault):</p> <ul class="alternate" type="square"> <li>"odl-pcep-ietf-initiated00:create": false,<br/> + "odl-pcep-ietf-initiated00:create": true,</li> </ul> <p>pcc-mock report after add-lsp should really mark the newly created tunnel as instantiated.</p> <p>"sync" and "create" flags fixed: <a href="https://git.opendaylight.org/gerrit/#/c/25525/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/25525/</a></p> <p>update pcc-mock to support <a href="https://tools.ietf.org/html/draft-ietf-pce-stateful-sync-optimizations-03" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/draft-ietf-pce-stateful-sync-optimizations-03</a></p> <p><a href="https://git.opendaylight.org/gerrit/#/c/30491/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/30491/</a></p> <p>Since Boron, JRE version used in CSIT jobs is tied with stream (Boron gets Java 8, Beryllium and earlier get Java 7). As a consequence, test suites were changed, so that now Lithium jobs use Lithium version of pcc-mock.</p> <p>Lithium csit job <span class="error">[0]</span> shows that several improvements were not back-ported to Lithium, even though they are used to test lithium functionality. Most notably sync/create fix <span class="error">[1]</span>, and the big change which includes delegation-related behavior <span class="error">[2]</span>.</p> <p>The improvements should be backported to Lithium (possibly with other changes) to fix CSIT results.</p> <p><span class="error">[0]</span> <a href="https://jenkins.opendaylight.org/releng/view/bgpcep/job/bgpcep-csit-1node-userfeatures-only-stable-lithium/lastSuccessfulBuild/robot/bgpcep-userfeatures.txt/Pcepuser/" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/releng/view/bgpcep/job/bgpcep-csit-1node-userfeatures-only-stable-lithium/lastSuccessfulBuild/robot/bgpcep-userfeatures.txt/Pcepuser/</a><br/> <span class="error">[1]</span> <a href="https://git.opendaylight.org/gerrit/25525" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/25525</a><br/> <span class="error">[2]</span> <a href="https://git.opendaylight.org/gerrit/22853" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/22853</a></p> <p>No enhancements required for Boron</p> <p>All requested enhancements have been delivered, any further items need to be tracked separately.</p> Development External issue ID 2208 External issue URL Issue Type ODL SR Target Milestone Rank 0|i02ain: