[BGPCEP-172] F flag of sr-ero-subobject is not taken into account.

Sun, 3 Mar 2019 11:50:21 +0000

I POST add-lsp to restAPI: http://147.128.12.111:8080/restconf/operations/network-topology-pcep:add-lsp
The f flag is set and NAI is null. But I got exception as following.
If I remove f flag and set NAI, it is PASSED. It looks like the code does not take f flag into account, please check.

<subobject>
<loose>false</loose>
<sid-type>ipv4-node-id</sid-type>
<flags>f m</flags>
<sid>103</sid>
</subobject>

22:45:16.306 [nioEventLoopGroup-3-1] WARN i.n.channel.DefaultChannelPipeline - An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
org.opendaylight.protocol.pcep.spi.PCEPDeserializerException: Wrong length of array of bytes. Passed: 6;
at org.opendaylight.protocol.pcep.segment.routing02.SrEroSubobjectParser.parseSubobject(SrEroSubobjectParser.java:116) ~[classes/:na]
at org.opendaylight.protocol.pcep.spi.pojo.SimpleEROSubobjectRegistry.parseSubobject(SimpleEROSubobjectRegistry.java:44) ~[classes/:na]
at org.opendaylight.protocol.pcep.impl.object.AbstractEROWithSubobjectsParser.parseSubobjects(AbstractEROWithSubobjectsParser.java:49) ~[classes/:na]
at org.opendaylight.protocol.pcep.impl.object.PCEPExplicitRouteObjectParser.parseObject(PCEPExplicitRouteObjectParser.java:43) ~[classes/:na]
at org.opendaylight.protocol.pcep.impl.object.PCEPExplicitRouteObjectParser.parseObject(PCEPExplicitRouteObjectParser.java:26) ~[classes/:na]
at org.opendaylight.protocol.pcep.spi.pojo.SimpleObjectRegistry.parseObject(SimpleObjectRegistry.java:67) ~[classes/:na]
at org.opendaylight.protocol.pcep.spi.AbstractMessageParser.parseObjects(AbstractMessageParser.java:106) ~[classes/:na]
at org.opendaylight.protocol.pcep.spi.AbstractMessageParser.parseMessage(AbstractMessageParser.java:137) ~[classes/:na]
at org.opendaylight.protocol.pcep.spi.pojo.SimpleMessageRegistry.parseMessage(SimpleMessageRegistry.java:50) ~[classes/:na]
at org.opendaylight.protocol.pcep.impl.PCEPByteToMessageDecoder.parse(PCEPByteToMessageDecoder.java:79) ~[classes/:na]
at org.opendaylight.protocol.pcep.impl.PCEPByteToMessageDecoder.decode(PCEPByteToMessageDecoder.java:52) ~[classes/:na]
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:249) [netty-codec-4.0.23.Final.jar:4.0.23.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:149) [netty-codec-4.0.23.Final.jar:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [netty-transport-4.0.23.Final.jar:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [netty-transport-4.0.23.Final.jar:4.0.23.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:163) [netty-codec-4.0.23.Final.jar:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) [netty-transport-4.0.23.Final.jar:4.0.23.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:319) [netty-transport-4.0.23.Final.jar:4.0.23.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:787) [netty-transport-4.0.23.Final.jar:4.0.23.Final]
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:130) [netty-transport-4.0.23.Final.jar:4.0.23.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511) [netty-transport-4.0.23.Final.jar:4.0.23.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468) [netty-transport-4.0.23.Final.jar:4.0.23.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382) [netty-transport-4.0.23.Final.jar:4.0.23.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354) [netty-transport-4.0.23.Final.jar:4.0.23.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116) [netty-common-4.0.23.Final.jar:4.0.23.Final]
at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137) [netty-common-4.0.23.Final.jar:4.0.23.Final]
at java.lang.Thread.run(Thread.java:745) [na:1.7.0_65]

OpenDaylight JIRA

[BGPCEP-172] F flag of sr-ero-subobject is not taken into account.