[BGPCEP-473] PCErr generated while parsing of received PCRpt message is not sent out

Sun, 3 Mar 2019 11:49:46 +0000

While trying to verify fix for https://bugs.opendaylight.org/show_bug.cgi?id=5731, noticed that when PCRpt with missing LSP-IDENTIFIERS TLV is received, error message with type=6 value=11 is generated now, but it is not getting sent out (i.e. not seem in wireshark capture)

On further debugging by adding more log messages etc., it is seen that below exception is received when trying to send the message out, because of which it fails

2016-06-03 21:29:37,437 | INFO | oupCloseable-6-3 | Stateful07PCReportMessageParser | 298 - org.opendaylight.bgpcep.pcep-ietf-stateful07 - 0.5.2.Beryllium-SR2 | >>>>> validateLsp: creating error message...
2016-06-03 21:29:37,443 | INFO | oupCloseable-6-3 | Stateful07PCReportMessageParser | 298 - org.opendaylight.bgpcep.pcep-ietf-stateful07 - 0.5.2.Beryllium-SR2 | >>>>> getValidReports: object is Ero [_subobject=[Subobject [_subobjectType=IpPrefixCase [_ipPrefix=IpPrefix [_ipPrefix=IpPrefix [_ipv4Prefix=Ipv4Prefix [_value=1.1.1.1/32], _value=[1, ., 1, ., 1, ., 1, /, 3, 2]], augmentation=[]], augmentation=[]], _loose=false, augmentation=[]]], _ignore=false, _processingRule=false, augmentation=[]]
2016-06-03 21:29:37,443 | INFO | oupCloseable-6-3 | Stateful07PCReportMessageParser | 298 - org.opendaylight.bgpcep.pcep-ietf-stateful07 - 0.5.2.Beryllium-SR2 | >>>>> validateLsp: here1
2016-06-03 21:29:37,443 | INFO | oupCloseable-6-3 | Stateful07PCReportMessageParser | 298 - org.opendaylight.bgpcep.pcep-ietf-stateful07 - 0.5.2.Beryllium-SR2 | >>>>> validateLsp: here3
2016-06-03 21:29:37,444 | INFO | oupCloseable-6-3 | PCEPByteToMessageDecoder | 289 - org.opendaylight.bgpcep.pcep-impl - 0.5.2.Beryllium-SR2 | >>> errors: [Pcerr [_pcerrMessage=PcerrMessage [_errors=[Errors [_errorObject=ErrorObject [_type=6, _value=11, augmentation=[]], augmentation=[]]], augmentation=[]], augmentation=[]], Pcerr [_pcerrMessage=PcerrMessage [_errors=[Errors [_errorObject=ErrorObject [_type=6, _value=8, augmentation=[]], augmentation=[]]], augmentation=[]], augmentation=[]]]
2016-06-03 21:29:37,444 | INFO | oupCloseable-6-3 | PCEPByteToMessageDecoder | 289 - org.opendaylight.bgpcep.pcep-impl - 0.5.2.Beryllium-SR2 | >>> handling error messages...
2016-06-03 21:29:37,444 | INFO | oupCloseable-6-3 | PCEPByteToMessageDecoder | 289 - org.opendaylight.bgpcep.pcep-impl - 0.5.2.Beryllium-SR2 | >>> handling error message Pcerr [_pcerrMessage=PcerrMessage [_errors=[Errors [_errorObject=ErrorObject [_type=6, _value=11, augmentation=[]], augmentation=[]]], augmentation=[]], augmentation=[]]
2016-06-03 21:29:37,445 | INFO | oupCloseable-6-3 | PCEPByteToMessageDecoder | 289 - org.opendaylight.bgpcep.pcep-impl - 0.5.2.Beryllium-SR2 | Failed to send message
java.lang.UnsupportedOperationException: unsupported message type: PcerrBuilder$PcerrImpl (expected: ByteBuf, FileRegion)
at io.netty.channel.nio.AbstractNioByteChannel.filterOutboundMessage(AbstractNioByteChannel.java:282)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannel$AbstractUnsafe.write(AbstractChannel.java:711)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.DefaultChannelPipeline$HeadContext.write(DefaultChannelPipeline.java:1122)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:643)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:700)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:636)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:622)[53:io.netty.transport:4.0.33.Final]
at org.opendaylight.protocol.pcep.impl.PCEPByteToMessageDecoder.decode(PCEPByteToMessageDecoder.java:66)[289:org.opendaylight.bgpcep.pcep-impl:0.5.2.Beryllium-SR2]
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:360)[54:io.netty.codec:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:244)[54:io.netty.codec:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:318)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:304)[53:io.netty.transport:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:276)[54:io.netty.codec:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:263)[54:io.netty.codec:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:318)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:304)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:846)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354)[53:io.netty.transport:4.0.33.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:112)[52:io.netty.common:4.0.33.Final]
at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)[52:io.netty.common:4.0.33.Final]
at java.lang.Thread.run(Thread.java:745)[:1.7.0_95]
2016-06-03 21:29:37,446 | INFO | oupCloseable-6-3 | PCEPByteToMessageDecoder | 289 - org.opendaylight.bgpcep.

OpenDaylight JIRA

[BGPCEP-473] PCErr generated while parsing of received PCRpt message is not sent out