[BGPCEP-512] Missing ORIGIN attribute can break app-peer

Sun, 3 Mar 2019 11:49:50 +0000

In CSIT Userfeatures test job, "Ibgp Peer Lsp" suite sends update message without ORIGIN attribute (a current bug in the suite).

ODL disconnects the peer, but fails to perform correct cleanup.
There is a suite running before "Ibgp Peer Lsp" which configures and then deconfigures app-peer. "Ibgp Peer Lsp" suite itself does not interact with app-peer.

Every suite after "Ibgp Peer Lsp" fails at test cases which expect consequences initiated by app-peer (each time app-peer is configured anew). Test cases for bgp-rib consequences from external peer are still passing

Looking at karaf.log there seem to be a transaction chain left in failed state.
Full log: https://logs.opendaylight.org/releng/jenkins092/bgpcep-csit-1node-userfeatures-only-boron/864/archives/karaf.log.gz

Parts on karaf.log lines:

2016-08-09 01:15:25,444 | ERROR | entLoopGroup-5-7 | BGPDocumentedException | 89 - org.opendaylight.bgpcep.bgp-parser-api - 0.6.0.SNAPSHOT | Error = WELL_KNOWN_ATTR_MISSING
org.opendaylight.protocol.bgp.parser.BGPDocumentedException: Well known mandatory attribute missing: ORIGIN

2016-08-09 01:15:25,444 | WARN | entLoopGroup-5-7 | BGPSessionImpl | 185 - org.opendaylight.bgpcep.bgp-rib-impl - 0.6.0.SNAPSHOT | BGP session encountered error
io.netty.handler.codec.DecoderException: org.opendaylight.protocol.bgp.parser.BGPDocumentedException: Well known mandatory attribute missing: ORIGIN

{error=WELL_KNOWN_ATTR_MISSING}

{channel=[id: 0x58e9ec32, L:/10.29.12.199:1790 ! R:/10.29.12.108:17900], state=IDLE}

2016-08-09 01:15:25,455 | WARN | ult-dispatcher-6 | ShardDataTree | 172 - org.opendaylight.controller.sal-distributed-datastore - 1.4.0.SNAPSHOT | member-1-shard-default-operational: Store Tx member-1-datastore-operational-fe-0-chn-58-txn-2: Data validation failed

2016-08-09 01:15:25,461 | ERROR | CommitFutures-0 | BGPPeer | 185 - org.opendaylight.bgpcep.bgp-rib-impl - 0.6.0.SNAPSHOT | Transaction chain failed.
TransactionCommitFailedException{message=Data did not pass validation.

2016-08-09 01:15:56,268 | WARN | lt-dispatcher-20 | ShardDataTree | 172 - org.opendaylight.controller.sal-distributed-datastore - 1.4.0.SNAPSHOT | member-1-shard-default-operational: Store Tx member-1-datastore-operational-fe-0-chn-62-txn-0: Conflicting modification for path

{message=Optimistic lock failed., errorList=[RpcError [message=Optimistic lock failed., severity=ERROR, errorType=APPLICATION, tag=resource-denied, applicationTag=null, info=null, cause=org.opendaylight.yangtools.yang.data.api.schema.tree.ConflictingModificationAppliedException: Node was created by other transaction.]]}

2016-08-09 01:16:10,609 | ERROR | n-dispatcher-146 | DataTreeChangeListenerActor | 172 - org.opendaylight.controller.sal-distributed-datastore - 1.4.0.SNAPSHOT | Error notifying listener org.opendaylight.protocol.bgp.rib.impl.ApplicationPeer@284e83ce
java.lang.IllegalStateException: Transaction chain has failed

OpenDaylight JIRA

[BGPCEP-512] Missing ORIGIN attribute can break app-peer