[BGPCEP-544] On connection reset by peer, sometimes re-connection attempt stops after HoldTimer expired error

Sun, 3 Mar 2019 11:49:53 +0000

Issue seen on both beryllium and boron. Scenario is as follows:

1. Connection up between ODL and XRv router

2. Connection is reset from router side (by executing "no neighbor ..." under "router bgp ..." mode)

3. ODL tries to reconnect, but after approx. 4 minutes below error is seen, and subsequently no further re-connection attempts are made from ODL side

2016-09-07 16:28:49,437 | WARN | oupCloseable-6-4 | AbstractBGPSessionNegotiator | 279 - org.opendaylight.bgpcep.bgp-rib-impl - 0.5.0.Beryllium | Failed to send message Notify [_errorCode=4, _errorSubcode=0, augmentation=[]]
java.nio.channels.ClosedChannelException
2016-09-07 16:28:49,438 | DEBUG | oupCloseable-6-4 | AbstractBGPSessionNegotiator | 279 - org.opendaylight.bgpcep.bgp-rib-impl - 0.5.0.Beryllium | Negotiation on channel [id: 0x5e2964cc, /10.18.162.238:52739 :> /10.18.133.131:179] failed
java.nio.channels.ClosedChannelException
2016-09-07 16:28:49,438 | WARN | oupCloseable-6-4 | DefaultPromise | 52 - io.netty.common - 4.0.33.Final | An exception was thrown by org.opendaylight.protocol.bgp.rib.impl.AbstractBGPSessionNegotiator$2.operationComplete()
java.lang.IllegalStateException: complete already: BGPProtocolSessionPromise@1d30caf5(failure: java.io.IOException: Connection reset by peer)
at io.netty.util.concurrent.DefaultPromise.setFailure(DefaultPromise.java:418)[52:io.netty.common:4.0.33.Final]
at org.opendaylight.protocol.bgp.rib.impl.AbstractBGPSessionNegotiator.negotiationFailedCloseChannel(AbstractBGPSessionNegotiator.java:241)[279:org.opendaylight.bgpcep.bgp-rib-impl:0.5.0.Beryllium]
at org.opendaylight.protocol.bgp.rib.impl.AbstractBGPSessionNegotiator.access$500(AbstractBGPSessionNegotiator.java:44)[279:org.opendaylight.bgpcep.bgp-rib-impl:0.5.0.Beryllium]
at org.opendaylight.protocol.bgp.rib.impl.AbstractBGPSessionNegotiator$2.operationComplete(AbstractBGPSessionNegotiator.java:250)[279:org.opendaylight.bgpcep.bgp-rib-impl:0.5.0.Beryllium]
at org.opendaylight.protocol.bgp.rib.impl.AbstractBGPSessionNegotiator$2.operationComplete(AbstractBGPSessionNegotiator.java:245)[279:org.opendaylight.bgpcep.bgp-rib-impl:0.5.0.Beryllium]
at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:680)[52:io.netty.common:4.0.33.Final]
at io.netty.util.concurrent.DefaultPromise.notifyLateListener(DefaultPromise.java:621)[52:io.netty.common:4.0.33.Final]
at io.netty.util.concurrent.DefaultPromise.addListener(DefaultPromise.java:138)[52:io.netty.common:4.0.33.Final]
at io.netty.channel.DefaultChannelPromise.addListener(DefaultChannelPromise.java:93)[53:io.netty.transport:4.0.33.Final]
at io.netty.channel.DefaultChannelPromise.addListener(DefaultChannelPromise.java:28)[53:io.netty.transport:4.0.33.Final]
at org.opendaylight.protocol.bgp.rib.impl.AbstractBGPSessionNegotiator.sendMessage(AbstractBGPSessionNegotiator.java:245)[279:org.opendaylight.bgpcep.bgp-rib-impl:0.5.0.Beryllium]
at org.opendaylight.protocol.bgp.rib.impl.AbstractBGPSessionNegotiator.access$200(AbstractBGPSessionNegotiator.java:44)[279:org.opendaylight.bgpcep.bgp-rib-impl:0.5.0.Beryllium]
at org.opendaylight.protocol.bgp.rib.impl.AbstractBGPSessionNegotiator$1.run(AbstractBGPSessionNegotiator.java:120)[279:org.opendaylight.bgpcep.bgp-rib-impl:0.5.0.Beryllium]
at io.netty.util.concurrent.PromiseTask$RunnableAdapter.call(PromiseTask.java:38)[52:io.netty.common:4.0.33.Final]
at io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:120)[52:io.netty.common:4.0.33.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:358)[52:io.netty.common:4.0.33.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357)[53:io.netty.transport:4.0.33.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:112)[52:io.netty.common:4.0.33.Final]
at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)[52:io.netty.common:4.0.33.Final]
at java.lang.Thread.run(Thread.java:745)[:1.7.0_95]
Caused by: java.nio.channels.ClosedChannelException
2016-09-07 16:28:49,439 | ERROR | oupCloseable-6-4 | BGPDocumentedException | 264 - org.opendaylight.bgpcep.bgp-parser-api - 0.5.0.Beryllium | Error = FSM_ERROR
org.opendaylight.protocol.bgp.parser.BGPDocumentedException: HoldTimer expired
at org.opendaylight.protocol.bgp.rib.impl.AbstractBGPSessionNegotiator$1.run(AbstractBGPSessionNegotiator.java:121)[279:org.opendaylight.bgpcep.bgp-rib-impl:0.5.0.Beryllium]
at io.netty.util.concurrent.PromiseTask$RunnableAdapter.call(PromiseTask.java:38)[52:io.netty.common:4.0.33.Final]
at io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:120)[52:io.netty.common:4.0.33.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:358)[52:io.netty.common:4.0.33.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357)[53:io.netty.transport:4.0.33.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:112)[52:io.netty.common:4.0.33.Final]
at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)[52:io.netty.common:4.0.33.Final]
at java.lang.Thread.run(Thread.java:745)[:1.7.0_95]

OpenDaylight JIRA

[BGPCEP-544] On connection reset by peer, sometimes re-connection attempt stops after HoldTimer expired error