https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/BGPCEP-695 bgpcep <p>When the next-hop value is put as empty value in flowspec, a NPE will be thrown.</p> <p>next-hop attribute is a mandatory attribute in BGP update message. However, it could have zero length in flowspec. ODL is not handling the zero-length case properly.</p> <p>Related issue:<br/> <a href="https://bugs.opendaylight.org/show_bug.cgi?id=5791" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=5791</a></p> <p>Operating System: All<br/> Platform: All</p> BGPCEP-695

NPE when next-hop attribute is empty

Bug Resolved Done Claudio David Gasparini Kevin Wang Tue, 10 Oct 2017 18:02:51 +0000 Tue, 20 Jul 2021 10:47:16 +0000 Tue, 20 Jul 2021 10:47:16 +0000 Bugzilla Migration Sodium BGP 0 2 <p>Attachment karaf.log.zip has been added with description: karaf log</p> <p>Waiting for review: <a href="https://git.opendaylight.org/gerrit/#/c/64129/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/64129/</a></p> <p>Hi Kevin, this an specific case for flowspec, please add the<br/> reference to the draft/RFC mentioning it to the commit.<br/> Also you should be updating nexhop handlers for flowspec only<br/> <a href="https://git.opendaylight.org/gerrit/gitweb?p=bgpcep.git;a=blob;f=bgp/flowspec/src/main/java/org/opendaylight/protocol/bgp/flowspec/BGPActivator.java;h=d15246bc1060e000b6092b389e03855bbe0aa510;hb=refs/heads/master" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/gitweb?p=bgpcep.git;a=blob;f=bgp/flowspec/src/main/java/org/opendaylight/protocol/bgp/flowspec/BGPActivator.java;h=d15246bc1060e000b6092b389e03855bbe0aa510;hb=refs/heads/master</a>.<br/> &gt;<br/> Also add some test coverage for this case.<br/> &gt;<br/> Regards<br/> Hi Claudio,I think the problem is we should prevent such case from happening<br/> in RESTCONF. If next-hop is required and user submit a RESTCONF<br/> request with empty next-hop, the cohort should return an exception<br/> immediate.Another thing is, we find that if user put &lt;ipv4-next-hop&gt;8.8.8.8&lt;/ipv4-next-hop&gt;<br/> in the payload, there is no error to be returned either. However,<br/> &lt;ipv4-next-hop&gt;&lt;global&gt;8.8.8.8&lt;/global&gt;&lt;/ipv4-next-hop&gt; is the<br/> correct format.So we need either add a mdsal cohort checking for these sort of<br/> thing (don't think we have such checking in bgp yet), or change the<br/> yang model to make these field mandatory</p> <p>Hi Kevin,</p> <ul class="alternate" type="square"> <li>the patch is abandoned since we agree that is not the correct solution.</li> <li>regarding the issue of pushing ipv4-next-hop against ipv4-next-hop/global, if you consider that it shouldn't work please open a bug for RESTCONF so the issue doesn't get lost.</li> <li>Making the next-hop mandatory in the yang model might be more complicated that it looks, its requires to check where is used the<br/> updated model and if is correct to be mandatory on all the cases, etc.., anyway when you push the new fix, we can go through it again.</li> </ul> <p>Regards,</p> <p>Claudio</p> <p>Hi <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=cdgasparini" class="user-hover" rel="cdgasparini">cdgasparini</a>,<br/> Do we have any RESTCONF cohort checking in bgp project?<br/> The best solution is to forbid user from injecting empty ipv4-next-hop from restconf. It should be either ipv4-next-hop with a valid IP provided, or the element not appeared at all. An empty element &lt;ipv4-next-hop /&gt; should not be allowed.<br/> If there is such cohort framework exist already in bgp project that I can leverage it will be great.<br/> Or if you have a better solution please let me know.</p> <p>The fundamental goal is to prevent invalid data from user input. The flowspec handler can only ignore such invalid data without fixing it. When flowspec handler is invoked, it's already at packet serialization stage.</p> Development External issue ID 9265 External issue URL Rank 0|i02dvj: