<!-- 
RSS generated by JIRA (8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d) at Wed Feb 07 19:13:57 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>OpenDaylight JIRA</title>
    <link>https://jira.opendaylight.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.20.10</version>
        <build-number>820010</build-number>
        <build-date>22-06-2022</build-date>
    </build-info>


<item>
            <title>[BGPCEP-732] BGP Peer name forced to be Ipv4</title>
                <link>https://jira.opendaylight.org/browse/BGPCEP-732</link>
                <project id="10108" key="BGPCEP">bgpcep</project>
                    <description>&lt;p&gt;in org.opendaylight.protocol.bgp.rib.impl.BGPPeer constructor&lt;/p&gt;

&lt;p&gt;peer name(String) is used as following&lt;/p&gt;

&lt;p&gt;&lt;font color=&quot;#000080&quot;&gt;super&lt;/font&gt;(rib.getInstanceIdentifier(), &lt;font color=&quot;#000080&quot;&gt;null&lt;/font&gt;, &lt;font color=&quot;#000080&quot;&gt;new &lt;/font&gt;IpAddress(&lt;font color=&quot;#000080&quot;&gt;new &lt;/font&gt;Ipv4Address(name)), afiSafisAdvertized,afiSafisGracefulAdvertized);&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;When used in in org.opendaylight.protocol.bgp.rib.impl.config.BGPPeer&lt;/p&gt;

&lt;p&gt;&lt;font color=&quot;#000080&quot;&gt;this&lt;/font&gt;.&lt;font color=&quot;#660e7a&quot;&gt;bgpPeer &lt;/font&gt;= &lt;font color=&quot;#000080&quot;&gt;new &lt;/font&gt;BGPPeer(&lt;b&gt;Ipv4Util.toStringIP(&lt;font color=&quot;#000080&quot;&gt;this&lt;/font&gt;.&lt;font color=&quot;#660e7a&quot;&gt;neighborAddress&lt;/font&gt;)&lt;/b&gt;, rib,&lt;br/&gt;
 OpenConfigMappingUtil.toPeerRole(neighbor), getSimpleRoutingPolicy(neighbor),&lt;br/&gt;
 BgpPeer.&lt;font color=&quot;#000080&quot;&gt;this&lt;/font&gt;.&lt;font color=&quot;#660e7a&quot;&gt;rpcRegistry&lt;/font&gt;, afiSafisAdvertized, Collections.emptySet());&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;Where this.neighorAddress is defined as following&lt;/p&gt;

&lt;p&gt;&lt;font color=&quot;#000080&quot;&gt;private final &lt;/font&gt;IpAddress &lt;font color=&quot;#660e7a&quot;&gt;neighborAddress&lt;/font&gt;;&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;which is equal to how it is represented in model.&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;Therefore its not possible right now to create V6 peer, because if v6 address is provided as neghbors address, it will fail at v4 regex that will be used by&lt;/p&gt;

&lt;p&gt;&lt;font color=&quot;#000080&quot;&gt;new &lt;/font&gt;IpAddress(&lt;font color=&quot;#000080&quot;&gt;new &lt;/font&gt;Ipv4Address(name)&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;This problem was introduced by patch &lt;a href=&quot;https://git.opendaylight.org/gerrit/#/c/49933/12/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPPeer.java&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/#/c/49933/12/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPPeer.java&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Affects nitrogen and carbon.SR2 also&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;</description>
                <environment></environment>
        <key id="28952">BGPCEP-732</key>
            <summary>BGP Peer name forced to be Ipv4</summary>
                <type id="10104" iconUrl="https://jira.opendaylight.org/secure/viewavatar?size=xsmall&amp;avatarId=10303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="2" iconUrl="https://jira.opendaylight.org/images/icons/priorities/critical.svg">High</priority>
                        <status id="10004" iconUrl="https://jira.opendaylight.org/images/icons/status_generic.gif" description="">Verified</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="cdgasparini">Claudio David Gasparini</assignee>
                                    <reporter username="jsrnicek">J&#225;n Srni&#269;ek</reporter>
                        <labels>
                    </labels>
                <created>Thu, 7 Dec 2017 09:10:13 +0000</created>
                <updated>Wed, 18 Apr 2018 07:59:14 +0000</updated>
                            <resolved>Tue, 27 Mar 2018 06:41:50 +0000</resolved>
                                    <version>Oxygen</version>
                                                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="60360" author="cdgasparini" created="Thu, 7 Dec 2017 13:09:14 +0000"  >&lt;p&gt;When passing the bgp identifier, is defined as Ipv4 by definition, which is wrong since its an IpAddress, allowing to be Ipv4/Ipv6.&lt;/p&gt;</comment>
                            <comment id="60361" author="cdgasparini" created="Thu, 7 Dec 2017 13:12:14 +0000"  >&lt;p&gt;&lt;a href=&quot;https://git.opendaylight.org/gerrit/#/q/topic:BGPCEP-732&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/#/q/topic:BGPCEP-732&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="60411" author="jsrnicek" created="Tue, 12 Dec 2017 07:26:53 +0000"  >&lt;p&gt;Should be also cherry picked for nitrogen.SR1 and carbon.SR2&lt;/p&gt;</comment>
                            <comment id="60420" author="cdgasparini" created="Tue, 12 Dec 2017 09:24:53 +0000"  >&lt;p&gt;If I recall well, we agreed that you will test it and confirm the fix. I don&apos;t see anywhere that confirmation.&lt;/p&gt;

&lt;p&gt;Also you mention the cherry-pick but I don&apos;t see that you have done it. Once you do it, attach me as reviewer, and&#160; I&apos;ll review and merge them.&lt;/p&gt;

&lt;p&gt;But first confirm the fix is correct.&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;Regards&lt;/p&gt;</comment>
                            <comment id="60426" author="jsrnicek" created="Tue, 12 Dec 2017 09:35:31 +0000"  >&lt;p&gt;I cannot confirm it works for my usecase unless its cherry picked to either carbon or nitrogen. And i dont have rights do so in ODL gerrit&lt;/p&gt;</comment>
                            <comment id="60429" author="jsrnicek" created="Tue, 12 Dec 2017 09:37:44 +0000"  >&lt;p&gt;Sorry ,my mistake ,i can see cherry pick&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_11400" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i038rj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>