[BGPCEP-898] bgp-topology-provider bundle faills to start

Fri, 6 Nov 2020 03:07:49 +0000

A regression in Magnesium CSIT was noticed recently. Examples:

Oddly, however, the 3rd job listed above did have a new run that passed, and not sure how
to explain that yet.

Looking at some karaf logs from the failures, I notice some trouble around:

org.opendaylight.bgpcep.bgp-topology-provider/0.13.0.SNAPSHOT

full exception taken from this karaf.log :

2020-03-09T18:06:19,578 | INFO  | Blueprint Extender: 2 | BgpTopologyDeployerImpl          | 241 - org.opendaylight.bgpcep.bgp-topology-provider - 0.13.0 | BGP topology deployer started.
2020-03-09T18:06:19,635 | WARN  | Blueprint Extender: 2 | BeanRecipe                       | 84 - org.apache.aries.blueprint.core - 1.10.2 | Object to be destroyed is not an instance of UnwrapperedBeanHolder, type: null
2020-03-09T18:06:19,639 | INFO  | Blueprint Extender: 2 | BgpTopologyDeployerImpl          | 241 - org.opendaylight.bgpcep.bgp-topology-provider - 0.13.0 | BGP topology deployer stopped.
2020-03-09T18:06:19,640 | ERROR | Blueprint Extender: 2 | BlueprintContainerImpl           | 84 - org.apache.aries.blueprint.core - 1.10.2 | Unable to start container for blueprint bundle org.opendaylight.bgpcep.bgp-topology-provider/0.13.0
org.osgi.service.blueprint.container.ComponentDefinitionException: Error when instantiating bean linkstateGraphProvider of class org.opendaylight.bgpcep.bgp.topology.provider.config.LinkstateGraphProvider
	at org.apache.aries.blueprint.container.BeanRecipe.wrapAsCompDefEx(BeanRecipe.java:362) ~[84:org.apache.aries.blueprint.core:1.10.2]
	at org.apache.aries.blueprint.container.BeanRecipe.getInstanceFromType(BeanRecipe.java:352) ~[84:org.apache.aries.blueprint.core:1.10.2]
	at org.apache.aries.blueprint.container.BeanRecipe.getInstance(BeanRecipe.java:283) ~[84:org.apache.aries.blueprint.core:1.10.2]
	at org.apache.aries.blueprint.container.BeanRecipe.internalCreate2(BeanRecipe.java:685) ~[84:org.apache.aries.blueprint.core:1.10.2]
	at org.apache.aries.blueprint.container.BeanRecipe.internalCreate(BeanRecipe.java:666) ~[84:org.apache.aries.blueprint.core:1.10.2]
	at org.apache.aries.blueprint.di.AbstractRecipe$1.call(AbstractRecipe.java:81) ~[84:org.apache.aries.blueprint.core:1.10.2]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
	at org.apache.aries.blueprint.di.AbstractRecipe.create(AbstractRecipe.java:90) ~[84:org.apache.aries.blueprint.core:1.10.2]
	at org.apache.aries.blueprint.container.BlueprintRepository.createInstances(BlueprintRepository.java:360) ~[84:org.apache.aries.blueprint.core:1.10.2]
	at org.apache.aries.blueprint.container.BlueprintRepository.createAll(BlueprintRepository.java:190) ~[84:org.apache.aries.blueprint.core:1.10.2]
	at org.apache.aries.blueprint.container.BlueprintContainerImpl.instantiateEagerComponents(BlueprintContainerImpl.java:737) ~[84:org.apache.aries.blueprint.core:1.10.2]
	at org.apache.aries.blueprint.container.BlueprintContainerImpl.doRun(BlueprintContainerImpl.java:433) [84:org.apache.aries.blueprint.core:1.10.2]
	at org.apache.aries.blueprint.container.BlueprintContainerImpl.run(BlueprintContainerImpl.java:298) [84:org.apache.aries.blueprint.core:1.10.2]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
	at org.apache.aries.blueprint.container.ExecutorServiceWrapper.run(ExecutorServiceWrapper.java:106) [84:org.apache.aries.blueprint.core:1.10.2]
	at org.apache.aries.blueprint.utils.threading.impl.DiscardableRunnable.run(DiscardableRunnable.java:45) [84:org.apache.aries.blueprint.core:1.10.2]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
	at java.lang.Thread.run(Thread.java:834) [?:?]
Caused by: java.lang.NullPointerException
	at java.util.Objects.requireNonNull(Objects.java:221) ~[?:?]
	at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateGraphBuilder.<init>(LinkstateGraphBuilder.java:123) ~[?:?]
	at org.opendaylight.bgpcep.bgp.topology.provider.config.LinkstateGraphProvider.createTopologyBuilder(LinkstateGraphProvider.java:32) ~[?:?]
	at org.opendaylight.bgpcep.bgp.topology.provider.config.AbstractBgpTopologyProvider.createInstance(AbstractBgpTopologyProvider.java:77) ~[?:?]
	at org.opendaylight.bgpcep.bgp.topology.provider.config.AbstractBgpTopologyProvider.onTopologyBuilderCreated(AbstractBgpTopologyProvider.java:52) ~[?:?]
	at org.opendaylight.bgpcep.bgp.topology.provider.config.BgpTopologyDeployerImpl.lambda$registerTopologyProvider$4(BgpTopologyDeployerImpl.java:113) ~[?:?]
	at java.util.ArrayList.forEach(ArrayList.java:1540) ~[?:?]
	at org.opendaylight.bgpcep.bgp.topology.provider.config.BgpTopologyDeployerImpl.registerTopologyProvider(BgpTopologyDeployerImpl.java:113) ~[?:?]
	at org.opendaylight.bgpcep.bgp.topology.provider.config.AbstractBgpTopologyProvider.<init>(AbstractBgpTopologyProvider.java:44) ~[?:?]
	at org.opendaylight.bgpcep.bgp.topology.provider.config.LinkstateGraphProvider.<init>(LinkstateGraphProvider.java:25) ~[?:?]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:?]
	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:490) ~[?:?]
	at org.apache.aries.blueprint.utils.ReflectionUtils.newInstance(ReflectionUtils.java:369) ~[?:?]
	at org.apache.aries.blueprint.container.BeanRecipe.newInstance(BeanRecipe.java:839) ~[?:?]
	at org.apache.aries.blueprint.container.BeanRecipe.getInstanceFromType(BeanRecipe.java:350) ~[?:?]
	... 21 more

There were two bgpcep patches [ 1 ][ 2 ] that were merged in the relevant time frame. I took
the distribution created from both and was able to locally produce the same bundle starting
issue with [1], but not [2]. I notice that [1] actually came as a cherry-pick from master and
the master gerrit did run 100% passing gate CSIT. I've tried to trigger CSIT from [1] directly
and when it's done, the logs will appear as comments there.

The trace in karaf.log is in the bgpTopology* area which also points to [1]. [2] is a lot of
docs changes with some changes in algo-impl/

udpates to follow as they come

OpenDaylight JIRA

[BGPCEP-898] bgp-topology-provider bundle faills to start