https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/BGPCEP-904 bgpcep <p>ConnectedGraphServer is populating both Operational and Configuration datastores in a single transaction.</p> <p>This leads to sub-optimal performance and is deprecated funcitonality, which is going away in the next release.</p> <p> </p> BGPCEP-904

Graph-impl is performing cross-datastore transactions

Bug High Resolved Done Olivier Dugeon Robert Varga Thu, 23 Apr 2020 09:30:51 +0000 Mon, 3 Aug 2020 11:23:51 +0000 Mon, 3 Aug 2020 11:23:51 +0000 Aluminium General 0 2 <p>Good catch. Indeed, ConnectedGraphServer initializes both Operational and Configuration datastore. Initialize Configuration is wrongly placed. I'll split initialization in two separate transactions.</p> <p>I wonder, what is the intent in actually writing to CONFIG here? I mean that's persisted by default, so should it really be initialized each startup...</p> <p>Graph in Config Datastore is here to give the possibility to manually provide a topology or complete an automatic topology discovery (e.g. through BGP-LS). But Path Algorithms are working on the connected graph which is computed from the Operational Graph. So, GraphListener is here to listen to Graph Configuration and populate Graph Operational like LinkstateGraphBuilder done with Linkstate Routes.</p> <p>If Graph Configuration is not initialized, I'm afraid that GraphListener could not start correctly. I'm thinking to initialize Graph Configuration in GraphListener class, but, this is more complex as simply split the Graph initialization in two separate transactions.</p> <p>Now, regarding persistence, I could add some trigger to initialize the Graph Configuration only if it's not exist if it makes sense.</p> <p>Why would the GraphListener not start? I mean it should be just fine with no config being present, right?</p> <p>Also, the init actually actively overwrite config datastore – so even if there was something there, you'll end up wiping it on start – that does not feel like config at all. As for the BGP-LS discovery, etc. that certainly should not go through config – it very much feels liek you really want to have multiple instances in oper and each instance having a semantic meaning. The user-supplied configuration (which would be persisted) would live in config, but code components would never actively write to it and instead move it to oper – this is very much what BGP already does anyway ...</p> <blockquote><p>Why would the GraphListener not start? I mean it should be just fine with no config being present, right?</p></blockquote> <p>I try to launch the Graph without the creation of initial GraphModel top node in config datastore, but in this case, you are unable to add some graph in config. I need at least to create the graph-model top node in the config datastore. Now, I agree that it is certainly the role of GraphListnener to do that instead of ConnectedGraphServer.</p> <blockquote><p>Also, the init actually actively overwrite config datastore – so even if there was something there, you'll end up wiping it on start – that does not feel like config at all.</p></blockquote> <p>I just would create the graph-model top node in the config datastore like I do for the operational datastore. Perhaps we could do this differently with some xml file. But well, It is just the top node with no graph inside. Just let me know what it is the better design.</p> <blockquote><p>As for the BGP-LS discovery, etc. that certainly should not go through config – it very much feels liek you really want to have multiple instances in oper and each instance having a semantic meaning. The user-supplied configuration (which would be persisted) would live in config, but code components would never actively write to it and instead move it to oper – this is very much what BGP already does anyway ...</p></blockquote> <p>As mention, Graph model in configuration is just here to give the possibility to provide a graph with the REST API instead of through BGP-LS. This allows an operator to provide a network topology that it collect through another tools which not speaks BGP-LS. This could be also helpful to provide static topology or complement a topology acquired through BGP-LS. In all cases, the active topology on which Path Computation Algorithms oper is the Connected Graph Model issue from the Graph Model in operational datastore.</p> <p>Just let me know where is the best place to create the graph-model top node for the Configuration datastore</p> <p>So, I finally simply drop initialization of GraphModel in Configuration datastore</p> Development Rank 0|i03s1z: