https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-1 controller <p>If somewhere in the full path for the location where you are trying to run your controller, you have a path segment with a space, for example:</p> <p>/tmp/Development Stuff/distribution.opendaylight-0.1.0-SNAPSHOT-osgipackage/opendaylight</p> <p>(note the " " in "Development Stuff" above)</p> <p>When you try to execute run.sh, it will fail with the message:</p> <p>usage: dirname path<br/> Exception in thread "main" java.lang.NoClassDefFoundError: org/eclipse/equinox/launcher/Main<br/> Caused by: java.lang.ClassNotFoundException: org.eclipse.equinox.launcher.Main<br/> at java.net.URLClassLoader$1.run(URLClassLoader.java:202)<br/> at java.security.AccessController.doPrivileged(Native Method)<br/> at java.net.URLClassLoader.findClass(URLClassLoader.java:190)<br/> at java.lang.ClassLoader.loadClass(ClassLoader.java:306)<br/> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)<br/> at java.lang.ClassLoader.loadClass(ClassLoader.java:247)</p> <p>This failure is occurring due to mishandling of the space in "Development Stuff"</p> <p>Still working on fixing... but wanted folks to know ASAP that the workaround is<br/> to simply do something like</p> <p>mv /tmp/Development\ Stuff/ /tmp/DevelopmentStuff</p> <p>in other words, kill the space in the path segment.</p> <p>Operating System: Mac OS<br/> Platform: PC</p> CONTROLLER-1

run.sh does not correctly handle pathnames containing " " characters

Bug Resolved Done Venkata Siva Vijayendra Bhamidipati Ed Warnicke Sat, 23 Mar 2013 16:33:52 +0000 Thu, 19 Oct 2017 16:36:45 +0000 Tue, 5 May 2015 15:17:12 +0000 0.4.0 adsal 0 3 <p>I see that this issue still exists on the controller trunk, and this looked like a relatively easy starter bug (Today is my first day working with opendaylight), so am assigning this to myself.</p> <p>I've patched run.sh to get over the spaces issue, and with that, the NoClassDefFoundError goes away, but I'm still running into an issue with the way the URIParser.parse() routine is being called - looks like it cannot parse file URIs when spaces exist in the path:</p> <p>BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US<br/> Command-line arguments: -console -consoleLog</p> <p>!ENTRY org.eclipse.osgi 4 0 2013-12-20 09:26:14.716<br/> !MESSAGE Bundle reference:<a href="file:../lib/logging.bridge-0.4.1-SNAPSHOT@1:start" class="external-link" target="_blank" rel="nofollow noopener">file:../lib/logging.bridge-0.4.1-SNAPSHOT@1:start</a> not found.<br/> gogo: URISyntaxException: Illegal character in opaque part at index 29: jar:<a href="file:/home/cloud/work/new" class="external-link" target="_blank" rel="nofollow noopener">file:/home/cloud/work/new</a> nd/controller/opendaylight/distribution/opendaylight/target/distribution.opendaylight-osgipackage/opendaylight/configuration/org.eclipse.osgi/bundles/184/1/bundlefile!/gosh_profile<br/> java.net.URISyntaxException: Illegal character in opaque part at index 29: jar:<a href="file:/home/cloud/work/new" class="external-link" target="_blank" rel="nofollow noopener">file:/home/cloud/work/new</a> nd/controller/opendaylight/distribution/opendaylight/target/distribution.opendaylight-osgipackage/opendaylight/configuration/org.eclipse.osgi/bundles/184/1/bundlefile!/gosh_profile<br/> at java.net.URI$Parser.fail(URI.java:2829)<br/> at java.net.URI$Parser.checkChars(URI.java:3002)<br/> at java.net.URI$Parser.parse(URI.java:3039)<br/> at java.net.URI.&lt;init&gt;(URI.java:595)<br/> at java.net.URL.toURI(URL.java:938)<br/> at org.apache.felix.gogo.shell.Shell.gosh(Shell.java:105)<br/> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)<br/> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)<br/> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)<br/> at java.lang.reflect.Method.invoke(Method.java:606)<br/> at org.apache.felix.gogo.runtime.Reflective.method(Reflective.java:136)<br/> at org.apache.felix.gogo.runtime.CommandProxy.execute(CommandProxy.java:82)<br/> at org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:469)<br/> at org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:395)<br/> at org.apache.felix.gogo.runtime.Pipe.run(Pipe.java:108)<br/> at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:183)<br/> at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:120)<br/> at org.apache.felix.gogo.runtime.CommandSessionImpl.execute(CommandSessionImpl.java:89)<br/> at org.apache.felix.gogo.shell.Activator.run(Activator.java:75)<br/> at java.lang.Thread.run(Thread.java:744)<br/> I'm not using eclipse - I'm running the controller from CLI (ubuntu 12.04). </p> <p>There are more stack traces at different points in the code that are invoked by different libraries - for example, the above is invoked by the "gogo" package, it repeats later with another trace:</p> <p>2013-12-20 09:29:37 PST <span class="error">&#91;org.apache.catalina.startup.ContextConfig&#93;</span> SEVERE org.apache.catalina.startup.ContextConfig getWebXmlSource Error processed default web.xml named conf/web.xml at /home/cloud/work/new nd/controller/opendaylight/distribution/opendaylight/target/distribution.opendaylight-osgipackage/opendaylight/conf/web.xml<br/> java.net.URISyntaxException: Illegal character in opaque part at index 29: jar:<a href="file:/home/cloud/work/new" class="external-link" target="_blank" rel="nofollow noopener">file:/home/cloud/work/new</a> nd/controller/opendaylight/distribution/opendaylight/target/distribution.opendaylight-osgipackage/opendaylight/configuration/org.eclipse.osgi/bundles/245/1/bundlefile!/conf/web.xml<br/> at java.net.URI$Parser.fail(URI.java:2829)<br/> at java.net.URI$Parser.checkChars(URI.java:3002)<br/> at java.net.URI$Parser.parse(URI.java:3039)<br/> at java.net.URI.&lt;init&gt;(URI.java:595)<br/> at java.net.URL.toURI(URL.java:938)<br/> at org.apache.catalina.startup.ContextConfig.getWebXmlSource(ContextConfig.java:1828)<br/> at org.apache.catalina.startup.ContextConfig.getGlobalWebXmlSource(ContextConfig.java:1741)<br/> at org.apache.catalina.startup.ContextConfig.getDefaultWebXmlFragment(ContextConfig.java:1414)<br/> at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1250)<br/> at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:878)<br/> at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:369)<br/> at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119)<br/> at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90)<br/> at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5173)<br/> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)</p> <p>.<br/> .<br/> .<br/> at org.eclipse.osgi.framework.internal.core.BundleContextImpl.registerService(BundleContextImpl.java:950)<br/> at org.eclipse.gemini.web.tomcat.internal.Activator.start(Activator.java:61)<br/> at org.eclipse.osgi.framework.internal.core.BundleContextImpl$1.run(BundleContextImpl.java:711)<br/> at java.security.AccessController.doPrivileged(Native Method)<br/> at org.eclipse.osgi.framework.internal.core.BundleContextImpl.startActivator(BundleContextImpl.java:702)<br/> at org.eclipse.osgi.framework.internal.core.BundleContextImpl.start(BundleContextImpl.java:683)<br/> at org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:381)<br/> at org.eclipse.osgi.framework.internal.core.AbstractBundle.start(AbstractBundle.java:300)<br/> at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:1175)<br/> at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:1153)<br/> at org.apache.felix.fileinstall.internal.DirectoryWatcher.processAllBundles(DirectoryWatcher.java:1146)<br/> at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:456)<br/> at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:263)</p> <p>Is this OSGI related? Is it possible that the OSGI package being used is outdated and later versions do the parsing correctly (either encode spaces to %20 or call another routine)? Any idea what this glue component/jar is and how I can update its version? I do see in the run.sh file itself, CLASSPATH and FWCLASSPATH variables being initialized to eclipse jar files, but I have little idea of how OSGI works or how the jar components are updated.</p> <p>Thanks!<br/> Regards,<br/> Vijay</p> <p>You are completely <b>awesome</b> for picking this up <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>In a URI, you must substitute %20 for " " a space character.</p> <p>And example of how to do this kind of substitution from the shell would be:</p> <p>echo "This is a string" | sed 's/ /%20/g'</p> <p>And thank you <b>so</b> much for picking this up <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Thanks Ed! <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/> I actually did try out the %20 in the sed 's/ /<br class="atl-forced-newline" /> /g' portions of the script along with putting everything in double quotes, but the problem there is that then the run.sh script passes off those paths as /home/dir1/xy%20z/blah/ to jdk, and then again java fails to locate those paths and runs into the original class not found error.. so I wasn't able to work around it that way..</p> <p>The %20 encoding should be done somewhere in the java layers, but looking at the stack traces, it doesn't look like we can do that in the controller code. Ideally, the call to java.net.URL.toURI(URL.java:938) that is being made, should be encoding those spaces, or handling it differently. So that's where I'm kind of stuck, since I don't know if those OSGI/gogo modules were actually patched later on to fix this, and if so, how we can upgrade those dependencies in the controller packaging.</p> <p>The fix has been merged to master - however, the osgi bundles will still need to be updated. I'm marking this bug as fixed for now with this caveat.</p> <p>This bug is part of the project to Move all ADSAL associated component bugs to ADSAL.</p> Development External issue ID 3 External issue URL Rank 0|i02hpb: