OpenDaylight JIRA

OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us

8.20.10

820010

22-06-2022

[CONTROLLER-1191] Restconf PUT to top-level node fails https://jira.opendaylight.org/browse/CONTROLLER-1191 controller Operating System: All Platform: All CONTROLLER-1191

Restconf PUT to top-level node fails

Bug Resolved Done Tony Tkacik Tom Pantelis Tue, 10 Mar 2015 06:54:45 +0000 Tue, 25 Jul 2023 08:23:56 +0000 Mon, 16 Mar 2015 12:24:04 +0000 mdsal 0 2 If you do a PUT to a top-level node, an exception is thrown: aylight.controller.sal-rest-connector - 1.2.0.SNAPSHOT | | Error parsing json input java.util.NoSuchElementException at com.google.common.collect.AbstractIndexedListIterator.next(AbstractIndexedListIterator.java:82)[114:com.google.guava:18.0.0] at org.opendaylight.yangtools.yang.model.util.SchemaContextUtil.findNodeInSchemaContext(SchemaContextUtil.java:229)[141:org.opendaylight.yangtools.yang-model-util:0.7.0.SNAPSHOT] at org.opendaylight.yangtools.yang.model.util.SchemaContextUtil.findDataSchemaNode(SchemaContextUtil.java:87)[141:org.opendaylight.yangtools.yang-model-util:0.7.0.SNAPSHOT] at org.opendaylight.controller.sal.rest.impl.JsonNormalizedNodeBodyReader.readFrom(JsonNormalizedNodeBodyReader.java:64)[256:org.opendaylight.controller.sal-rest-connector:1.2.0.SNAPSHOT] at org.opendaylight.controller.sal.rest.impl.JsonNormalizedNodeBodyReader.readFrom(JsonNormalizedNodeBodyReader.java:41)[256:org.opendaylight.controller.sal-rest-connector:1.2.0.SNAPSHOT] This is easily reproducible with the toaster, eg: <a href="http://localhost:8181/restconf/config/toaster:toaster" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/config/toaster:toaster</a> { toaster: { darknessFactor: "2000" } } Also the CDS 3-node integration tests that use the car/people models are broken as well. Also doing POST to <a href="http://localhost:8181/restconf/config/" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/config/</a>, gets a different exception: java.lang.NullPointerException at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:210)[114:com.google.guava:18.0.0] at com.google.common.base.Splitter.split(Splitter.java:386)[114:com.google.guava:18.0.0] at org.opendaylight.controller.sal.restconf.impl.ControllerContext.toIdentifier(ControllerContext.java:138)[256:org.opendaylight.controller.sal-rest-connector:1.2.0.SNAPSHOT] at org.opendaylight.controller.sal.restconf.impl.ControllerContext.toInstanceIdentifier(ControllerContext.java:124)[256:org.opendaylight.controller.sal-rest-connector:1.2.0.SNAPSHOT] at org.opendaylight.controller.sal.rest.impl.AbstractIdentifierAwareJaxRsProvider.getInstanceIdentifierContext(AbstractIdentifierAwareJaxRsProvider.java:24)[256:org.opendaylight.controller.sal-rest-connector:1.2.0.SNAPSHOT] at org.opendaylight.controller.sal.rest.impl.AbstractIdentifierAwareJaxRsProvider.getIdentifierWithSchema(AbstractIdentifierAwareJaxRsProvider.java:20)[256:org.opendaylight.controller.sal-rest-connector:1.2.0.SNAPSHOT] at org.opendaylight.controller.sal.rest.impl.JsonNormalizedNodeBodyReader.readFrom(JsonNormalizedNodeBodyReader.java:60)[256:org.opendaylight.controller.sal-rest-connector:1.2.0.SNAPSHOT] at org.opendaylight.controller.sal.rest.impl.JsonNormalizedNodeBodyReader.readFrom(JsonNormalizedNodeBodyReader.java:41)[256:org.opendaylight.controller.sal-rest-connector:1.2.0.SNAPSHOT] This is because the identifier portion of the URL was not specified. This is supposed to be allowed for POST (it used to work anyway). Perhaps this should be a separate bug... It looks like this may have been broken by <a href="https://git.opendaylight.org/gerrit/#/c/16209/2" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/16209/2</a>. Yeah, in patch you mentioned is bug, which provides JSON failure for top-level element, but without that patch JSON did not work at all. ok - so there's progress - that's good <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/> (In reply to Tony Tkacik from comment #4) > Yeah, in patch you mentioned is bug, which provides JSON failure for > top-level element, > but without that patch JSON did not work at all. <a href="https://git.opendaylight.org/gerrit/#/c/16136/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/16136/</a> This fixes PUT for JSON inputs and also POST for JSON/XML for creation of data and RPCs. Development External issue ID 2805 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i02p1r: