https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-1241 controller <p>When we query:</p> <p>GET, accept: application/json<br/> /restconf/config/opendaylight-inventory:nodes/node/controller-config/yang-ext:mount/config:modules/</p> <p>we get a 500 error.</p> <p>If we change the type to be application/xml it works.</p> <p>Stack:</p> <p>/restconf/config/opendaylight-inventory:nodes/node/controller-config/yang-ext:mount/config:modules/. Reason:<br/> &lt;pre&gt; Server Error&lt;/pre&gt;&lt;/p&gt;&lt;h3&gt;Caused by:&lt;/h3&gt;&lt;pre&gt;java.lang.ClassCastException: java.lang.String cannot be cast to org.opendaylight.yangtools.yang.common.QName<br/> at org.opendaylight.yangtools.yang.data.codec.gson.JSONStringIdentityrefCodec.serializeToWriter(JSONStringIdentityrefCodec.java:19)<br/> at org.opendaylight.yangtools.yang.data.codec.gson.JSONNormalizedNodeStreamWriter.writeValue(JSONNormalizedNodeStreamWriter.java:291)<br/> at org.opendaylight.yangtools.yang.data.codec.gson.JSONNormalizedNodeStreamWriter.leafNode(JSONNormalizedNodeStreamWriter.java:193)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessAsSimpleNode(NormalizedNodeWriter.java:148)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:104)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:194)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:100)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:207)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:100)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter$OrderedNormalizedNodeWriter.writeMapEntryNode(NormalizedNodeWriter.java:267)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:197)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:100)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:227)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:100)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:194)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:100)<br/> at org.opendaylight.controller.sal.rest.impl.NormalizedNodeJsonBodyWriter.writeNormalizedNode(NormalizedNodeJsonBodyWriter.java:108)<br/> at org.opendaylight.controller.sal.rest.impl.NormalizedNodeJsonBodyWriter.writeTo(NormalizedNodeJsonBodyWriter.java:75)<br/> at org.opendaylight.controller.sal.rest.impl.NormalizedNodeJsonBodyWriter.writeTo(NormalizedNodeJsonBodyWriter.java:45)<br/> at com.sun.jersey.spi.container.ContainerResponse.write(ContainerResponse.java:306)<br/> at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1479)<br/> at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1391)<br/> at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1381)<br/> at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416)<br/> at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:538)<br/> at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:716)<br/> at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)<br/> at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)<br/> at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1496)<br/> at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:247)<br/> at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:210)<br/> at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467)<br/> at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499)<br/> at org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:69)<br/> at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)<br/> at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)<br/> at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)<br/> at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)<br/> at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:240)<br/> at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:428)<br/> at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)<br/> at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)<br/> at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)<br/> at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:77)<br/> at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)<br/> at org.eclipse.jetty.server.Server.handle(Server.java:370)<br/> at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)<br/> at org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:971)<br/> at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1033)<br/> at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:644)<br/> at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)<br/> at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)<br/> at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:667)<br/> at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:52)<br/> at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)<br/> at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)<br/> at java.lang.Thread.run(Thread.java:745)</p> <p>Operating System: Linux<br/> Platform: Other</p> CONTROLLER-1241

ClassCastException when querying - controller-config/yang-ext:mount/config:modules

Bug Resolved Done Jan Hajnar Devin Avery Wed, 8 Apr 2015 21:01:23 +0000 Fri, 10 Apr 2015 09:43:59 +0000 Fri, 10 Apr 2015 09:43:59 +0000 Post-Helium restconf 0 4 <p>It chokes here in JSONNormalizedNodeStreamWriter:</p> <p> private void writeValue(Object value, JSONCodec&lt;Object&gt; codec)<br/> throws IOException </p> { codec.serializeToWriter(writer,value); } <p>The codec class is JSONStringIdentityrefCodec whose serializeToWriter method has this signature:</p> <p> public void serializeToWriter(JsonWriter writer, QName value)</p> <p>But the value contained in the leaf node is of type String: "prefix:binding-broker-osgi-registry". I'm not sure if the wrong codec class was chosen earlier or if the value should've been converted to a QName (I suspect the latter).</p> <p>In my case the data it's trying to serialize corresponds to this xml snippet in 99-netconf-connector.xml:</p> <p> &lt;binding-registry&gt;<br/> &lt;type xmlns:prefix="urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding"&gt;prefix:binding-broker-osgi-registry&lt;/type&gt;<br/> &lt;name&gt;binding-osgi-broker&lt;/name&gt;<br/> &lt;/binding-registry&gt;</p> <p>This seems to be bug in XML codecs and/or Netconf which<br/> did not correctly translated identityref (seems prefix: and namespace was not honored, or leaf was processed as a string) and provided incorrect<br/> deserialization of identityref, which resulted in class-cast once JSON writer<br/> tried to interpret it according to schema.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/17991/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/17991/</a></p> <p>I pulled in the patch but now I'm seeing a different exception:</p> <p>Problem accessing /restconf/config/opendaylight-inventory:nodes/node/controller-config/yang-ext:mount/config:modules. Reason:<br/> &lt;pre&gt; Server Error&lt;/pre&gt;&lt;/p&gt;&lt;h3&gt;Caused by:&lt;/h3&gt;&lt;pre&gt;java.lang.IllegalStateException: Dangling name: type<br/> at com.google.gson.stream.JsonWriter.close(JsonWriter.java:342)<br/> at com.google.gson.stream.JsonWriter.endObject(JsonWriter.java:317)<br/> at org.opendaylight.yangtools.yang.data.codec.gson.JSONStreamWriterObjectContext.emitEnd(JSONStreamWriterObjectContext.java:33)<br/> at org.opendaylight.yangtools.yang.data.codec.gson.JSONStreamWriterContext.endNode(JSONStreamWriterContext.java:153)<br/> at org.opendaylight.yangtools.yang.data.codec.gson.JSONNormalizedNodeStreamWriter.endNode(JSONNormalizedNodeStreamWriter.java:282)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:172)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:194)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:100)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:207)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:100)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter$OrderedNormalizedNodeWriter.writeMapEntryNode(NormalizedNodeWriter.java:267)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:197)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:100)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:227)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:100)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.writeChildren(NormalizedNodeWriter.java:169)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.wasProcessedAsCompositeNode(NormalizedNodeWriter.java:194)<br/> at org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeWriter.write(NormalizedNodeWriter.java:100)<br/> at org.opendaylight.controller.sal.rest.impl.NormalizedNodeJsonBodyWriter.writeNormalizedNode(NormalizedNodeJsonBodyWriter.java:108)<br/> at org.opendaylight.controller.sal.rest.impl.NormalizedNodeJsonBodyWriter.writeTo(NormalizedNodeJsonBodyWriter.java:75)<br/> at org.opendaylight.controller.sal.rest.impl.NormalizedNodeJsonBodyWriter.writeTo(NormalizedNodeJsonBodyWriter.java:45)</p> <p>In this method in JSONNormalizedNodeStreamWriter, the NULL_CODEC is returned from codeFor:</p> <p> public void leafNode(final NodeIdentifier name, final Object value) throws IOException </p> { final LeafSchemaNode schema = tracker.leafNode(name); final JSONCodec&lt;Object&gt; codec = codecs.codecFor(schema); &lt;------- context.emittingChild(codecs.getSchemaContext(), writer); context.writeChildJsonIdentifier(codecs.getSchemaContext(), writer, name.getNodeType()); writeValue(value, codec); } <p>In JSONCodefFactory#createFromSimpleType:</p> <p>LOG.debug("Codec for type \"{}\" is not implemented yet.", type.getQName()<br/> .getLocalName());</p> <p>It appears no codec has been implemented for IdentityrefType.</p> <p>Actually it seems the problem is it isn't picking up the JSONStringIdentityrefCodec now - it did before.</p> <p>Original patch <a href="https://git.opendaylight.org/gerrit/#/c/17991/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/17991/</a><br/> fixed bug in XML codec for identities which resulted in this stacktrace.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/17912/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/17912/</a> patch introduced regression which<br/> broke JSON codec for identities (similar behaviour in restconf).</p> <p>Patch <a href="https://git.opendaylight.org/gerrit/#/c/18030/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/18030/1</a><br/> fixes regression caused by <a href="https://git.opendaylight.org/gerrit/#/c/17912/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/17912/</a></p> <p>Verified fixes - thanks for turning this around quickly.</p> Development External issue ID 2964 External issue URL Issue Type ODL SR Target Milestone Rank 0|i02pcv: