https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-14 controller <p>Currently EqualsBuilder</p> <p><a href="http://commons.apache.org/proper/commons-lang///javadocs/api-2.6/org/apache/commons/lang/builder/EqualsBuilder.html" class="external-link" target="_blank" rel="nofollow noopener">http://commons.apache.org/proper/commons-lang///javadocs/api-2.6/org/apache/commons/lang/builder/EqualsBuilder.html</a></p> <p>and HashCodeBuilder</p> <p><a href="http://commons.apache.org/proper/commons-lang///javadocs/api-2.6/org/apache/commons/lang/builder/HashCodeBuilder.html" class="external-link" target="_blank" rel="nofollow noopener">http://commons.apache.org/proper/commons-lang///javadocs/api-2.6/org/apache/commons/lang/builder/HashCodeBuilder.html</a></p> <p>are being used in many places within the code. These should be replaced for performance reasons. </p> <p>Eclipse provides a facility to autogenerate replacements and its use should be explored.</p> <p>Operating System: All<br/> Platform: All</p> CONTROLLER-14

Replace EqualsBuilder and HashBuilder for performance

Improvement Resolved Done Unassigned Ed Warnicke Wed, 15 May 2013 00:25:28 +0000 Thu, 19 Oct 2017 22:13:17 +0000 Tue, 5 May 2015 15:17:19 +0000 0.4.0 adsal 0 3 <p>EqualsBuilder uses the standard Bloch algorithm for equals:</p> <p><a href="http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java?view=markup" class="external-link" target="_blank" rel="nofollow noopener">http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java?view=markup</a></p> <p>and Eclipse appears to do likewise with its generated code.</p> <p>HashCodeBuilder's algorithm is described here:<br/> <a href="http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java?view=markup" class="external-link" target="_blank" rel="nofollow noopener">http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java?view=markup</a></p> <p>and also appears to match what Eclipse is generating.</p> <p>First initial pass at a fix (for one file only) in:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/342/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/342/</a></p> <p>Fixed a bunch more, in small chunks for easy review:</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/349/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/349/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/350/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/350/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/351/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/351/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/352/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/352/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/353/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/353/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/354/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/354/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/355/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/355/</a></p> <p>This bug is part of the project to Move all ADSAL associated component bugs to ADSAL.</p> Development External issue ID 20 External issue URL Rank 0|i02hs7: