https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-1438 controller <p>In Lithium we have noticed that the config subsystem fails silently if a config file fails to be parsed, or if it fails to find services. Their is an uncaught exception that is ultimately printed to standard out, which should in theory be showing up in karaf.out (which is not where people look by default).</p> <p>It would be nice if the config sub system can log 1) when it successfully parses a config file and 2) if there are any thrown exceptions reporting an error, log those to the karaf.log at a WARN or ERROR log (or even FATAL since it stops the controller dead in the water).</p> <p>Operating System: All<br/> Platform: All</p> CONTROLLER-1438

Config subsystem fails silently by default

Bug Verified Done Tom Pantelis Devin Avery Fri, 30 Oct 2015 12:40:44 +0000 Mon, 16 Nov 2015 16:14:28 +0000 Mon, 16 Nov 2015 16:14:28 +0000 Lithium config 0 3 <p><a href="https://git.opendaylight.org/gerrit/#/c/28985/3" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/28985/3</a></p> <p>While not the root cause, this is what we finally saw that pointed us in the right direction. But we had to hack in other messages to get to the true root cause.</p> <p>exception in thread "config-pusher" java.lang.IllegalStateException: Unable to resolve value AttributeConfigElement [defaultValue=null, value=MappedDependency</p> {namespace='urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding', serviceName='binding-notification-service', refName='binding-notification-broker'} <p>] to attribute notification-service<br/> at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.InstanceConfig.resolveConfiguration(InstanceConfig.java:131)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.InstanceConfig.fromXml(InstanceConfig.java:192)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.ModuleConfig.fromXml(ModuleConfig.java:59)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.Config$1.resolveElement(Config.java:147)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.Config$1.resolveElement(Config.java:144)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.Config.resolveModule(Config.java:224)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.Config.fromXmlModulesResolved(Config.java:152)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfigXmlParser$EditConfigExecution.getResolvedXmlElements(EditConfigXmlParser.java:174)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfig.setOnTransaction(EditConfig.java:184)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfig.test(EditConfig.java:120)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfig.executeTests(EditConfig.java:96)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfig.getResponseInternal(EditConfig.java:75)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfig.handleWithNoSubsequentOperations(EditConfig.java:308)<br/> at org.opendaylight.controller.netconf.util.mapping.AbstractLastNetconfOperation.handle(AbstractLastNetconfOperation.java:33)<br/> at org.opendaylight.controller.netconf.util.mapping.AbstractNetconfOperation.handle(AbstractNetconfOperation.java:100)<br/> at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.sendRequestGetResponseCheckIsOK(ConfigPusherImpl.java:342)<br/> at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.pushConfig(ConfigPusherImpl.java:293)<br/> at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.pushConfigWithConflictingVersionRetries(ConfigPusherImpl.java:135)<br/> at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.internalPushConfigs(ConfigPusherImpl.java:103)<br/> at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.process(ConfigPusherImpl.java:76)<br/> at org.opendaylight.controller.netconf.persist.impl.osgi.ConfigPersisterActivator$InnerCustomizer$1.run(ConfigPersisterActivator.java:181)<br/> at java.lang.Thread.run(Thread.java:745)<br/> Caused by: java.lang.IllegalArgumentException: No service mapped to urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding:binding-notification-service:binding-notification-broker. Wrong namespace, available namespaces: []<br/> at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.ServiceRegistryWrapper.getByServiceAndRefName(ServiceRegistryWrapper.java:31)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.mapping.attributes.resolving.ObjectNameAttributeResolvingStrategy.parseAttribute(ObjectNameAttributeResolvingStrategy.java:44)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.mapping.attributes.fromxml.AttributeConfigElement.resolveValue(AttributeConfigElement.java:46)<br/> at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.InstanceConfig.resolveConfiguration(InstanceConfig.java:127)<br/> ... 21 more</p> <p>This sounds to be related to <a href="https://jira.opendaylight.org/browse/CONTROLLER-1372" title="Semantic errors in feature config files could be reported better" class="issue-link" data-issue-key="CONTROLLER-1372"><del>CONTROLLER-1372</del></a> (and <a href="https://jira.opendaylight.org/browse/CONTROLLER-1349" title="Typo in unrelated config file can block netconf-connector functionality" class="issue-link" data-issue-key="CONTROLLER-1349"><del>CONTROLLER-1349</del></a>). So what is the new expected behavior now when Change 28985 was merged?</p> <p>This should satisfy <a href="https://jira.opendaylight.org/browse/CONTROLLER-1372" title="Semantic errors in feature config files could be reported better" class="issue-link" data-issue-key="CONTROLLER-1372"><del>CONTROLLER-1372</del></a>. Config push errors are now logged to ERROR with the config file name and it also logs INFO when it's starting a config push and when it successfully completes. This helps to see if a config is hanging and how long each push took.</p> <p>(In reply to Vratko Polák from comment #3)<br/> &gt; This sounds to be related to <a href="https://jira.opendaylight.org/browse/CONTROLLER-1372" title="Semantic errors in feature config files could be reported better" class="issue-link" data-issue-key="CONTROLLER-1372"><del>CONTROLLER-1372</del></a> (and <a href="https://jira.opendaylight.org/browse/CONTROLLER-1349" title="Typo in unrelated config file can block netconf-connector functionality" class="issue-link" data-issue-key="CONTROLLER-1349"><del>CONTROLLER-1349</del></a>). So what is the new<br/> &gt; expected behavior now when Change 28985 was merged?</p> <p>I confirm that this Bug as well as <a href="https://jira.opendaylight.org/browse/CONTROLLER-1372" title="Semantic errors in feature config files could be reported better" class="issue-link" data-issue-key="CONTROLLER-1372"><del>CONTROLLER-1372</del></a> were fixed by Change 28985.</p> <p>Current implementation stops pushing configs when first error happens, so other configs (which may be unrelated and thus they may succeed) are not pushed.</p> <p>This fix was not cherry-picked to Beryllium yet.</p> <p>It is: <a href="https://git.opendaylight.org/gerrit/#/c/29216/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/29216/</a> - just not merged yet.</p> <p>(In reply to Vratko Polák from comment #5)<br/> &gt; I confirm that this Bug as well as <a href="https://jira.opendaylight.org/browse/CONTROLLER-1372" title="Semantic errors in feature config files could be reported better" class="issue-link" data-issue-key="CONTROLLER-1372"><del>CONTROLLER-1372</del></a> were fixed by Change 28985.<br/> &gt; <br/> &gt; Current implementation stops pushing configs when first error happens, so<br/> &gt; other configs (which may be unrelated and thus they may succeed) are not<br/> &gt; pushed.<br/> &gt; <br/> &gt; This fix was not cherry-picked to Beryllium yet.</p> <p>&gt;&gt; was not cherry-picked<br/> &gt; just not merged yet</p> <p>Oh, I have missed that Change.<br/> I should be more careful with my verbs.</p> <p>Change merged, needs cherry-pick to Lithium.</p> <p>It was originally done in Lithium - this can be closed.</p> <p>(In reply to Robert Varga from comment #8)<br/> &gt; Change merged, needs cherry-pick to Lithium.</p> Development External issue ID 4560 External issue URL Issue Type ODL SR Target Milestone Rank 0|i02qkn: