https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-1475 controller <p>I am getting following exception during net-virt clustering test. </p> <p>2016-01-20 03:55:32,386 | WARN | lt-dispatcher-27 | ShardManager | 161 - org.opendaylight.controller.sal-distributed-datastore - 1.3.0.SNAPSHOT | Supervisor Strategy caught unexpected exception - resuming<br/> java.lang.NullPointerException<br/> at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:210)<span class="error">&#91;61:com.google.guava:18.0.0&#93;</span><br/> at org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier$AbstractPathArgument.&lt;init&gt;(YangInstanceIdentifier.java:413)<span class="error">&#91;76:org.opendaylight.yangtools.yang-data-api:0.8.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier$NodeWithValue.&lt;init&gt;(YangInstanceIdentifier.java:584)<span class="error">&#91;76:org.opendaylight.yangtools.yang-data-api:0.8.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.controller.cluster.datastore.node.utils.stream.NormalizedNodeInputStreamReader.readNormalizedNodeInternal(NormalizedNodeInputStreamReader.java:138)<span class="error">&#91;157:org.opendaylight.controller.sal-clustering-commons:1.3.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.controller.cluster.datastore.node.utils.stream.NormalizedNodeInputStreamReader.readNormalizedNode(NormalizedNodeInputStreamReader.java:97)<span class="error">&#91;157:org.opendaylight.controller.sal-clustering-commons:1.3.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.controller.cluster.datastore.DataTreeCandidatePayload.readNode(DataTreeCandidatePayload.java:184)<span class="error">&#91;161:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.controller.cluster.datastore.DataTreeCandidatePayload.readChildren(DataTreeCandidatePayload.java:146)<span class="error">&#91;161:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.controller.cluster.datastore.DataTreeCandidatePayload.readModifiedNode(DataTreeCandidatePayload.java:161)<span class="error">&#91;161:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT&#93;</span> </p> <p>Dumping debug message in NormalizedNodeInputStreamReader, shows that it's throwing exception while reading ip_address leaf of the flow.<br/> Following gist has full exception and debug messages before this exception occures</p> <p><a href="https://gist.githubusercontent.com/vishnoianil/0fab6f95c5f6824891cd/raw/f46ae667f9a8aef94f789a81c2480c4480cfac22/gistfile1.txt" class="external-link" target="_blank" rel="nofollow noopener">https://gist.githubusercontent.com/vishnoianil/0fab6f95c5f6824891cd/raw/f46ae667f9a8aef94f789a81c2480c4480cfac22/gistfile1.txt</a></p> <p>I am seeing this exception in inventory shard leader controller instance log as well as one of the follower. <br/> But the flow that is causing this exception, successfully getting installed on the switch.</p> <p>Operating System: All<br/> Platform: All</p> CONTROLLER-1475

Supervisor Strategy caught unexpected exception because of NPE in NormalizedNodeInputStreamReader

Bug Resolved Done Robert Varga Anil Vishnoi Wed, 20 Jan 2016 05:33:26 +0000 Tue, 25 Jul 2023 08:24:06 +0000 Tue, 1 Mar 2016 19:25:36 +0000 clustering 0 7 <p>ip-address was the last node that was read so it's not the problem. The problem occurs on the next DataTreeCandidatePayload which appears to contain a standalone LeafSetEntryNode w/o the parent LeafSetNode. In this case only the entry's value is outputted to the stream as the NormalizedNodeWriter doesn't pass NodeIdentifier in the leafSetEntryNode method. Presumably this was done for efficiency so the NodeIdentifier QName isn't duplicated for each entry when writing out a leaf set. However it assumes the parent LeafSetNode was previously written to the stream. The NormalizedNodeInputStreamReader makes the same assumption. In order to create a LeafSetEntryNode it needs the leaf set QName. This is obtained when the parent LeafSetNode is parsed and it's cached when the child LeafSetEntryNode's are parsed. However if the stream contains only a LeafSetEntryNode then the leaf set QName isn't available which leads to the NPE.</p> <p>I'm not familiar with the OF data model and which leaf set is causing the issue and which component is writing it. </p> <p>It seems the the NormalizedNodeWriter needs to detect that a standalone/parentless LeafSetEntryNode is being written and pass the NodeIdentifier to the stream writer, either as a @Nullable param to the existing method or a new method.</p> <p>Submitted <a href="https://git.opendaylight.org/gerrit/#/c/33192" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/33192</a> which adds a unit test that reproduces the NPE in NormalizedNodeInputStreamReader.</p> <p>Looks like a change to NormalizedNodeStreamWriter's methods will be required to expose the QName.</p> <p>Yes unfortunately - I don't see any other way around it. Adding QName (or NodeWithValue) to leafSetEntryNode would be enough on the yangtools side. The CDS NormalizedNodeOutputStreamWriter already keeps track of whether the parent was seen.</p> <p>(In reply to Robert Varga from comment #3)<br/> &gt; Looks like a change to NormalizedNodeStreamWriter's methods will be required<br/> &gt; to expose the QName.</p> <p>Submitted yangtools patch <a href="https://git.opendaylight.org/gerrit/#/c/33222/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/33222/</a> to add the QName param.</p> <p>Do we need an API waiver?</p> <p>I'm working on the controller side patch.</p> <p>I don't know if any other projects need changes.</p> <p>Yes we do. I am actually working on a patch to add NodeWithValue, which is consistent with the rest of the API. I will go through the projects &#8211; it has not been two weeks since last waiver <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>I added a QName param with my patch. I didn't know you were working on it. NodeWithValue is fine too - we can go with your patch - either way - I'll leave it up to you.</p> <p>I have the controller side patch <a href="https://git.opendaylight.org/gerrit/#/c/33228/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/33228/</a> working (it's a draft right now since it won't build in jenkins) with changes to AbstractNormalizedNodeDataOutput and NormalizedNodePruner. Added more unit tests to DataTreeCandidatePayloadTest to cover standalone leaf node and ordered leaf set (recently added - I fixed an issue with it).</p> <p>Note that AnyXML doesn't work at all with the CDS streaming (it doesn't know how to serialize a DOMSource) but that's a separate issue.</p> <p>(In reply to Robert Varga from comment #6)<br/> &gt; Yes we do. I am actually working on a patch to add NodeWithValue, which is<br/> &gt; consistent with the rest of the API. I will go through the projects &#8211; it<br/> &gt; has not been two weeks since last waiver <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>mdsal: <a href="https://git.opendaylight.org/gerrit/33231" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/33231</a><br/> controller: <a href="https://git.opendaylight.org/gerrit/33230" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/33230</a><br/> netconf: <a href="https://git.opendaylight.org/gerrit/33229" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/33229</a></p> <p>Waiting for initial review, will send out an API freeze waiver once initial review has been done.</p> <p>I already submitted controller patch <a href="https://git.opendaylight.org/gerrit/#/c/33228/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/33228/</a> which fixes the issue so <a href="https://git.opendaylight.org/gerrit/#/c/33230/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/33230/</a> isn't needed.</p> <p>(In reply to Robert Varga from comment #8)<br/> &gt; mdsal: <a href="https://git.opendaylight.org/gerrit/33231" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/33231</a><br/> &gt; controller: <a href="https://git.opendaylight.org/gerrit/33230" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/33230</a><br/> &gt; netconf: <a href="https://git.opendaylight.org/gerrit/33229" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/33229</a><br/> &gt; <br/> &gt; Waiting for initial review, will send out an API freeze waiver once initial<br/> &gt; review has been done.</p> <p>Boron has been merged, still working on the API waiver for Beryllium.</p> <p>Tom/Robert,</p> <p>I believe all the relevant patches are merged for this bug, or do we have any pending patches that needs to be merged ?</p> <p>Beryllium/Boron are fixed, but this needs to backported to Lithium, too.</p> <p>If the bug is a blocker, has it been fixed for Lithium SR4? If this bug is NOT a blocker, can we downgrade the severity to “critical”?</p> <p>Lithium does not have all the dependencies need to fix this.</p> Duplicate CONTROLLER-1452 Development External issue ID 5019 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i02qsv: