https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-1731 controller <p>This is similar to <a href="https://jira.opendaylight.org/browse/CONTROLLER-1681" title="produce-transactions does not unregister the producer on error" class="issue-link" data-issue-key="CONTROLLER-1681"><del>CONTROLLER-1681</del></a> but now it does not concern the scenario where producer fails. Instead, when producer finishes successfully, it prevents another produce-transactions call with the same id.</p> <p>This leads <span class="error">&#91;0&#93;</span> to the same "is attached to producer" error message.</p> <p><span class="error">&#91;0&#93;</span> <a href="https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/10/log.html.gz#s1-s4-t3-k2-k25-k1-k8" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/10/log.html.gz#s1-s4-t3-k2-k25-k1-k8</a></p> <p>Operating System: All<br/> Platform: All</p> CONTROLLER-1731

it provider: produce-transactions does not close itemProducer on success

Bug Resolved Done Vratko Polak Vratko Polak Thu, 29 Jun 2017 07:37:51 +0000 Tue, 25 Jul 2023 08:24:44 +0000 Wed, 12 Jul 2017 12:19:55 +0000 clustering 0 2 <p>Attempt <span class="error">&#91;1&#93;</span> to fix.</p> <p><span class="error">&#91;1&#93;</span> <a href="https://git.opendaylight.org/gerrit/59649" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/59649</a></p> <p>Sandbox <span class="error">&#91;2&#93;</span> shows this is not fixed enough.</p> <p><span class="error">&#91;2&#93;</span> <a href="https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/17/log.html.gz#s1-s4-t1-k2-k25-k1-k9-k1-k1-k1" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/17/log.html.gz#s1-s4-t1-k2-k25-k1-k9-k1-k1-k1</a></p> <p>This week Sandbox: <span class="error">&#91;3&#93;</span>.<br/> Well, in this case the close is missing on an expected RequestTimeoutException <span class="error">&#91;4&#93;</span>, but the previous fix should have handled all rpc results.</p> <p><span class="error">&#91;3&#93;</span> <a href="https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/1/log.html.gz#s1-s4-t1-k2-k25-k1-k8" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/1/log.html.gz#s1-s4-t1-k2-k25-k1-k8</a><br/> <span class="error">&#91;4&#93;</span> <a href="https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/1/log.html.gz#s1-s4-t1-k2-k25-k1-k1" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/1/log.html.gz#s1-s4-t1-k2-k25-k1-k1</a></p> <p>Looking at the code, I believe the thinko is not in transaction producers, but in ShardedDOMDataTree (the Mdsal one).</p> <p>Specifically, this change <span class="error">&#91;5&#93;</span> of findProducer() implementation went from explicitly looking for producers registered for sub-trees of the "subtree" argument, to delegating to lookup(), which was later <span class="error">&#91;6&#93;</span> documented to return producers registered at super-trees of the given prefix.</p> <p>I think we need to split findProducer, as both usages (making sure no sub-producer is claimed and finding the nearest super-producer) are valid.</p> <p>P.S.: What is the recommended language when talking about one node being within the subtree rooted at another node?</p> <p><span class="error">&#91;5&#93;</span> <a href="https://git.opendaylight.org/gerrit/#/c/26244/5/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMDataTree.java" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/26244/5/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMDataTree.java</a><br/> <span class="error">&#91;6&#93;</span> <a href="https://git.opendaylight.org/gerrit/#/c/31411/3/dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/DOMDataTreePrefixTable.java" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/31411/3/dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/DOMDataTreePrefixTable.java</a></p> <p>Ad the PS, this maps to 'descendant' XPath axis, as defined in <a href="https://www.w3schools.com/xml/xpath_axes.asp" class="external-link" target="_blank" rel="nofollow noopener">https://www.w3schools.com/xml/xpath_axes.asp</a>.</p> <p>Hence "node A, which is part of the subtree rooted at node B" maps to "A is descendant of B".</p> <p>Sandbox run with logging changes <span class="error">&#91;7&#93;</span><span class="error">&#91;8&#93;</span>. Robot failure: <span class="error">&#91;9&#93;</span>. Big karaf.log: <span class="error">&#91;10&#93;</span>.</p> <p>The first status change related to data producers is at 11:53:00,632, the initialization seems to end at 11:56:04,115.</p> <p>After the expected RequestTimeoutException, producer is being closed at 11:58:10,514:<br/> ...<br/> 2017-07-11 11:58:10,515 | TRACE | ult-dispatcher-6 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Deleting value org.opendaylight.mdsal.dom.broker.ShardedDOMDataTreeProducer@11ac4117<br/> 2017-07-11 11:58:10,515 | TRACE | ult-dispatcher-6 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Child org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@24b7aa9b reported empty, removing from children<br/> 2017-07-11 11:58:10,515 | TRACE | ult-dispatcher-6 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Children after removal: {(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id-int[</p> {(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id=prefix-2} <p>]=org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@71172d08, (tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id-int[</p> {(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id=prefix-1} <p>]=org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@76e1e46b}<br/> 2017-07-11 11:58:10,515 | TRACE | ult-dispatcher-6 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Child org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@7da25b48 reported non-empty, keeping it.<br/> 2017-07-11 11:58:10,515 | TRACE | ult-dispatcher-6 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Child org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@604e5597 reported non-empty, keeping it.</p> <p>When next producer on the same member is created:<br/> 2017-07-11 11:58:31,266 | TRACE | qtp138207402-77 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Looking up identifier /(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id-ints/id-int/id-int[</p> {(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id=prefix-3} <p>] in entry org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@6e6a640e<br/> 2017-07-11 11:58:31,266 | TRACE | qtp138207402-77 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Lookup enters org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@604e5597<br/> 2017-07-11 11:58:31,266 | TRACE | qtp138207402-77 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Lookup enters org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@7da25b48<br/> 2017-07-11 11:58:31,266 | DEBUG | qtp138207402-77 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Lookup of /(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id-ints/id-int/id-int[</p> {(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id=prefix-3} <p>] stopped at (tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id-int[</p> {(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id=prefix-3} <p>]<br/> 2017-07-11 11:58:31,266 | TRACE | qtp138207402-77 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Lookup returns org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@6e6a640e<br/> 2017-07-11 11:58:31,266 | TRACE | qtp138207402-77 | ShardedDOMDataTree | 147 - org.opendaylight.mdsal.dom-broker - 2.2.1.SNAPSHOT | Found: subtree DOMDataTreeIdentifier{datastore=CONFIGURATION, root=/(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id-ints/id-int/id-int[</p> {(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id=prefix-3} <p>]} is attached to producer null<br/> 2017-07-11 11:58:31,266 | TRACE | qtp138207402-77 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Looking up identifier /(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id-ints/id-int/id-int[</p> {(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id=prefix-3} <p>] in entry org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@7e9d594f<br/> 2017-07-11 11:58:31,266 | TRACE | qtp138207402-77 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Lookup enters org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@51ae5a3a<br/> 2017-07-11 11:58:31,266 | TRACE | qtp138207402-77 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Lookup found value AbstractObjectRegistration</p> {instance=org.opendaylight.controller.cluster.sharding.DistributedShardFrontend@3bbaaaf5} <p>2017-07-11 11:58:31,266 | DEBUG | qtp138207402-77 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Lookup of /(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id-ints/id-int/id-int[</p> {(tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id=prefix-3} <p>] stopped at (tag:opendaylight.org,2017:controller:yang:lowlevel:target?revision=2017-02-15)id-int<br/> 2017-07-11 11:58:31,266 | TRACE | qtp138207402-77 | DOMDataTreePrefixTableEntry | 93 - org.opendaylight.mdsal.dom-spi - 2.2.1.SNAPSHOT | Lookup returns org.opendaylight.mdsal.dom.spi.DOMDataTreePrefixTableEntry@51ae5a3a</p> <p>&gt; "A is descendant of B"</p> <p>A is descendant-or-self of B.</p> <p>&gt; we need to split findProducer</p> <p>I see Entry can contain AbstractObjectRegistration values, no only producers. So probably we need findAncestorOrSelfEntry (for a thing findProducer does today), findAncestorOrSelfProducer (to ask ancestor producer to request subtree producer creation) and findDescendantOrSelfProducer (in order to deny createProducer request).</p> <p><span class="error">&#91;7&#93;</span> <a href="https://git.opendaylight.org/gerrit/#/c/60187/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/60187/1</a><br/> <span class="error">&#91;8&#93;</span> <a href="https://git.opendaylight.org/gerrit/#/c/60192/5" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/60192/5</a><br/> <span class="error">&#91;9&#93;</span> <a href="https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/4/log.html.gz#s1-s2-t1-k2-k25-k1-k8" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/4/log.html.gz#s1-s2-t1-k2-k25-k1-k8</a><br/> <span class="error">&#91;10&#93;</span> <a href="https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/4/odl3_karaf.log.gz" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/sandbox/jenkins091/controller-csit-3node-clustering-li-only-carbon/4/odl3_karaf.log.gz</a></p> <p>The original symptom is fixed, the additional symptom tracked as <a href="https://jira.opendaylight.org/browse/CONTROLLER-1740" title="Producer un-registration on isolated node is never propagated to the rest of the cluster" class="issue-link" data-issue-key="CONTROLLER-1740"><del>CONTROLLER-1740</del></a>.</p> Development External issue ID 8768 External issue URL Issue Type Rank 0|i02sdr: