https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-1765 controller <p>The new tool from <a href="https://jira.opendaylight.org/browse/CONTROLLER-1760" title="Tooling to find the real root cause culprit of memory leaks related to non-closed transactions (and tx chains)" class="issue-link" data-issue-key="CONTROLLER-1760"><del>CONTROLLER-1760</del></a> can show "some false positives", as discussed in <a href="https://jira.opendaylight.org/browse/NETCONF-462" title="TransactionChain created in RestConnectorProvider.start line 87 is never closed" class="issue-link" data-issue-key="NETCONF-462"><del>NETCONF-462</del></a> ...</p> <p>Operating System: All<br/> Platform: All</p> CONTROLLER-1765

trace:transactions should suppress false TransactionChain positives, by white list, or showing only x2+ ?

Improvement Resolved Done Michael Vorburger Michael Vorburger Thu, 31 Aug 2017 13:22:28 +0000 Tue, 25 Jul 2023 08:24:46 +0000 Tue, 31 Jul 2018 09:04:41 +0000 Fluorine mdsal 0 3 <p>+Tom, if you want to chime in here:</p> <p>I'm leaning towards implementing the solution to suppress all open TransactionChains that are only x1 and only start showing x2+ from trace:transactions... but ONLY for TransactionChain, NOT for the Read<span class="error">&#91;Write&#93;</span>Transaction! Maybe with a -a kind of CLI flag, to be able to see "all", if you really want to. Thoughts, approvals, objections?</p> <p><a href="https://jira.opendaylight.org/browse/OPNFLWPLUG-982" title="Suspected TransactionChain leak in TransactionChainManager (or fix false positive in TracingBroker)" class="issue-link" data-issue-key="OPNFLWPLUG-982"><del>OPNFLWPLUG-982</del></a> seems to say that there are cases where we should ignore and therefore be able to whitelist some known false positives (perhaps by stack trace content, just via String contains) ... so perhaps trace:transactions could have new arguments to ignore &lt;N "leaks" or containing Strings.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/72362/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/72362/</a> is adding sorting, which helps in spotting the bad from the harmless more easily.</p> <p>This has come up in <a href="https://jira.opendaylight.org/browse/NETVIRT-1089" title="Add trace:transactions to suite teardowns" class="issue-link" data-issue-key="NETVIRT-1089">NETVIRT-1089</a> again... it's hard for a fully automated (CSIT) test to programmatically know / distinguish when there is a real problem.</p> <p>I'll therefore add a new option to that CLI command to suppress leaks with less than N (option) open TXs.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/74652/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/74652/</a> should do the trick... Once that is merged, <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=jluhrsen" class="user-hover" rel="jluhrsen">jluhrsen</a> can use it in <a href="https://jira.opendaylight.org/browse/NETVIRT-1089" title="Add trace:transactions to suite teardowns" class="issue-link" data-issue-key="NETVIRT-1089">NETVIRT-1089</a> with some "sensible value" (7 ?) for the new minOpenTransactions option to trace:transactions, and we're done here.</p> Blocks NETVIRT-1089 NETVIRT-883 CONTROLLER-1760 NETCONF-462 Development External issue ID 9081 External issue URL Rank 0|i02slb: