https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-1771 controller <p>This Improvement will make it easier for CSIT to avoid launching tests while ODL is still busy booting up. There are better ways to publish config readiness (might be implemented later), but logging change is the simplest. Especially since the message is already there <span class="error">&#91;0&#93;</span>, but only on DEBUG level.</p> <p><span class="error">&#91;0&#93;</span> <a href="https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blob;f=opendaylight/config/config-persister-impl/src/main/java/org/opendaylight/controller/config/persist/impl/ConfigPusherImpl.java;h=6fcc7dcd4d14b9d04bbad384f9ac38214e6da911;hb=refs/heads/stable/carbon#l139" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blob;f=opendaylight/config/config-persister-impl/src/main/java/org/opendaylight/controller/config/persist/impl/ConfigPusherImpl.java;h=6fcc7dcd4d14b9d04bbad384f9ac38214e6da911;hb=refs/heads/stable/carbon#l139</a></p> <p>Operating System: All<br/> Platform: All</p> CONTROLLER-1771

Add INFO log when config subsystem finishes applying initial configurations

Bug Resolved Done Vratko Polak Vratko Polak Thu, 14 Sep 2017 13:07:44 +0000 Mon, 9 Oct 2017 10:54:32 +0000 Mon, 9 Oct 2017 10:54:32 +0000 Carbon config 0 3 <p>Fix: <a href="https://git.opendaylight.org/gerrit/63136" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/63136</a> (master, cherry-picks are also available).</p> <p>Waiting for review (at least for Carbon and Nitrogen).</p> <p>As of Oxygen, all ODL projects will be off of CSS and CSS will be going away most likely in Flourine. So I would suggest not adding any CSIT dependency on CSS. In fact relying on CSS readiness would largely be incorrect since most of the projects have been converted to blueprint and removed their CSS modules. Micheal Vorburger has been working on another "readiness" mechanism - I would suggest syncing up with him.</p> <p>&gt; another "readiness" mechanism</p> <p>Yes, I am aware of that, but it is not really available in Carbon and Nitrogen, and I am not sure how reliable it is in current Oxygen snapshots.</p> <p>(In reply to Vratko Polák from comment #4)<br/> &gt; &gt; another "readiness" mechanism<br/> &gt; <br/> &gt; Yes, I am aware of that, but it is not really available in Carbon and<br/> &gt; Nitrogen, and I am not sure how reliable it is in current Oxygen snapshots.</p> <p>Well using CSS isn't reliable or correct as I mentioned as most projects no longer use it. So I would suggest focusing on Micheal's new "readiness" mechanism and getting that reliable. I can help with that as well if needed.</p> <p>&gt; Well using CSS isn't reliable or correct as I mentioned as most projects no<br/> &gt; longer use it.</p> <p>Yes, it is unreliable in the sense that if CSS is ready, other parts of ODL may still not be ready. But it is reliable in the sense that when ODL no longer burns CPU, CSS has already reported readiness. The latter reliability is required for CSIT use, the former would only be a benefit.</p> <p>&gt; So I would suggest focusing on Micheal's new "readiness"<br/> &gt; mechanism and getting that reliable. I can help with that as well if needed.</p> <p>Changing log level in one line is a low hanging fruit. Focusing on a new mechanism is not. (And I would probably prefer monitoring CPU usage instead.)</p> <p>By the way, looking at logging best practices <span class="error">&#91;2&#93;</span>, this Improvement might also be considered a Bug.</p> <p><span class="error">&#91;2&#93;</span> <a href="https://wiki.opendaylight.org/view/BestPractices/Logging_Best_Practices#INFO" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.opendaylight.org/view/BestPractices/Logging_Best_Practices#INFO</a></p> <p>I think Vratko has a very valid point. We are already emitting INFO messages for each config entry, just not when we finished them all.</p> <p>If this is a clarity trade-off, I would much rather see that 'all done' at INFO and per-file at DEBUG.</p> <p>(In reply to Robert Varga from comment #7)<br/> &gt; I think Vratko has a very valid point. We are already emitting INFO messages<br/> &gt; for each config entry, just not when we finished them all.<br/> &gt; <br/> &gt; If this is a clarity trade-off, I would much rather see that 'all done' at<br/> &gt; INFO and per-file at DEBUG.</p> <p>I agree - it should be INFO - I wasn't trying to debate that. My point is relying on it in CSIT for the reasons I mentioned earlier, ie most apps use BP and CSS will be going away maybe next release. But if it has use right now (especially in Carbon) in lieu of a complete alternate "readiness" solution, that's fine.</p> <p>If one of you (above) would like to work constructively with me to make infrautils ready aware of CSS initialization completion, I'm happy to engage on that. What I had in mind as a general mechanism for what I think you would need here is <a href="https://git.opendaylight.org/gerrit/#/c/56821/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/56821/</a>. If you were interested to collaborate, I could finish that up, you could review it, and then you could use it to signal CSS ready-ness (I would not know where or how to do this in controller's CSS code).</p> <p>(In reply to Michael Vorburger from comment #9)<br/> &gt; If one of you (above) would like to work constructively with me to make<br/> &gt; infrautils ready aware of CSS initialization completion, I'm happy to engage<br/> &gt; on that. What I had in mind as a general mechanism for what I think you<br/> &gt; would need here is <a href="https://git.opendaylight.org/gerrit/#/c/56821/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/56821/</a>. If you<br/> &gt; were interested to collaborate, I could finish that up, you could review it,<br/> &gt; and then you could use it to signal CSS ready-ness (I would not know where<br/> &gt; or how to do this in controller's CSS code).</p> <p>I don't think we should spend time incorporate CSS readiness into the new mechanism. As I've mentioned, most Nitrogen and all Oxygen projects will be off of CSS (only sxp and usc left) and I'd like to remove CSS in Flourine.</p> <p>Merged to 3 of 4 branches, Nitrogen was frozen (but not anymore).</p> <p><a href="https://git.opendaylight.org/gerrit/63137" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/63137</a> merged.</p> Development External issue ID 9165 External issue URL Issue Type Rank 0|i02smn: