https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-1798 controller <p>ShardManager will miss sending a PeerAddressResolved message to local shards when UpdateSchemaContext comes after MemberUp. Currently PeerAddressResolved is only sent when receiving MemberUp/MemberReachable messages. At that time, the local shards actors may still have not been created for the UpdateSchemaContext message has not come. So the PeerAddressResolved message won't be sent to the local shards actors for they're null. When UpdateSchemaContext arrives later, local shards actors will be created with no PeerAddress MBean information.</p> <p>To avoid such missing, PeerAddressResolved should also be sent after receiving UpdateSchemaContext if there're peer members.</p> CONTROLLER-1798

ShardManager will miss sending a PeerAddressResolved message to local shards when UpdateSchemaContext comes after MemberUp

Bug Medium Resolved Done Unassigned Kangqian Yin Mon, 27 Nov 2017 03:32:21 +0000 Tue, 5 Dec 2017 07:36:34 +0000 Tue, 5 Dec 2017 07:36:34 +0000 clustering 0 2 <p>This really shouldn't matter since RaftActorContextImpl#getPeerAddress will obtain the peer's address from the PeerAddressResolver if the address isn't set in the peerInfoMap</p> <p>Hi, Tom, just as you said, RaftActorContextImpl#getPeerAddress will obtain the peer's address and set it to the peerInfoMap if it's not set. But RaftActorContextImpl#getPeerAddress won't put a new PeerInfo object into the peerInfoMap if the peerInfoMap doesn't contain the peer. </p> <p>And RaftActorContextImpl#getPeerAddress is not called by RaftActorContextImpl#getPeers which is called by RaftActor#onGetOnDemandRaftState when a shard responses to a GetOnDemandRaftState message issued by the shard mbean ShardStats. So the JMX client cannot retrieve the address information of the peer which doesn't exist in peerInfoMap.</p> <p>So we have either to modify RaftActorContextImpl#getPeers to get all existing peers in the peer address resolver, or to modify the ShardManager#updateSchemaContext to send PeerAddressResolved messages for all existing peers to the shard. </p> <p>Because PeerAddressResolver interface only has a resolve(String peerId) API. I think it's better to modify the ShardManager#updateSchemaContext. </p> <p>I'll upload a patch to fix this later.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/66186/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/66186/</a></p> Development Rank 0|i038g7: