OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 [CONTROLLER-1799] Archetype should self test during Maven build https://jira.opendaylight.org/browse/CONTROLLER-1799 controller <p><a href="https://jira.opendaylight.org/browse/CONTROLLER-1728" title="startup archetype upgrade to karaf 4" class="issue-link" data-issue-key="CONTROLLER-1728"><del>CONTROLLER-1728</del></a> at the time did not manage to get the archetype "self testing" to work.</p> <p>It's currently disabled by &lt;archetype.test.skip&gt;true in controller/opendaylight/archetypes/pom.xml.</p> <p>The goal of this issue is to make that work.</p> CONTROLLER-1799 Archetype should self test during Maven build Improvement Medium Resolved Done Michael Vorburger Michael Vorburger Mon, 27 Nov 2017 17:43:31 +0000 Tue, 30 Jan 2018 13:51:30 +0000 Tue, 30 Jan 2018 13:51:30 +0000 Oxygen 0 4 <p>As per <a href="https://lists.opendaylight.org/pipermail/controller-dev/2017-September/013889.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/controller-dev/2017-September/013889.html</a> :</p> <blockquote><p>this is how to repro. the problem we saw on Jenkins locally:</p></blockquote> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>rm -rf ~/.m2/repository/org/opendaylight/odlparent mvn -Dmaven.repo.local=/tmp/Bug8741-archetype-repo clean install</pre> </div></div> <p>and it will fail like this:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default) @ odl-basic-api --- [INFO] [INFO] Surefire report directory: /home/vorburger/dev/ODL/git/controller/opendaylight/archetypes/opendaylight-startup/target/test-classes/projects/basic/project/basic/features/odl-X-api/target/surefire-reports [INFO] [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.opendaylight.odlparent.featuretest.SingleFeatureTest [INFO] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 6.693 sec &lt;&lt;&lt; FAILURE! - in org.opendaylight.odlparent.featuretest.SingleFeatureTest [INFO] installFeatureCatchAndLog(org.opendaylight.odlparent.featuretest.SingleFeatureTest)[repoUrl: file:/home/vorburger/dev/ODL/git/controller/opendaylight/archetypes/opendaylight-startup/target/test-classes/projects/basic/project/basic/features/odl-X-api/target/feature/feature.xml, Feature: odl-basic-api 0.0.1.SNAPSHOT] Time elapsed: 6.311 sec &lt;&lt;&lt; ERROR! [INFO] shaded.org.eclipse.aether.resolution.ArtifactResolutionException: Error resolving artifact org.opendaylight.odlparent:opendaylight-karaf-empty:zip:2.0.5 [INFO] at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:444) [INFO] at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:246) [INFO] at shaded.org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:223) [INFO] at shaded.org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact(DefaultRepositorySystem.java:294) [INFO] at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:705) [INFO] at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:659) [INFO] at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:600) [INFO] at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:567) [INFO] at org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:557) [INFO] at org.ops4j.pax.url.mvn.internal.Connection.getInputStream(Connection.java:123) [INFO] at java.net.URL.openStream(URL.java:1045) [INFO] at org.ops4j.pax.exam.karaf.container.internal.ArchiveExtractor.extractZipDistribution(ArchiveExtractor.java:88) [INFO] at org.ops4j.pax.exam.karaf.container.internal.ArchiveExtractor.extract(ArchiveExtractor.java:67) [INFO] at org.ops4j.pax.exam.karaf.container.internal.KarafTestContainer.start(KarafTestContainer.java:155) [INFO] at org.ops4j.pax.exam.spi.reactors.AllConfinedStagedReactor.invoke(AllConfinedStagedReactor.java:79) [INFO] at org.ops4j.pax.exam.junit.impl.ProbeRunner$2.evaluate(ProbeRunner.java:267) [INFO] at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) [INFO] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) [INFO] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) [INFO] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) [INFO] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) [INFO] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) [INFO] at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) [INFO] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) [INFO] at org.junit.runners.ParentRunner.run(ParentRunner.java:309) [INFO] at org.ops4j.pax.exam.junit.impl.ProbeRunner.run(ProbeRunner.java:98) [INFO] at org.ops4j.pax.exam.junit.PaxExam.run(PaxExam.java:93) [INFO] at org.opendaylight.odlparent.featuretest.PerFeatureRunner.run(PerFeatureRunner.java:72) [INFO] at org.opendaylight.odlparent.featuretest.PerRepoTestRunner.runChild(PerRepoTestRunner.java:153) [INFO] at org.opendaylight.odlparent.featuretest.PerRepoTestRunner.runChild(PerRepoTestRunner.java:28) [INFO] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) [INFO] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) [INFO] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) [INFO] at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) [INFO] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) [INFO] at org.junit.runners.ParentRunner.run(ParentRunner.java:309) [INFO] at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283) [INFO] at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173) [INFO] at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) [INFO] at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128) [INFO] at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203) [INFO] at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155) [INFO] at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) [INFO] [INFO] [INFO] Results : [INFO] [INFO] Tests in error: [INFO] Error resolving artifact org.opendaylight.odlparent:opendaylight-karaf-empty:zip:2.0.5 [INFO] [INFO] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 [INFO] [INFO] [INFO] ------------------------------------------------------------------------ [INFO] [INFO] Reactor Summary: [INFO] [INFO] [INFO] [INFO] ODL :: archetype.it :: basic-api ................... SUCCESS [ 20.375 s] [INFO] [INFO] ODL :: archetype.it :: basic-impl .................. SUCCESS [ 8.691 s] [INFO] [INFO] OpenDaylight :: basic :: API [Karaf Feature] ....... FAILURE [ 14.891 s] [INFO] [INFO] ODL :: archetype.it :: features-basic .............. SKIPPED [INFO] [INFO] ODL :: archetype.it :: basic-karaf ................. SKIPPED [INFO] [INFO] OpenDaylight :: basic :: Impl [Karaf Feature] ...... SKIPPED [INFO] [INFO] ODL :: archetype.it :: basic-cli ................... SKIPPED [INFO] [INFO] OpenDaylight :: basic :: CLI [Karaf Feature] ....... SKIPPED [INFO] [INFO] OpenDaylight :: basic :: REST [Karaf Feature] ...... SKIPPED [INFO] [INFO] ODL :: archetype.it :: basic-features-aggregator ... SKIPPED [INFO] [INFO] ODL :: archetype.it :: basic-artifacts ............. SKIPPED [INFO] [INFO] basic .............................................. SKIPPED [INFO] [INFO] ------------------------------------------------------------------------ [INFO] [INFO] BUILD FAILURE [INFO] [INFO] ------------------------------------------------------------------------ [INFO] [INFO] Total time: 46.338 s [INFO] [INFO] Finished at: 2017-11-27T16:44:01+01:00 [INFO] [INFO] Final Memory: 212M/1646M [INFO] [INFO] ------------------------------------------------------------------------ [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default) on project odl-basic-api: There are test failures. [INFO] [ERROR] [INFO] [ERROR] Please refer to /home/vorburger/dev/ODL/git/controller/opendaylight/archetypes/opendaylight-startup/target/test-classes/projects/basic/project/basic/features/odl-X-api/target/surefire-reports for the individual test results. [INFO] [ERROR] -&gt; [Help 1] [INFO] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default) on project odl-basic-api: There are test failures. [INFO] [INFO] Please refer to /home/vorburger/dev/ODL/git/controller/opendaylight/archetypes/opendaylight-startup/target/test-classes/projects/basic/project/basic/features/odl-X-api/target/surefire-reports for the individual test results.</pre> </div></div> <p>Debugging this (using <tt>-Dmaven.surefire.debug</tt>) made me understand that this is caused by Maven -&gt; Surefire -&gt; Pax Exam -&gt; Pax URL not using the custom local repo - it would search for <tt>org.opendaylight.odlparent:opendaylight-karaf-empty:zip:2.0.5</tt> in <tt>~/.m2/repository</tt> despite <tt>-Dmaven.repo.local=</tt>.</p> <p>Setting the <tt>org.ops4j.pax.url.mvn.localRepository</tt> (or perhaps also <tt>org.ops4j.pax.url.mvn.settings</tt>, not sure) property somewhere could perhaps fix this...</p> <blockquote><p>Setting the <tt>org.ops4j.pax.url.mvn.localRepository</tt> property somewhere...</p></blockquote> <p>Adding the following to <tt>single-feature-parent/pom.xml</tt> seems to fix this problem:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-xml"> <span class="code-tag">&lt;systemProperties&gt;</span> <span class="code-tag">&lt;property&gt;</span> <span class="code-tag">&lt;name&gt;</span>org.ops4j.pax.url.mvn.localRepository<span class="code-tag">&lt;/name&gt;</span> <span class="code-tag">&lt;value&gt;</span>${settings.localRepository}<span class="code-tag">&lt;/value&gt;</span> <span class="code-tag">&lt;/property&gt;</span> <span class="code-tag">&lt;/systemProperties&gt;</span> </pre> </div></div> <p>So proposed in <a href="https://git.opendaylight.org/gerrit/#/c/65940/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/65940/</a>. In addition, it seems to help, if only to make the DL of the BIG Karaf ZIP happen early in the build time instead of by Pax Exam at surefire run time, to add a dependency to opendaylight-karaf-empty, as proposed in <a href="https://git.opendaylight.org/gerrit/#/c/65941/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/65941/</a>.</p> <p>PS: Ha - I had already done the same in <tt>infrautils/itestutils/parent/pom.xml</tt> also! (The Patch Set 1 of c/65940 used the <a href="http://maven.apache.org/surefire/maven-surefire-plugin/examples/system-properties.html" class="external-link" target="_blank" rel="nofollow noopener">deprecated</a> <tt>systemProperties</tt> instead of the <tt>systemPropertyVariables</tt>; Patch Set 2 changed that, and has been locally tested to still solve this problem.</p> <p>This came up during <a href="https://git.opendaylight.org/gerrit/#/c/66545/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/66545/</a> again:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[INFO] Running it.pkg.it.BasicTest [INFO] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.686 sec &lt;&lt;&lt; FAILURE! - in it.pkg.it.BasicTest [INFO] it.pkg.it.BasicTest Time elapsed: 1.662 sec &lt;&lt;&lt; ERROR! [INFO] java.lang.RuntimeException: Problem starting container [INFO] at org.ops4j.pax.exam.karaf.container.internal.KarafTestContainer.start(KarafTestContainer.java:191) (...) [INFO] Caused by: java.io.IOException: Error resolving artifact org.opendaylight.odlparent:opendaylight-karaf-empty:zip:3.0.2: [Could not find artifact org.opendaylight.odlparent:opendaylight-karaf-empty:zip:3.0.2 in central (https://repo1.maven.org/maven2/)]</pre> </div></div> <p>and I was able to again as here locally reproduce (see above) and solve it similarly, see <a href="https://git.opendaylight.org/gerrit/#/c/66545/3..4/opendaylight/md-sal/mdsal-it-parent/pom.xml" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/66545/3..4/opendaylight/md-sal/mdsal-it-parent/pom.xml</a>. (But that's still NOK due to <a href="https://jira.opendaylight.org/browse/CONTROLLER-1811" title="controller archetype IT (it.pkg.it.BasicTest) gets stuck locks" class="issue-link" data-issue-key="CONTROLLER-1811"><del>CONTROLLER-1811</del></a>; unrelated to this.)</p> Blocks CONTROLLER-1800 CONTROLLER-1728 Development Rank 0|i038gv: