https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-1802 controller <p>Motivated by <a href="https://jira.opendaylight.org/browse/NETVIRT-916" title="vpnmanager: OptimisticLockFailedException seen during rally scenario" class="issue-link" data-issue-key="NETVIRT-916"><del>NETVIRT-916</del></a>, but much more widely applicable in general, and based on <a href="https://lists.opendaylight.org/pipermail/controller-dev/2017-December/014100.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/controller-dev/2017-December/014100.html</a>, we should reduce the ConcurrentDOMDataBroker's TX failure logging from WARN to DEBUG, and add @CheckReturnValue to WriteTransaction submit(), because it should be up to the caller to decide whether or not to log this at as a WARN, ERROR or not at all (e.g. if it is going to retry).</p> CONTROLLER-1802

Reduce ConcurrentDOMDataBroker TX failure logging from WARN to DEBUG and add @CheckReturnValue to WriteTransaction submit()

Bug Highest Resolved Done Michael Vorburger Michael Vorburger Mon, 11 Dec 2017 21:58:30 +0000 Tue, 31 Jul 2018 16:52:02 +0000 Sun, 6 May 2018 20:04:25 +0000 Fluorine mdsal 0 1 <p><a href="https://git.opendaylight.org/gerrit/#/q/topic:CONTROLLER-1802" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/q/topic:CONTROLLER-1802</a> does the needful.</p> <p>PS: What's still TBD is the equivalent of <a href="https://git.opendaylight.org/gerrit/#/c/66362/" class="external-link" target="_blank" rel="nofollow noopener">c/66362</a> in mdsal, or is there no such thing?</p> <blockquote><p>PS: What's still TBD is the equivalent of c/66362 in mdsal, or is there no such thing?</p></blockquote> <p>forget about this, according to <a href="https://lists.opendaylight.org/pipermail/controller-dev/2017-December/014102.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/controller-dev/2017-December/014102.html</a> : <em>"ConcurrentDOMDataBroker is CDS's broker implementation</em><br/> <em>(sal-distributed-datastore) and is the one used in production."</em>, so we're all good and already "done" here (when all is merged).</p> <p>We discussed this in today's <a href="https://wiki.opendaylight.org/view/Kernel_Projects_Call" class="external-link" target="_blank" rel="nofollow noopener">Kernel Projects</a> call (<a href="https://meetings.opendaylight.org/opendaylight-meeting/2018/kernel_projects/opendaylight-meeting-kernel_projects.2018-02-27-17.01.html" class="external-link" target="_blank" rel="nofollow noopener">MoM link</a>), and the plan is:</p> <ol> <li>set up a <a href="https://wiki.opendaylight.org/view/Weather" class="external-link" target="_blank" rel="nofollow noopener">Weather Item</a> describing 2. - 4.</li> <li>wait for a blue <a href="https://jenkins.opendaylight.org/releng/view/autorelease/job/autorelease-release-fluorine/" class="external-link" target="_blank" rel="nofollow noopener">autorelease-release-fluorine</a></li> <li>merge <a href="https://git.opendaylight.org/gerrit/#/c/66360/" class="external-link" target="_blank" rel="nofollow noopener">c/66360</a> into controller master (and <a href="https://git.opendaylight.org/gerrit/#/c/66361/" class="external-link" target="_blank" rel="nofollow noopener">c/66361</a>in mdsal, but that's not used, yet)</li> <li>watch autorelease-release-fluorine for any FindBugs failures, and help to promptly fix them, e.g. by using org.opendaylight.infrautils.utils.concurrent.JdkFutures's addErrorLogging()</li> </ol> Relates CONTROLLER-1855 TSC-100 Development Rank 0|i038u7: