https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-1855 controller <p><a href="https://jira.opendaylight.org/browse/GENIUS-196" title="Optimistic lock failed for path /(urn:opendaylight:genius:itm:config?revision=2016-04-06)tunnel-monitor-params/enabled" class="issue-link" data-issue-key="GENIUS-196">GENIUS-196</a> and <a href="https://jira.opendaylight.org/browse/SRVUTILS-3" title="Failed to prepare transaction member-1-datastore-config-fe-1-txn-15-0 on backend org.opendaylight.controller.md.sal.common.api.data.OptimisticLockFailedException: Optimistic lock failed for path /(urn:opendaylight:serviceutils:upgrade?rev..)upgrade-config" class="issue-link" data-issue-key="SRVUTILS-3">SRVUTILS-3</a> seem to show that Controller error logs any OptimisticLockFailedException. </p> <p>I'm pretty sure a while we had discussion about this concluding that this is bad - the logging is up to applications - they need to handle the returned Future. (Can't find respective old discussion / JIRA / Gerrit right now; anyone better at finding what I mean?)</p> <p>Let's change this again?</p> CONTROLLER-1855

Controller should not error log any OptimisticLockFailedException which applications actually handle

Bug Medium Resolved Done Tom Pantelis Michael Vorburger Tue, 31 Jul 2018 15:57:18 +0000 Tue, 28 Aug 2018 16:45:18 +0000 Thu, 2 Aug 2018 12:44:57 +0000 Oxygen SR2 Fluorine Oxygen SR2 0 2 <p><a href="https://jira.opendaylight.org/browse/CONTROLLER-1802" title="Reduce ConcurrentDOMDataBroker TX failure logging from WARN to DEBUG and add @CheckReturnValue to WriteTransaction submit()" class="issue-link" data-issue-key="CONTROLLER-1802"><del>CONTROLLER-1802</del></a> is the first issue ... see also <a href="https://git.opendaylight.org/gerrit/#/q/CONTROLLER-1802" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/q/CONTROLLER-1802</a>.</p> <p>Do we just need to cherry-pick something from master to oxygen? Or change something we forget in <a href="https://jira.opendaylight.org/browse/CONTROLLER-1802" title="Reduce ConcurrentDOMDataBroker TX failure logging from WARN to DEBUG and add @CheckReturnValue to WriteTransaction submit()" class="issue-link" data-issue-key="CONTROLLER-1802"><del>CONTROLLER-1802</del></a> on master from an ERROR to a WARN or an INFO ?</p> <p>master patch: <a href="https://git.opendaylight.org/gerrit/#/c/74701/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/74701/</a></p> <p>Oxygen <a href="https://git.opendaylight.org/gerrit/#/c/74706/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/74706/</a> which JUST still made it for SR2.</p> <p>These change the ERROR to a WARN.</p> <p>Closing this issue.</p> <p>FTR: This came up again under <a href="https://jira.opendaylight.org/browse/NETVIRT-1324" title="OptimisticLockFailedException.../flow/flow...id=L3.53688268439021.20.0L3" class="issue-link" data-issue-key="NETVIRT-1324"><del>NETVIRT-1324</del></a>.</p> Blocks GENIUS-196 SRVUTILS-3 Relates CONTROLLER-1802 NETVIRT-1324 Development Rank 0|i03hcf: