https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-2085 controller <p>A quick grep shows at least these users of deprecated API:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>./controller/benchmark/dsbenchmark/src/main/java/org/opendaylight/dsbenchmark/DsbenchmarkProvider.java:        rpcReg = rpcService.registerRpcImplementation(DsbenchmarkService.class, this); ./controller/benchmark/ntfbenchmark/src/main/java/ntfbenchmark/impl/NtfbenchmarkProvider.java:        reg = rpcService.registerRpcImplementation(NtfbenchmarkService.class, this); ./controller/benchmark/rpcbenchmark/src/main/java/rpcbenchmark/impl/GlobalBindingRTCServer.java:        reg = rpcProvider.registerRpcImplementation(RpcbenchPayloadService.class, this); ./controller/benchmark/rpcbenchmark/src/main/java/rpcbenchmark/impl/RoutedBindingRTCServer.java:        reg = rpcProvider.registerRpcImplementation(RpcbenchPayloadService.class, this, paths); ./controller/benchmark/rpcbenchmark/src/main/java/rpcbenchmark/impl/RpcbenchmarkProvider.java:        reg = providerRegistry.registerRpcImplementation(RpcbenchmarkService.class, this); ./controller/opendaylight/md-sal/eos-dom-akka/src/main/java/org/opendaylight/controller/eos/akka/AkkaEntityOwnershipService.java:        reg = rpcProvider.registerRpcImplementation(OdlEntityOwnersService.class, this); ./controller/opendaylight/md-sal/sal-cluster-admin-impl/src/main/java/org/opendaylight/controller/cluster/datastore/admin/OSGiClusterAdmin.java:        reg = rpcProviderService.registerRpcImplementation(ClusterAdminService.class, ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java:        doReturn(newReg).when(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class), ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java:        doReturn(oldReg).when(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class), ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java:        inOrder.verify(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class), ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java:        inOrder.verify(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class), ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java:        verify(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class), ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/BasicRpcTestProvider.java:        rpcRegistration = rpcProviderRegistry.registerRpcImplementation(BasicRpcTestService.class, this); ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/CarProvider.java:        regs.add(rpcProviderService.registerRpcImplementation(CarService.class, this)); ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/MdsalLowLevelTestProvider.java:        registration = rpcRegistry.registerRpcImplementation(OdlMdsalLowlevelControlService.class, this); ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/PeopleProvider.java:                regs.add(rpcProviderService.registerRpcImplementation(CarPurchaseService.class, rpcImplementation, ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/PeopleProvider.java:        regs.add(rpcProviderService.registerRpcImplementation(CarPurchaseService.class, rpcImplementation)); ./controller/opendaylight/md-sal/samples/toaster-provider/src/main/java/org/opendaylight/controller/sample/toaster/provider/OpendaylightToaster.java:        reg = rpcProviderService.registerRpcImplementation(ToasterService.class, this); </pre> </div></div> <p>Convert them to yang.binding.Rpc-based implementations.</p> CONTROLLER-2085

Do not use RpcService in Controller components

Task Medium Resolved Done Oleksandr Zharov Robert Varga pt Thu, 3 Aug 2023 09:14:07 +0000 Mon, 15 Jan 2024 23:44:12 +0000 Mon, 15 Jan 2024 23:43:23 +0000 9.0.0 0 2 <p>Following components require refactoring to eliminate direct usage of <tt>RpcService</tt> incl <tt>RpcConsumerRegistry.getRpcService(Class&lt;? extends RpcService&gt;)</tt>:</p> <ul> <li>blueprint</li> </ul> <ul> <li>clustering-it-karaf-cli (karaf-cli)</li> </ul> <ul> <li>rpcbenchmark</li> </ul> <ul> <li>sal-binding-it</li> </ul> <ul> <li>sal-cluster-admin-karaf-cli</li> </ul> <p>Also needs:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[ERROR] /home/nite/odl/controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/impl/YnlListener.java:[16,105] cannot find symbol [ERROR] symbol: class OdlMdsalLowlevelTargetListener [ERROR] location: package org.opendaylight.yang.gen.v1.tag.opendaylight.org._2017.controller.yang.lowlevel.target.rev170215 </pre> </div></div> Blocks MDSAL-772 Issue split CONTROLLER-2090 Development Rank 0|i0463b: