https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-28 controller <p>The following data types used in the ODL code base for the Flow class seem incorrect looking at what is required by the OF1.0.0 standard. Any boundary tests will fail using these data types. </p> <p>Field ODL Data Type ODL Range OF 1.0.0 Data Type OF 1.0.0 Range<br/> idle_timeout short -32767 to +32767 uint16_t 0 to +65535<br/> hard_timeout short -32767 to +32767 uint16_t 0 to +65535<br/> priority short -32767 to +32767 uint16_t 0 to +65535</p> <p>I see the same data types used in the SAL as well as the plugin layer for these fields. The fix for this needs to be done to both these data structures. A probable solution could be to move to the java int, in spite of its known costs.</p> <p>Operating System: All<br/> Platform: All</p> CONTROLLER-28

Incorrect data types for certain Flow attributes

Bug Resolved Won't Do Unassigned Tejas Nevrekar Tue, 20 Aug 2013 08:25:19 +0000 Wed, 17 Jun 2020 17:15:20 +0000 Thu, 19 May 2016 18:27:46 +0000 0.4.0 adsal 0 4 <p>Attachment OF1.0.0_Sec5.3.3_FlowFields.png has been added with description: OF1.0.0 Sec 5.3.3 for Flow fields</p> <p>Can you tell me the steps to reproduce errors in reference to boundary tests.</p> <p>As unsigned primitive data types are not supported in java,as solution we can use 'int' in place of 'short'.But the change will have impact on other modules. Moreover , i found that there are other variables such as 'table_id'in FlowOnNode.java in package org.opendaylight.controller.sal.reader;</p> <p>Field ODL Data Type ODL Range OF 1.0.0 Data Type OF 1.0.0 Range<br/> table_id byte -127 to 127 uint8_t 0 to +255</p> <p>Will this also fail the boundary tests? What are the expected changes according to you?</p> <p>Google Guava provides unsigned types implementation, also other approach is to use larger types /eg. java.int for uint16, long for uint32 and do the range checks.</p> <p>Accidentally closed, reopening.</p> <p>The Openflow library provides for such conversion classes. The OFFlowMod may be updated as follows:</p> <p>1. Change all short to int for command, idleTimeout, hardTimeout, priority, bufferId, outPort, flags<br/> 2. Update the readFrom writeTo methods<br/> @Override<br/> public void readFrom(ChannelBuffer data) </p> { super.readFrom(data); if (this.match == null) this.match = new OFMatch(); this.match.readFrom(data); this.cookie = data.readLong(); this.command = U16.f(data.readShort()); this.idleTimeout = U16.f(data.readShort()); this.hardTimeout = U16.f(data.readShort()); this.priority = U16.f(data.readShort()); this.bufferId = data.readInt(); this.outPort = U16.f(data.readShort()); this.flags = U16.f(data.readShort()); if (this.actionFactory == null) throw new RuntimeException("OFActionFactory not set"); this.actions = this.actionFactory.parseActions(data, getLengthU() - MINIMUM_LENGTH); } <p> @Override<br/> public void writeTo(ChannelBuffer data) {<br/> super.writeTo(data);<br/> this.match.writeTo(data);<br/> data.writeLong(cookie);<br/> data.writeShort(U16.t(command));<br/> data.writeShort(U16.t(idleTimeout));<br/> data.writeShort(U16.t(hardTimeout));<br/> data.writeShort(U16.t(priority));<br/> data.writeInt(bufferId);<br/> data.writeShort(U16.t(outPort));<br/> data.writeShort(U16.t(flags));<br/> if (actions != null) {<br/> for (OFAction action : actions) </p> { action.writeTo(data); } <p> }<br/> }</p> <p>3. Update the data types for Flow to be int for these variables.</p> <p>This bug is part of the project to Move all ADSAL associated component bugs to ADSAL</p> <p>AD-SAL has been removed, this issue will not be fixed.</p> Development External issue ID 57 External issue URL Rank 0|i02hvb: