[CONTROLLER-317] NETCONF client fails to detect commit failure

Blocks — Tue, 25 Jul 2023 08:23:29 +0000

When configuring a router using RESTCONF to NETCONF ODL does the following on the router:

1) get-config
2) edit-config
3) commit

if the RESTCONF API user attempts e.g. to apply a non-existent ACL to an interface then the commit will fail. However ODL fails to detect this. As far as I know the router is returning a failure code to ODL.

The problem we then have is that the NETCONF session now has outstanding incorrect configs which have not been rolled back. So any future RESTCONF PUTs will fail - even if they are valid.

even with "TRACE" logging on the netconf client all I see on the commit is:

2014-04-14 10:00:31.866 BST [http-bio-8080-exec-6] DEBUG o.o.c.s.c.n.NetconfDevice#xrvr-a - Send message <rpc message-id="m-11" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
<commit/>
</rpc>

2014-04-14 10:00:31.866 BST [http-bio-8080-exec-6] DEBUG o.o.c.n.c.SimpleNetconfClientSessionListener - Sending message org.opendaylight.controller.netconf.api.NetconfMessage@154555a0
2014-04-14 10:00:31.892 BST [nettyThreadgroupModule$NioEventLoopGroupCloseable-9-1] DEBUG o.o.c.n.c.SimpleNetconfClientSessionListener - New message arrived: org.opendaylight.controller.netconf.api.NetconfMessage@7af88648
2014-04-14 10:00:31.892 BST [http-bio-8080-exec-6] DEBUG o.o.c.netconf.client.NetconfClient - Total time spent waiting for response from i2ss-yuma1.cisco.com/172.23.29.116:830: 26 ms

OpenDaylight JIRA

[CONTROLLER-317] NETCONF client fails to detect commit failure