[CONTROLLER-331] toaster:make-toast RPC allows invalid ToastType

Tue, 25 Jul 2023 08:23:31 +0000

While invoking make-toast RPC, I specified an incorrect toasterToastType, ie "wheat-toast" instead of "wheat-bread":

{
"toaster:input" :

{ "toaster:toasterDoneness" : "3", "toaster:toasterToastType" : "wheat-toast" }

}

It got into the OpendaylightToaster.makeToast method fine although it threw an NPE because toastType was null. However since the toast type was invalid it should have been caught earlier and an exception thrown. The transformation from DOM input to MakeToastInput is done in a BindingCodec class that is generated on-the-fly from the MakeToastInput interface. The generated code actually calls LazyGeneratedCodecRegistry::IdentityCompositeCodec.deserialize which looks up the given "wheat-toast" qname in the qnamesToIdentityMap and just returns null if not found. It seems this method should throw an IllegalArgumentEx.

OpenDaylight JIRA

[CONTROLLER-331] toaster:make-toast RPC allows invalid ToastType