https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-398 controller <p>Encountering NPE when calling getOriginalOperationalSubtree() in a registered org.opendaylight.controller.sal.binding.api.data.DataChangeListener.</p> <p>Expected: return null.</p> <p>Sample code:</p> <p>registration:<br/> dataBrokerService.registerDataChangeListener(reportedLspId, new DataChangeListener());</p> <p>DataChangeListener:<br/> public void onDataChanged(DataChangeEvent&lt;InstanceIdentifier&lt;?&gt;, DataObject&gt; change) </p> { originalLsp = (ReportedLsp) change.getOriginalOperationalSubtree(); updatedLsp = (ReportedLsp) change.getUpdatedOperationalSubtree(); } <p>Full stack trace:</p> <p>java.lang.NullPointerException: null<br/> at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizer.toLegacySimple(DataNormalizer.java:159) ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizer.toLegacy(DataNormalizer.java:154) ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at org.opendaylight.controller.md.sal.binding.impl.BindingToNormalizedNodeCodec.toBinding(BindingToNormalizedNodeCodec.java:106) ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at org.opendaylight.controller.md.sal.binding.impl.AbstractForwardedDataBroker.toBindingData(AbstractForwardedDataBroker.java:128) ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at org.opendaylight.controller.md.sal.binding.impl.AbstractForwardedDataBroker$TranslatedDataChangeEvent.getOriginalSubtree(AbstractForwardedDataBroker.java:210) ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at org.opendaylight.controller.md.sal.binding.impl.AbstractForwardedDataBroker$TranslatedDataChangeEvent.getOriginalSubtree(AbstractForwardedDataBroker.java:155) ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at org.opendaylight.controller.md.sal.binding.impl.LegacyDataChangeEvent$OperationalChangeEvent.getOriginalOperationalSubtree(LegacyDataChangeEvent.java:118) ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at org.opendaylight.controller.md.sal.binding.impl.LegacyDataChangeEvent$OperationalChangeEvent.getOriginalOperationalSubtree(LegacyDataChangeEvent.java:96) ~<span class="error">&#91;bundlefile:na&#93;</span></p> <p>Operating System: Linux<br/> Platform: PC</p> CONTROLLER-398

NPE at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizer.toLegacySimple

Bug Resolved Done Tony Tkacik Valentin Mayamsin Fri, 25 Apr 2014 16:30:41 +0000 Tue, 25 Jul 2023 08:23:38 +0000 Mon, 12 May 2014 16:36:22 +0000 mdsal 0 4 <p>Version:</p> <p>org.opendaylight.controller.version = 0.1<br/> org.opendaylight.controller.build.scm.version = 832327e85f47db63006e9bd6115ea85104124f4f<br/> org.opendaylight.controller.build.user = jenkins-controller<br/> org.opendaylight.controller.build.workspace = **********<br/> org.opendaylight.controller.build.timestamp = 1398341431797<br/> org.opendaylight.controller.build.machine = **********</p> <p>To reproduce:</p> <p>1. Create an LSP with NetworkTopologyPcepService.addLsp()<br/> 2. Subscribe to it with DataBrokerService.registerDataChangeListener(id, listener) where id is:<br/> InstanceIdentifier.builder(NetworkTopology.class)<br/> .child(Topology.class, new TopologyKey(new TopologyId(topologyId)))<br/> .child(Node.class, new NodeKey(new NodeId(nodeId)))<br/> .augmentation(Node1.class)<br/> .child(PathComputationClient.class)<br/> .child(ReportedLsp.class, new ReportedLspKey(lspName));</p> <p>3. listener is:<br/> public void onDataChanged(DataChangeEvent&lt;InstanceIdentifier&lt;?&gt;, DataObject&gt; change) {<br/> ReportedLsp originalLsp = null;<br/> ReportedLsp updatedLsp = null;<br/> originalLsp = (ReportedLsp) change.getOriginalOperationalSubtree();<br/> updatedLsp = (ReportedLsp) change.getUpdatedOperationalSubtree();</p> <p>4. First message you'll receive will trigger NPE</p> <p>Thanks Valentin.</p> <p>Which distribution did you run the controller, when you faced this issue?</p> <p>Fedora release 18 (Spherical Cow)</p> <p>No I mean, did you run the controller from controller distribution or openflowplugin or integration or service provider distribution?</p> <p>This is special build for Cisco. What specifically are you interested in?</p> <p>Proposed fix which explicitly tests if before / after subtree image <br/> is available.</p> <p><a href="https://git.opendaylight.org/gerrit/6740" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/6740</a></p> Development External issue ID 849 External issue URL Rank 0|i02k5j: