OpenDaylight JIRA

OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us

8.20.10

820010

22-06-2022

[CONTROLLER-511] Migrate sal-rest-connector to Async Data Broker API https://jira.opendaylight.org/browse/CONTROLLER-511 controller Operating System: Windows Platform: PC CONTROLLER-511

Migrate sal-rest-connector to Async Data Broker API

Improvement Resolved Done Jozef Gloncak Tony Tkacik Tue, 27 May 2014 17:36:32 +0000 Tue, 14 Nov 2017 15:18:00 +0000 Mon, 4 Aug 2014 08:19:19 +0000 Helium mdsal Thu, 31 Jul 2014 00:00:00 +0000 0 4 relates with <a href="https://jira.opendaylight.org/browse/CONTROLLER-242" title="Normalized node structure in restconf" class="issue-link" data-issue-key="CONTROLLER-242"><del>CONTROLLER-242</del></a> Question 1: BrokerFacade - what class should be used for manipulating with datastore? Currently I am using DOMDataBroker but I am not sure if it is correct. Question 2: BrokerFacade - what class should be used for manipulating with datastore when data are behind mountpoint? Question 3: BrokerFacade - invokeRpc method calls ConsumerSession.rpc() which has input parameter of type CompositeNode. What should be used instead? Problem 1: yang-data-composite-node artifact does't contain class which is able to parse and serialize anyxml nodes. This change is based on: <ul class="alternate" type="square"> <li><a href="https://git.opendaylight.org/gerrit/#/c/8660" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8660</a> - yang-data-composite-node fix (+ conversion to bundle)</li> <li><a href="https://git.opendaylight.org/gerrit/#/c/8723/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8723/</a> - add yang-data-composite-node bundle to ODL distribution (currently it is submitted like draft because change #8660 isn't merged yet.</li> </ul> PROBLEM 2: POST <a href="http://localhost:8080/restconf/config" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config</a> with data '<nodes xmlns="urn:opendaylight:inventory"> <node xmlns="urn:opendaylight:inventory"> <id>1</id> <table xmlns="urn:opendaylight:flow:inventory"> <id>2</id> <flow> <id>flow21</id> </flow> <flow> <id>flow22</id> </flow> </table> </node> </nodes>' then results of various GET: <ul class="alternate" type="square"> <li><a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes</a> - OK</li> <li><a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1</a> - OK</li> <li><a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1/table/2" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1/table/2</a> - WRONG <?xml version="1.0" encoding="UTF-8" standalone="no"?> <errors xmlns="urn:ietf:params:xml:ns:yang:ietf-restconf"> <error> <error-type>application</error-type> <error-tag>data-missing</error-tag> <error-message>No data was found.</error-message> </error> </errors></li> </ul> Is this behaviour correct? >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Gradually inserting: <ul class="alternate" type="square"> <li><nodes></nodes></li> <li><node><id>1</id></node></li> <li><table><id>2</id></table> ....</li> </ul> (In reply to Jozef Gloncak from comment #4) > PROBLEM 2: > > POST <a href="http://localhost:8080/restconf/config" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config</a> with data > '<nodes xmlns="urn:opendaylight:inventory"> > <node xmlns="urn:opendaylight:inventory"> > <id>1</id> > <table xmlns="urn:opendaylight:flow:inventory"> > <id>2</id> > <flow> > <id>flow21</id> > </flow> > <flow> > <id>flow22</id> > </flow> > </table> > </node> > </nodes>' > > then results of various GET: > - <a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes</a> - OK > - <a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1</a> > - OK > - > <a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1/" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1/</a> > table/2 - WRONG > <?xml version="1.0" encoding="UTF-8" standalone="no"?> > <errors xmlns="urn:ietf:params:xml:ns:yang:ietf-restconf"> > <error> > <error-type>application</error-type> > <error-tag>data-missing</error-tag> > <error-message>No data was found.</error-message> > </error> > </errors> > > Is this behaviour correct? when data are inserted gradually <ul class="alternate" type="square"> <li><nodes></nodes></li> <li><node><id>1</id></node></li> <li><table><id>2</id></table> ....</li> </ul> then all of this GET are OK <ul class="alternate" type="square"> <li><a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes</a> - OK</li> <li><a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1</a> - OK</li> <li><a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1/table/2" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1/table/2</a> - OK</li> <li><a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1/table/2/flow/flow21" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1/table/2/flow/flow21</a> - OK</li> <li><a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1/table/2/flow/flow22" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1/table/2/flow/flow22</a> - OK</li> </ul> PROBLEM 3: I also POST <a href="http://localhost:8080/restconf/config/" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/</a> data '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <nodes xmlns="urn:opendaylight:inventory"> <node> <id>3</id> </node> <node> <id>1</id> </node> <node> <id>2</id> </node> </nodes>' then I wanted to PUT (rewrite only node with ID 1 so I constructed PUT <a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes/node/1</a> <node xmlns="urn:opendaylight:inventory"> <id>1</id> </node> but the result of GET <a href="http://localhost:8080/restconf/config/opendaylight-inventory:nodes" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/config/opendaylight-inventory:nodes</a> was <?xml version="1.0" encoding="UTF-8" standalone="no"?> <nodes xmlns="urn:opendaylight:inventory"> <node> <id>1</id> </node> </nodes> (nodes 2 and 3 were lost) Question 4: How should be info about concrete "scope" and "datastore" for which should be stream (.../restconf/streams/stream/...) send to handling method? Current state is via parameters in URI ("datastore", "scope"), where for defaults values: <ul class="alternate" type="square"> <li>datastore=CONFIGURATION (other values: OPERATIONAL)</li> <li>scope=BASE (other values: ONE, SUBTREE)</li> </ul> (In reply to Jozef Gloncak from comment #7) > Question 4: > How should be info about concrete "scope" and "datastore" for which should > be stream (.../restconf/streams/stream/...) send to handling method? > > Current state is via parameters in URI ("datastore", "scope"), where for > defaults values: > - datastore=CONFIGURATION (other values: OPERATIONAL) > - scope=BASE (other values: ONE, SUBTREE) In patch set 5 it was changed as follows: 1) creating listener POST <a href="http://localhost:8080/restconf/operations/sal-remote:create-data-change-event-subscription" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/operations/sal-remote:create-data-change-event-subscription</a> with data <input xmlns="urn:opendaylight:params:xml:ns:yang:controller:md:sal:remote"> <path xmlns:a="urn:opendaylight:inventory">/a:nodes</path> <datastore xmlns="urn:sal:restconf:event:subscription">OPERATIONAL</datastore> <scope xmlns="urn:sal:restconf:event:subscription">BASE</scope> </input> has output <?xml version="1.0" encoding="UTF-8" standalone="no"?> <output xmlns="urn:opendaylight:params:xml:ns:yang:controller:md:sal:remote"> <stream-name>opendaylight-inventory:nodes/datastore=OPERATIONAL/scope=BASE</stream-name> </output> 2) registration to listen data changes GET <a href="http://localhost:8080/restconf/streams/stream/opendaylight-inventory:nodes/datastore=OPERATIONAL/scope=BASE" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8080/restconf/streams/stream/opendaylight-inventory:nodes/datastore=OPERATIONAL/scope=BASE</a> which returns location in header: <a href="http://localhost:8181/opendaylight-inventory:nodes/datastore=OPERATIONAL/scope=BASE" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/opendaylight-inventory:nodes/datastore=OPERATIONAL/scope=BASE</a> (In reply to Jozef Gloncak from comment #3) > This change is based on: > - <a href="https://git.opendaylight.org/gerrit/#/c/8660" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8660</a> - yang-data-composite-node > fix (+ conversion to bundle) > - <a href="https://git.opendaylight.org/gerrit/#/c/8723/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8723/</a> - add > yang-data-composite-node bundle to ODL distribution (currently it is > submitted like draft because change #8660 isn't merged yet. Additional patch set which are necessary fot <a href="https://jira.opendaylight.org/browse/CONTROLLER-511" title="Migrate sal-rest-connector to Async Data Broker API" class="issue-link" data-issue-key="CONTROLLER-511"><del>CONTROLLER-511</del></a> <a href="https://git.opendaylight.org/gerrit/#/c/8931/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8931/</a> - Support for AnyXml yang type to yang-data-composite-node <a href="https://git.opendaylight.org/gerrit/#/c/8930/2" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8930/2</a> - Add AnyXmlNodeBase parser and serializer Patch set 6 is available <a href="https://git.opendaylight.org/gerrit/#/c/8457/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8457/</a> to Question 3: it probably isn't necessary to translate composite node to normalized node when invoking rpc because no interaction with datastore. Should be confirmed!!! patch set 10 <a href="https://git.opendaylight.org/gerrit/#/c/8457/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8457/</a> patch set 11 <a href="https://git.opendaylight.org/gerrit/#/c/8457/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8457/</a> (removed comments for RestConnectorModule.java and RestConnectorModuleFactory.java) Blocks CONTROLLER-257 CONTROLLER-547 Development External issue ID 1082 External issue URL ODL SR Target Milestone Rank 0|i02kun: