https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-587 controller <p>On MacOS 10.9.3 (verified on 3 machines) with Java 1.7, the DataNormalizerTest fails because the comparator provided in verifyLegacyNode() does not actually provide a total ordering of the childData and childNodes.</p> <p>It appears as though Windows and Linux are immune.</p> <p>This results in a build failure for sal-common-impl that looks like this:</p> <p>-------------------------------------------------------<br/> T E S T S<br/> -------------------------------------------------------<br/> Running org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest<br/> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".<br/> SLF4J: Defaulting to no-operation (NOP) logger implementation<br/> SLF4J: See <a href="http://www.slf4j.org/codes.html#StaticLoggerBinder" class="external-link" target="_blank" rel="nofollow noopener">http://www.slf4j.org/codes.html#StaticLoggerBinder</a> for further details.<br/> Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.892 sec &lt;&lt;&lt; FAILURE! - in org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest<br/> testToLegacyNormalizedNode(org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest) Time elapsed: 0.068 sec &lt;&lt;&lt; FAILURE!<br/> java.lang.AssertionError: Child node QName expected:&lt;(urn:opendaylight:params:xml:ns:yang:controller:md:sal:normalization:test?revision=2014-03-13)inner-list&gt; but was:&lt;(urn:opendaylight:params:xml:ns:yang:controller:md:sal:normalization:test?revision=2014-03-13)id&gt;<br/> at org.junit.Assert.fail(Assert.java:91)<br/> at org.junit.Assert.failNotEquals(Assert.java:645)<br/> at org.junit.Assert.assertEquals(Assert.java:126)<br/> at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest.verifyLegacyNode(DataNormalizerTest.java:437)<br/> at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest.verifyLegacyNode(DataNormalizerTest.java:441)<br/> at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest.testToLegacyNormalizedNode(DataNormalizerTest.java:245)</p> <p>Operating System: Mac OS<br/> Platform: Macintosh</p> CONTROLLER-587

Heisenbug in DataNormalizerTest

Bug Resolved Done Colin Dixon Colin Dixon Sun, 29 Jun 2014 20:01:13 +0000 Tue, 25 Jul 2023 08:23:57 +0000 Thu, 3 Jul 2014 18:23:58 +0000 mdsal 0 3 <p>This boils down that test expects ordering from HashMap (hashMap ordering<br/> is pseudo-random and depends on previously allocated HashMap and their seeds).</p> <p>Implementation of verify for composite nodes, assumes ordering even for elements<br/> which are marked unordered (and uses hashmap in background)</p> <p>Easy way to replicate this bug is just to modify QName#hashCode() to return 0 for hashCode.</p> <p>I created a partial (complete for the current unit tests) patch for this last night:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/8439/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8439/</a></p> <p>Since the code was in a Unit test and the submitted fix will generate exceptions if the assumptions it makes are violated, I've marked this as fixed since I don't think it could regress without failing in the verify stage.</p> Development External issue ID 1256 External issue URL Rank 0|i02lbj: