https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-879 controller <p>osgi&gt; 2014-09-22 09:40:01.399 EDT <span class="error">&#91;md-sal-binding-notification-48&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:NORMAL<br/> 2014-09-22 09:40:01.399 EDT <span class="error">&#91;md-sal-binding-notification-48&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:CONTROLLER<br/> 2014-09-22 09:40:01.894 EDT <span class="error">&#91;md-sal-binding-notification-36&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:76:52:0a:ea:13:48 with nodeConnectorUri: OF:130094742508360:CONTROLLER<br/> 2014-09-22 09:40:02.113 EDT <span class="error">&#91;md-sal-binding-notification-66&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:c2:6c:bd:cf:3e:4b with nodeConnectorUri: OF:213772296732235:CONTROLLER<br/> 2014-09-22 09:40:03.025 EDT <span class="error">&#91;md-sal-binding-notification-56&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:ee:f1:fa:f6:eb:41 with nodeConnectorUri: OF:262723065015105:CONTROLLER<br/> 2014-09-22 09:40:16.387 EDT <span class="error">&#91;md-sal-binding-notification-42&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:NORMAL<br/> 2014-09-22 09:40:16.393 EDT <span class="error">&#91;md-sal-binding-notification-42&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:CONTROLLER<br/> 2014-09-22 09:40:16.895 EDT <span class="error">&#91;md-sal-binding-notification-46&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:76:52:0a:ea:13:48 with nodeConnectorUri: OF:130094742508360:CONTROLLER<br/> 2014-09-22 09:40:17.112 EDT <span class="error">&#91;md-sal-binding-notification-37&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:c2:6c:bd:cf:3e:4b with nodeConnectorUri: OF:213772296732235:CONTROLLER<br/> 2014-09-22 09:40:17.973 EDT <span class="error">&#91;md-sal-binding-notification-65&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:ee:f1:fa:f6:eb:41 with nodeConnectorUri: OF:262723065015105:CONTROLLER<br/> 2014-09-22 09:40:31.399 EDT <span class="error">&#91;md-sal-binding-notification-50&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:NORMAL<br/> 2014-09-22 09:40:31.399 EDT <span class="error">&#91;md-sal-binding-notification-50&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:CONTROLLER<br/> 2014-09-22 09:40:31.896 EDT <span class="error">&#91;md-sal-binding-notification-59&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:76:52:0a:ea:13:48 with nodeConnectorUri: OF:130094742508360:CONTROLLER<br/> 2014-09-22 09:40:32.112 EDT <span class="error">&#91;md-sal-binding-notification-33&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:c2:6c:bd:cf:3e:4b with nodeConnectorUri: OF:213772296732235:CONTROLLER<br/> 2014-09-22 09:40:32.978 EDT <span class="error">&#91;md-sal-binding-notification-41&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:ee:f1:fa:f6:eb:41 with nodeConnectorUri: OF:262723065015105:CONTROLLER<br/> 2014-09-22 09:40:46.386 EDT <span class="error">&#91;md-sal-binding-notification-35&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:NORMAL<br/> 2014-09-22 09:40:46.386 EDT <span class="error">&#91;md-sal-binding-notification-35&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:CONTROLLER<br/> 2014-09-22 09:40:46.899 EDT <span class="error">&#91;md-sal-binding-notification-47&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:76:52:0a:ea:13:48 with nodeConnectorUri: OF:130094742508360:CONTROLLER<br/> 2014-09-22 09:40:47.087 EDT <span class="error">&#91;md-sal-binding-notification-44&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:c2:6c:bd:cf:3e:4b with nodeConnectorUri: OF:213772296732235:CONTROLLER<br/> 2014-09-22 09:40:47.970 EDT <span class="error">&#91;md-sal-binding-notification-57&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:ee:f1:fa:f6:eb:41 with nodeConnectorUri: OF:262723065015105:CONTROLLER<br/> 2014-09-22 09:41:01.384 EDT <span class="error">&#91;md-sal-binding-notification-40&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:NORMAL<br/> 2014-09-22 09:41:01.384 EDT <span class="error">&#91;md-sal-binding-notification-40&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:CONTROLLER<br/> 2014-09-22 09:41:01.899 EDT <span class="error">&#91;md-sal-binding-notification-39&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:76:52:0a:ea:13:48 with nodeConnectorUri: OF:130094742508360:CONTROLLER<br/> 2014-09-22 09:41:02.075 EDT <span class="error">&#91;md-sal-binding-notification-61&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:c2:6c:bd:cf:3e:4b with nodeConnectorUri: OF:213772296732235:CONTROLLER<br/> 2014-09-22 09:41:02.967 EDT <span class="error">&#91;md-sal-binding-notification-38&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:ee:f1:fa:f6:eb:41 with nodeConnectorUri: OF:262723065015105:CONTROLLER<br/> 2014-09-22 09:41:16.381 EDT <span class="error">&#91;md-sal-binding-notification-52&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:NORMAL<br/> 2014-09-22 09:41:16.381 EDT <span class="error">&#91;md-sal-binding-notification-52&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:CONTROLLER<br/> 2014-09-22 09:41:16.899 EDT <span class="error">&#91;md-sal-binding-notification-58&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:76:52:0a:ea:13:48 with nodeConnectorUri: OF:130094742508360:CONTROLLER<br/> 2014-09-22 09:41:17.067 EDT <span class="error">&#91;md-sal-binding-notification-60&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:c2:6c:bd:cf:3e:4b with nodeConnectorUri: OF:213772296732235:CONTROLLER<br/> 2014-09-22 09:41:17.960 EDT <span class="error">&#91;md-sal-binding-notification-51&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:ee:f1:fa:f6:eb:41 with nodeConnectorUri: OF:262723065015105:CONTROLLER<br/> 2014-09-22 09:41:31.375 EDT <span class="error">&#91;md-sal-binding-notification-36&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:NORMAL<br/> 2014-09-22 09:41:31.375 EDT <span class="error">&#91;md-sal-binding-notification-36&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:62:07:3e:b5:35:43 with nodeConnectorUri: OF:107783256356163:CONTROLLER<br/> 2014-09-22 09:41:31.904 EDT <span class="error">&#91;md-sal-binding-notification-42&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:76:52:0a:ea:13:48 with nodeConnectorUri: OF:130094742508360:CONTROLLER<br/> 2014-09-22 09:41:32.072 EDT <span class="error">&#91;md-sal-binding-notification-55&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:c2:6c:bd:cf:3e:4b with nodeConnectorUri: OF:213772296732235:CONTROLLER<br/> 2014-09-22 09:41:32.966 EDT <span class="error">&#91;md-sal-binding-notification-63&#93;</span> WARN o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:ee:f1:fa:f6:eb:41 with nodeConnectorUri: OF:262723065015105:CONTROLLER</p> <p>Operating System: All<br/> Platform: All</p> CONTROLLER-879

Continuous WARN logs in o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:xx:xx:xx:xx:xx:xx with nodeConnectorUri: OF:213772296732235:CONTROLLER

Bug Resolved Done Flavio Fernandes Flavio Fernandes Mon, 22 Sep 2014 13:44:14 +0000 Tue, 25 Jul 2023 08:24:11 +0000 Sat, 15 Nov 2014 15:27:38 +0000 mdsal 0 8 <p>Exception details: </p> <p>org.opendaylight.controller.sal.core.ConstructionException: Type of incoming object:class java.lang.String not compatible with expected type:class java.lang.Short or Node type incompatible:OF</p> <p>"md-sal-binding-notification-199@13469" daemon prio=5 tid=0x2ff nid=NA runnable<br/> java.lang.Thread.State: RUNNABLE<br/> at org.opendaylight.controller.sal.compatibility.ToSalConversionsUtils.fromNodeConnectorRef(ToSalConversionsUtils.java:377)<br/> at org.opendaylight.controller.sal.compatibility.ToSalConversionsUtils.actionFrom(ToSalConversionsUtils.java:212)<br/> at org.opendaylight.controller.sal.compatibility.ToSalConversionsUtils.toFlow(ToSalConversionsUtils.java:142)<br/> at org.opendaylight.controller.sal.compatibility.InventoryAndReadAdapter.toFlowOnNode(InventoryAndReadAdapter.java:702)<br/> at org.opendaylight.controller.sal.compatibility.InventoryAndReadAdapter.onFlowsStatisticsUpdate(InventoryAndReadAdapter.java:625)<br/> at org.opendaylight.controller.sal.compatibility.InventoryAndReadAdapter$$Broker$ListenerInvoker.onNotification(InventoryAndReadAdapter$$Broker$ListenerInvoker.java:-1)<br/> at org.opendaylight.controller.sal.binding.impl.AbstractNotificationListenerRegistration.notify(AbstractNotificationListenerRegistration.java:38)<br/> at org.opendaylight.controller.sal.binding.impl.NotifyTask.run(NotifyTask.java:42)<br/> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)<br/> at java.util.concurrent.FutureTask.run(FutureTask.java:262)<br/> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)<br/> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)<br/> at java.lang.Thread.run(Thread.java:745)</p> <p>Info on where exception takes place: <br/> <a href="https://www.dropbox.com/s/z0gmcws4ypt1pn1/Screenshot%202014-09-22%2013.21.26.png?dl=0" class="external-link" target="_blank" rel="nofollow noopener">https://www.dropbox.com/s/z0gmcws4ypt1pn1/Screenshot%202014-09-22%2013.21.26.png?dl=0</a></p> <p><span class="error">&#91;14:06:23&#93;</span> &lt;flaviof&gt; hi edwarnicke. can you tell me who is a good person to talk about this piece of code: <a href="https://www.dropbox.com/s/prdhresrdcfcyv5/Screenshot%202014-09-22%2014.03.46.png?dl=0" class="external-link" target="_blank" rel="nofollow noopener">https://www.dropbox.com/s/prdhresrdcfcyv5/Screenshot%202014-09-22%2014.03.46.png?dl=0</a> ?<br/> <span class="error">&#91;14:06:52&#93;</span> &lt;flaviof&gt; edwarnicke: looking at <a href="https://jira.opendaylight.org/browse/CONTROLLER-879" title="Continuous WARN logs in o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:xx:xx:xx:xx:xx:xx with nodeConnectorUri: OF:213772296732235:CONTROLLER" class="issue-link" data-issue-key="CONTROLLER-879"><del>CONTROLLER-879</del></a>...<br/> <span class="error">&#91;14:07:08&#93;</span> &lt;edwarnicke&gt; flaviof: Which file?<br/> <span class="error">&#91;14:07:41&#93;</span> &lt;flaviof&gt; edwarnicke: /org/opendaylight/controller/sal/0.8.1-SNAPSHOT/sal-0.8.1-20140922.073911-1029.jar!/org/opendaylight/controller/sal/core/NodeConnector.class<br/> <span class="error">&#91;14:08:11&#93;</span> &lt;edwarnicke&gt; flaviof: Talk to Madhu<br/> <span class="error">&#91;14:08:29&#93;</span> &lt;flaviof&gt; edwarnicke: ha.. ez enough. <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/> ty!</p> <p>I would like to assert that I apparently was delusional when I told flavio to talk to Madhu about this bug.</p> <p>Not a Fix: <a href="https://git.opendaylight.org/gerrit/#/c/11497/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/11497/</a></p> <p>Makes the logging clearer on what just happened. From the logs below, it looks like someone wrote a flow with a NodeConnectorId of OF:107783256356163:NORMAL... since this doesn't match the format OFplugin uses, our converters are failing (and there's no way they couldn't).</p> <p>It <b>looks</b> like someone is writing invalid flows... but I could be wrong.</p> <p>I've hit this comment too and I've chased it into the same region of the code. I too though I was calling something incorrectly. I've spent several hours chasing this and I don't think I'm calling anything incorrectly. The Flow that I think was causing this on my side was created as:</p> <p>(When I see this problem, the node ID is OF:&lt;datapathID&gt;:FLOOD</p> <p> private static Instruction createInstructionApplyActionsFlood(final int order)</p> { final OutputActionBuilder outputActionBuilder = new OutputActionBuilder(); final Uri uri = new Uri("FLOOD"); outputActionBuilder.setOutputNodeConnector(uri); // create an actonBuilder final ActionBuilder actionBuilder = new ActionBuilder(); actionBuilder.setAction(new OutputActionCaseBuilder().setOutputAction(outputActionBuilder.build()).build()); actionBuilder.setOrder(0); actionBuilder.setKey(new ActionKey(0)); // Create an Apply Action final ApplyActionsBuilder applyActionBuilder = new ApplyActionsBuilder(); applyActionBuilder.setAction(ImmutableList.of(actionBuilder.build())); // Wrap our Apply Action in an Instruction final InstructionBuilder instructionBuilder = new InstructionBuilder(); instructionBuilder.setInstruction(new ApplyActionsCaseBuilder().setApplyActions(applyActionBuilder.build()).build()); instructionBuilder.setOrder(order); instructionBuilder.setKey(new InstructionKey(order)); return instructionBuilder.build(); } <p>NOTE: This code comes from one of the code samples that's out there.</p> <p>Jim,</p> <p>Somewhere someone is writing an FlowCapable Node with MD-SAL NodeID of 'OF:107783256356163:CONTROLLER' etc. Thats an AD-SAL NodeID, and not an MD-SAL NodeID and thus we have no idea how to translate it (and also no idea how to actually program it meaningfully on a switch).</p> <p>You need to chase this down to where you are missetting the NodeConnectorID for the flow to resolve the issue.</p> <p>I have drilled down to where the issue is located:</p> <p>The function<br/> org.opendaylight.controller.sal.compatibility.<br/> NodeMapping.<br/> toADNodeConnectorId(final NodeConnectorId nodeConnectorId, final NodeId nodeId)</p> <p>Is attempting to detect the special cases and would return SPECIALNODECONNECTORID:</p> <p> if (nodeConnectorId.equals(toLocalNodeConnectorId(nodeId)) ||<br/> nodeConnectorId.equals(toNormalNodeConnectorId(nodeId)) ||<br/> nodeConnectorId.equals(toControllerNodeConnectorId(nodeId))) </p> { return org.opendaylight.controller.sal.core.NodeConnector.SPECIALNODECONNECTORID; } <p>in this case &#8211; however &#8211; the toControllerNodeConnectorId(nodeId) and<br/> nodeConnectorId are different in their NodeIDType section:</p> <p>OF:1234:CONTROLLER<br/> openflow:1234:CONTROLLER</p> <p>Moiz: it looks like you are the one who added the logic to return SPECIALNODECONNECTORID. Can you advise what is the best way of fixing this?</p> <p>I have a simple proposal, but I'm not sure if that is what you would do.</p> <p>&#8211; flavio</p> <p>Links that shows code involved with this issue:</p> <p><a href="https://www.dropbox.com/s/txpb9m5sm2wr7re/Screenshot%202014-11-06%2006.27.41.png?dl=0" class="external-link" target="_blank" rel="nofollow noopener">https://www.dropbox.com/s/txpb9m5sm2wr7re/Screenshot%202014-11-06%2006.27.41.png?dl=0</a></p> <p><a href="https://www.dropbox.com/s/rtyukw4n5ies2tr/Screenshot%202014-11-06%2006.28.08.png?dl=0" class="external-link" target="_blank" rel="nofollow noopener">https://www.dropbox.com/s/rtyukw4n5ies2tr/Screenshot%202014-11-06%2006.28.08.png?dl=0</a></p> <p><a href="https://www.dropbox.com/s/9n2bymnlpqx9vsn/Screenshot%202014-11-06%2006.29.17.png?dl=0" class="external-link" target="_blank" rel="nofollow noopener">https://www.dropbox.com/s/9n2bymnlpqx9vsn/Screenshot%202014-11-06%2006.29.17.png?dl=0</a></p> <p><a href="https://www.dropbox.com/s/hlz3whx7e8n8o1i/Screenshot%202014-11-06%2006.32.51.png?dl=0" class="external-link" target="_blank" rel="nofollow noopener">https://www.dropbox.com/s/hlz3whx7e8n8o1i/Screenshot%202014-11-06%2006.32.51.png?dl=0</a></p> <p><a href="https://www.dropbox.com/s/5o2ztlq373r6wtt/Screenshot%202014-11-06%2006.41.22.png?dl=0" class="external-link" target="_blank" rel="nofollow noopener">https://www.dropbox.com/s/5o2ztlq373r6wtt/Screenshot%202014-11-06%2006.41.22.png?dl=0</a></p> <p>gerrit: <a href="https://git.opendaylight.org/gerrit/#/c/12568/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/12568/</a></p> <p>From: Flavio Fernandes &lt;ffernand@redhat.com&gt;<br/> Subject: update on the proposed changes...<br/> Date: November 6, 2014 at 6:24:23 PM EST<br/> To: "Ed Warnicke (eaw)" &lt;eaw@cisco.com&gt;</p> <p>… it is a no go. <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>by making the changes you mentioned, the Uri became just ‘CONTROLLER’. W/out the 'OF:dpid:’ prefix:</p> <p><a href="https://www.dropbox.com/s/w5veevdft0hqow8/Screenshot%202014-11-06%2018.18.33.png?dl=0" class="external-link" target="_blank" rel="nofollow noopener">https://www.dropbox.com/s/w5veevdft0hqow8/Screenshot%202014-11-06%2018.18.33.png?dl=0</a></p> <p><span class="error">&#91;redhatlaptop:controller.git&#93;</span>$ git diff<br/> diff --git a/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibili<br/> index dcc1a46..7713986 100644<br/> &#8212; a/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibility/ToSa<br/> +++ b/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibility/ToSa<br/> @@ -208,8 +208,8 @@ public class ToSalConversionsUtils {<br/> Uri nodeConnector = ((OutputActionCase) sourceAction).getOutputAction().getOutputNodeConnector();<br/> if (nodeConnector != null) {<br/> //for (Uri uri : nodeConnectors) </p> { - Uri fullNodeConnector = new Uri(node.getType()+":"+node.getID()+":"+nodeConnector.getValue()); - targetAction.add(new Output(fromNodeConnectorRef(fullNodeConnector, node))); + // Uri fullNodeConnector = new Uri(node.getType()+":"+node.getID()+":"+nodeConnector.getValue()); + targetAction.add(new Output(fromNodeConnectorRef(nodeConnector, node))); //} <p> }<br/> } else if (sourceAction instanceof PopMplsActionCase) {</p> <p>so I gotta believe that the ‘node.getType()<ins>":"+node.getID()</ins>”:”’ are very needed. Is this a case where a translator from ‘OF’ to ‘open flow’<br/> is missing?</p> <p>Do you see anything wrong with the gerrit I’m proposing: <a href="https://git.opendaylight.org/gerrit/#/c/12568/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/12568/</a> ?<br/> Martin has actually blessed it...</p> <p>Please advice,</p> <p>— flavio</p> <p>From: Flavio Fernandes &lt;ffernand@redhat.com&gt;<br/> Date: Sat, Nov 8, 2014 at 7:03 AM<br/> Subject: Re: <span class="error">&#91;ovsdb-dev&#93;</span> <a href="https://jira.opendaylight.org/browse/CONTROLLER-879" title="Continuous WARN logs in o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:xx:xx:xx:xx:xx:xx with nodeConnectorUri: OF:213772296732235:CONTROLLER" class="issue-link" data-issue-key="CONTROLLER-879"><del>CONTROLLER-879</del></a> &#8211; Continuous WARN logs in o.o.c.s.c.ToSalConversionsUtils<br/> To: Srini Seetharaman &lt;srini.seetharaman@gmail.com&gt;, "controller-dev@lists.opendaylight.org" &lt;controller-dev@lists.opendaylight.org&gt;<br/> Cc: "Ed Warnicke (eaw)" &lt;eaw@cisco.com&gt;, "Martin Bobak -X (mbobak - Pantheon Technologies SRO at Cisco)" &lt;mbobak@cisco.com&gt;, "Mestery, Kyle" &lt;kyle.mestery@hp.com&gt;, "&lt;ovsdb-dev@lists.opendaylight.org&gt;" &lt;ovsdb-dev@lists.opendaylight.org&gt;, "openflowplugin-dev@lists.opendaylight.org" &lt;dev@lists.opendaylight.org&gt;, Colin Dixon &lt;colin@colindixon.com&gt;</p> <p>On Fri, Nov 7, 2014 at 6:17 PM, Srini Seetharaman<br/> &lt;srini.seetharaman@gmail.com&gt; wrote:<br/> &gt; Hi Ed<br/> &gt; I just created a sample project, and used the sal-compatibility and<br/> &gt; switchmanager. I noticed the errors popped up. I really don't have any<br/> &gt; complex logic except to implement IInventoryListener.<br/> &gt;<br/> &gt; I went through the code and feel this is where the error is coming from.<br/> &gt; Please let me know if this sounds right to you:<br/> &gt;</p> <p>Thanks for this message Srini! Can you share more details on the<br/> sample project you wrote?<br/> I'm curious how this is something that only a few folks see. Contrary<br/> to Ed's suspicion, I<br/> strongly believe this is not related to ovsdb at all. Any code path that uses</p> <p>org.opendaylight.controller.sal.compatibility.InventoryAndReadAdapter.onFlowsStatisticsUpdate(InventoryAndReadAdapter.java:710)</p> <p>will suffer from this. That is so, because<br/> org.opendaylight.controller.sal.compatibility.NodeMapping.toADNode()<br/> uses NodeIDType.OPENFLOW, which<br/> is hard coded as 'OF'.</p> <p>According to InteliJ, there are 153 uses of 'NodeIDType.OPENFLOW'<br/> (public static and not final?!?):<br/> <a href="https://www.dropbox.com/s/gjpma2691c6sahm/Screenshot%202014-11-08%2007.00.21.png?dl=0" class="external-link" target="_blank" rel="nofollow noopener">https://www.dropbox.com/s/gjpma2691c6sahm/Screenshot%202014-11-08%2007.00.21.png?dl=0</a></p> <p>And this is only in the controller repository! I don't know the history of<br/> how 'OF' became 'openflow' in ODL, but that change &#8211; together with<br/> the very open ended nature of the<br/> Uri object &#8211; makes me think this is not the last time issues like<br/> this will occur.</p> <p>So, yes... I think the changes you are proposing would address <a href="https://jira.opendaylight.org/browse/CONTROLLER-879" title="Continuous WARN logs in o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:xx:xx:xx:xx:xx:xx with nodeConnectorUri: OF:213772296732235:CONTROLLER" class="issue-link" data-issue-key="CONTROLLER-879"><del>CONTROLLER-879</del></a>.<br/> I came up with a proposal that would address it too, but instead of<br/> mapping OF to openflow<br/> it simply trims it out:</p> <p> <a href="https://git.opendaylight.org/gerrit/#/c/12568/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/12568/</a></p> <p>It is likely that Ed likes your changes better and I'm <em>very</em> okay<br/> with that. It has been almost 2<br/> months since we opened this issue and I'll be glad when its put to bed. <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/wink.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Best,</p> <p>&#8211; flavio</p> <p>&gt; diff --git<br/> &gt; a/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibility/ToSalConversionsUtils.java<br/> &gt; b/opendaylight/md-sal/compatibility/sal-<br/> &gt; index dcc1a46..4607058 100644<br/> &gt; &#8212;<br/> &gt; a/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibility/ToSalConversionsUtils.java<br/> &gt; +++<br/> &gt; b/opendaylight/md-sal/compatibility/sal-compatibility/src/main/java/org/opendaylight/controller/sal/compatibility/ToSalConversionsUtils.java<br/> &gt; @@ -208,7 +208,7 @@ public class ToSalConversionsUtils {<br/> &gt; Uri nodeConnector = ((OutputActionCase)<br/> &gt; sourceAction).getOutputAction().getOutputNodeConnector();<br/> &gt; if (nodeConnector != null) {<br/> &gt; //for (Uri uri : nodeConnectors) </p> { &gt; - Uri fullNodeConnector = new &gt; Uri(node.getType()+":"+node.getID()+":"+nodeConnector.getValue()); &gt; + Uri fullNodeConnector = new &gt; Uri("openflow:"+node.getID()+":"+nodeConnector.getValue()); &gt; targetAction.add(new &gt; Output(fromNodeConnectorRef(fullNodeConnector, node))); &gt; //} <p>&gt; }<br/> &gt;<br/> &gt;<br/> &gt; On Mon, Nov 3, 2014 at 11:20 AM, Ed Warnicke (eaw) &lt;eaw@cisco.com&gt; wrote:<br/> &gt;&gt;<br/> &gt;&gt; This isn’t an OFplugin or MD-SAL or adaptor issue. Its an app issue.<br/> &gt;&gt;<br/> &gt;&gt;<br/> &gt;&gt; Some app is writing a flow with an invalid NodeConnectorID on the MD-SAL<br/> &gt;&gt; side of:<br/> &gt;&gt;<br/> &gt;&gt; OF:107783256356163:CONTROLLER<br/> &gt;&gt;<br/> &gt;&gt; We can’t translate that correctly <b>from</b> the MD-SAL side to the AD-SAL<br/> &gt;&gt; side because its not an MD-SAL style NodeConnectorID.<br/> &gt;&gt; I also don’t see how it can correctly get programmed on a switch either.<br/> &gt;&gt;<br/> &gt;&gt; This needs to be tracked down in the application code that is doing the<br/> &gt;&gt; programming incorrectly to begin with.<br/> &gt;&gt;<br/> &gt;&gt; I suspect this is a bug in the ovsdb code that is failing to create a<br/> &gt;&gt; correct NodeConnectorId, and thus that’s probably<br/> &gt;&gt; where it should be fixed.<br/> &gt;&gt;<br/> &gt;&gt; Ed<br/> &gt;&gt;<br/> &gt;&gt; On Nov 3, 2014, at 9:20 AM, Colin Dixon &lt;colin@colindixon.com&gt; wrote:<br/> &gt;&gt;<br/> &gt;&gt; Adding a link to the bug:<br/> &gt;&gt; <a href="https://bugs.opendaylight.org/show_bug.cgi?id=2021" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=2021</a><br/> &gt;&gt;<br/> &gt;&gt; And cc'ing openflowplugin-dev.<br/> &gt;&gt;<br/> &gt;&gt; Cheers,<br/> &gt;&gt; --Colin<br/> &gt;&gt;<br/> &gt;&gt;<br/> &gt;&gt; On Mon, Nov 3, 2014 at 9:13 AM, Flavio Fernandes &lt;ffernand@redhat.com&gt;<br/> &gt;&gt; wrote:<br/> &gt;&gt;&gt;<br/> &gt;&gt;&gt; Hello Martin,<br/> &gt;&gt;&gt;<br/> &gt;&gt;&gt; I was wondering if you have any updates on <a href="https://jira.opendaylight.org/browse/CONTROLLER-879" title="Continuous WARN logs in o.o.c.s.c.ToSalConversionsUtils - nodeConnector creation failed at node: OF|00:00:xx:xx:xx:xx:xx:xx with nodeConnectorUri: OF:213772296732235:CONTROLLER" class="issue-link" data-issue-key="CONTROLLER-879"><del>CONTROLLER-879</del></a>. I don’t actually<br/> &gt;&gt;&gt; know why/how it got assigned to you. <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/><br/> &gt;&gt;&gt;<br/> &gt;&gt;&gt; This bug is in Helium and it would be great if we could fix it, because<br/> &gt;&gt;&gt; it makes log very chatty when doing openstack<br/> &gt;&gt;&gt; integration.<br/> &gt;&gt;&gt;<br/> &gt;&gt;&gt; Thanks,<br/> &gt;&gt;&gt;<br/> &gt;&gt;&gt; — flavio<br/> &gt;&gt;&gt;</p> <p>mail thread: <a href="https://lists.opendaylight.org/pipermail/ovsdb-dev/2014-November/000845.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/ovsdb-dev/2014-November/000845.html</a></p> <p>master:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/12568/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/12568/</a></p> <p>stable/helium (SR2):<br/> <a href="https://git.opendaylight.org/gerrit/#/c/12828/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/12828/</a></p> Development External issue ID 2021 External issue URL ODL SR Target Milestone Rank 0|i02n4f: