https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-923 controller <p>The fix to <a href="https://jira.opendaylight.org/browse/CONTROLLER-477" title="Add trailing newline to formatted JSON output" class="issue-link" data-issue-key="CONTROLLER-477"><del>CONTROLLER-477</del></a> introduced URI parameter prettyPrint. The code from <a href="https://git.opendaylight.org/gerrit/#/c/8329" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8329</a> is still there, but since then codecs were moved to yangtools, and logic to detect prettyPrint was not moved properly. This example from gerrit (with new restconf port) thus now fails to result in formatted output:<br/> <a href="http://localhost:8181/restconf/config/opendaylight-inventory:nodes?prettyPrint=true" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/config/opendaylight-inventory:nodes?prettyPrint=true</a></p> <p>Operating System: Linux<br/> Platform: PC</p> CONTROLLER-923

?prettyPrint=true is ignored

Bug Verified Done Jan Hajnar Vratko Polak Mon, 6 Oct 2014 11:31:30 +0000 Tue, 14 Nov 2017 15:18:01 +0000 Tue, 16 Jun 2015 11:25:31 +0000 Helium restconf 0 5 <p><a href="https://jira.opendaylight.org/browse/CONTROLLER-923" title="?prettyPrint=true is ignored" class="issue-link" data-issue-key="CONTROLLER-923"><del>CONTROLLER-923</del></a> - yangtools pretty print for json output<br/> <a href="https://git.opendaylight.org/gerrit/#/c/11937/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/11937/</a></p> <p><a href="https://jira.opendaylight.org/browse/CONTROLLER-923" title="?prettyPrint=true is ignored" class="issue-link" data-issue-key="CONTROLLER-923"><del>CONTROLLER-923</del></a> - sal-rest-connector - integration of prettyPrint URI parameter recognition.<br/> <a href="https://git.opendaylight.org/gerrit/11938" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/11938</a> <span class="error">&#91;DRAFT&#93;</span></p> <p>currently working on pretty print for xml output</p> <p><a href="https://jira.opendaylight.org/browse/CONTROLLER-923" title="?prettyPrint=true is ignored" class="issue-link" data-issue-key="CONTROLLER-923"><del>CONTROLLER-923</del></a> - pretty print in xml<br/> <a href="https://git.opendaylight.org/gerrit/12002" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/12002</a></p> <p>should be used some other (simpler writer)</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/11938/4" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/11938/4</a> - changes in sal-rest-connector <span class="error">&#91;DRAFT&#93;</span><br/> <a href="https://git.opendaylight.org/gerrit/#/c/11937/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/11937/</a> - changes in yang-data-codec-gson</p> <p>XML indentation isn't done in yang-data-impl but directly in sal-rest-connector in class NormalizedNodeXmlBodyWriter in method writeTo(). If indentation is required then prepared entityStream (parameter of writeTo() method) is red and transformed to new input stream which is then transformed via Transformer class to indented output.</p> <p>In NormalizedNodeXmlBodyWriter class method writeTo() was changed.<br/> IndentingXMLStreamWriter implementation of XmlStreamWriter is used.</p> <p>both patches (yangtools and controller) for JSON<br/> were rebased</p> <p>Still not fixed, I guess Target Milestone should be changed.</p> <p>Considering the default value for prettyPrint, current state is that regular responses are not indented, but responses with errors are indented.<br/> If this is the desired behavior, it should be documented somewhere. If not, fix of this bug should set desired default values.</p> <p>patch:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/20877/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/20877/</a></p> <p>Verified to be fixed (for regular data, both XML and JSON) on Lithium RC1 2015-06-16 build.</p> Development External issue ID 2153 External issue URL Issue Type ODL SR Target Milestone Rank 0|i02ne7: