https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/CONTROLLER-995 controller <p>2014-10-31 11:29:44,687 | ERROR | -notification-21 | NotifyTask | 140 - org.opendaylight.controller.sal-binding-broker-impl - 1.2.0.SNAPSHOT | Unhandled exception thrown by listener: org.opendaylight.controller.md.statistics.manager.impl.StatListenCommitFlow$$Broker$ListenerInvoker@5d22f281<br/> java.lang.NullPointerException<br/> at org.opendaylight.controller.md.statistics.manager.impl.StatAbstractNotifyCommit.isExpectedStatistics(StatAbstractNotifyCommit.java:125)<span class="error">&#91;151:org.opendaylight.controller.md.statistics-manager:1.2.0.SNAPSHOT&#93;</span><br/> at <br/> This exception happens many many times during the test and may be the root cause for why some data appears to be missing in the datastore.</p> <p>org.opendaylight.controller.md.statistics.manager.impl.StatListenCommitFlow.onFlowsStatisticsUpdate(StatListenCommitFlow.java:172)<span class="error">&#91;151:org.opendaylight.controller.md.statistics-manager:1.2.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.controller.md.statistics.manager.impl.StatListenCommitFlow$$Broker$ListenerInvoker.onNotification(StatListenCommitFlow$$Broker$ListenerInvoker.java)<span class="error">&#91;151:org.opendaylight.controller.md.statistics-manager:1.2.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.controller.sal.binding.impl.AbstractNotificationListenerRegistration.notify(AbstractNotificationListenerRegistration.java:38)<span class="error">&#91;140:org.opendaylight.controller.sal-binding-broker-impl:1.2.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.controller.sal.binding.impl.NotifyTask.run(NotifyTask.java:42)<span class="error">&#91;140:org.opendaylight.controller.sal-binding-broker-impl:1.2.0.SNAPSHOT&#93;</span><br/> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)<span class="error">&#91;:1.7.0_65&#93;</span><br/> at java.util.concurrent.FutureTask.run(FutureTask.java:262)<span class="error">&#91;:1.7.0_65&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)<span class="error">&#91;:1.7.0_65&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)<span class="error">&#91;:1.7.0_65&#93;</span><br/> at java.lang.Thread.run(Thread.java:745)<span class="error">&#91;:1.7.0_65&#93;</span></p> <p>Operating System: All<br/> Platform: All</p> CONTROLLER-995

Clustering : StatisticsManager throws NPE when running single node integration tests

Bug Resolved Done Moiz Raja Moiz Raja Wed, 5 Nov 2014 01:23:20 +0000 Tue, 25 Jul 2023 08:24:17 +0000 Fri, 14 Nov 2014 23:05:13 +0000 mdsal 0 4 <p> protected boolean isExpectedStatistics(final TransactionId transId, final NodeId nodeId) {<br/> Boolean isExpectedStat = Boolean.FALSE;<br/> try </p> { isExpectedStat = manager.getRpcMsgManager().isExpectedStatistics(transId, nodeId).get(10, TimeUnit.SECONDS); // Exception caused by this line } <p> catch (InterruptedException | ExecutionException | TimeoutException e) {<br/> LOG.warn("Check Transaction registraion {} fail!", transId, e);<br/> return false;<br/> }<br/> return isExpectedStat.booleanValue();<br/> }</p> <ol> <li>manager - is an invariant and cannot be null</li> <li>manager.getRpcMsgManager() - could be null, it is set to null in StatisticsManagerImpl#close</li> <li>manager.getRpcMsgManager().isExpectedStatistics(transId, nodeId) - cannot be null because isExpectedStatistics does not return a null</li> </ol> <p>It seems to be that StatisticsManagerImpl close is called at some point and that results in things getting messed up thenceforth.</p> <p>My initial analysis suggests that this may be an issue with StatisticsManager not unregistering for notifications properly. This can happen when the configuration is changed (config sub-system). For example when we switch from in-memory to clustered datastore the databroker gets rewired which results in all apps that use the databroker getting rewired. At that time the statistics manager's close will be called. The statistics manager should unregister from all notifications at this point. If it does not then it may receive notifications and since close sets the variables to null results in an NPE.</p> <p>StatsManagerImpl#close does call close on all the "*Comiter" and "*Registration" class instances. That should have unregistered the notifications ???</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/12585" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/12585</a> - HELIUM</p> <p>Merged to both master and stable/helium</p> Development External issue ID 2317 External issue URL ODL SR Target Milestone Rank 0|i02nu7: