https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/GBP-63 groupbasedpolicy <p>Ensure all "setAugmentation(class,getAugmentation)" type EP patterns pull all augmentations, not just OfOverlayContext/OfOverlayL3Context</p> <p>Operating System: All<br/> Platform: All</p> GBP-63

Fix addition of EP augmentations across neutron-mapper/ofoverlay.

Bug Resolved Done Konstantin Blagov Keith Burns Fri, 29 May 2015 12:31:55 +0000 Wed, 17 Jun 2015 08:37:36 +0000 Wed, 17 Jun 2015 08:37:36 +0000 unspecified General Fri, 12 Jun 2015 00:00:00 +0000 0 1 <p>What can happen is when we assign a field to an Augmentation, we have to ensure that there aren't existing augmentations. Either pull the aug's and update and push back, or update the subtree using the specific key.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/21759/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/21759/</a></p> <p>Unfortunately, the code for EndpointBuilder (in fact, any builder) generated by Yangtools provides only "unsafe" version of addAugmentation method. So it is mostly on programmer's good will, whether the potentially existing (in Datastore) augmentations added by some other party will be replaced with the new augmentation or not. The most reliable way seems to carefully chose between "put" or "merge", and general knowledge of possibility to break consistency.</p> <p>The pressure will be on code reviewers to control the intention of the whole operation.<br/> So far, there was just one such unsafe part of code, which was fixed.<br/> Ideally, a feature request for yangtools should be raised.</p> <p>I added a method that can check if an EP with given key exists and if it has some other augmentations (not counting our OfOverlayContext/OfOverlayL3Context). So one can chose if put or merge should be done.</p> <p>The only fragment of code where there was a possibility to unintentionally delete augmentations was eliminated by change <a href="https://git.opendaylight.org/gerrit/#/c/22114" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/22114</a><br/> Further we have to rely on programmer's understanding of possible consequences of datastore writing operations.</p> Development External issue ID 3434 External issue URL ODL SR Target Milestone Priority Rank 0|i0358v: