[GENIUS-118] Fix any slf4j API abuses, and enforce future non-regressions by enabling builds to fail via findbugs-slf4j

Thu, 15 Mar 2018 20:35:40 +0000

vorburger writing the initial version of this issue's description opened (thanks) by k.faseela to clarify scope:

This netvirt-dev list post is an example of bad (buggy, basically) use, or rather misuse (abuse) of the slf4j API; it's in netvirt, but I bet that in genius we have a few things like that as well...

The goal of this issue is (A) to find and fix ALL wrong use of slf4j logging everywhere in genius (by raising relatively small and specific individual Gerrits very similar to most of those you can now start to see being raised for netvirt; please just re-use the topic "findbugs-logging" for all such changes), AND (B) to make it so that it can never happen again by enforcing future non-regressions by enabling builds to fail via findbugs-slf4j; this can be done in the genius parent by by re-using how we've done it in project infrautils (NB you don't have to create yet another genius:findbugs artifact; just use infrautils').

In terms of how to go about this practically in a local dev environment, it's most probably easiest to first do (B) only locally just to easily find all the problems, then raise all patches for (A), and then when they are all merged push the Gerrit for (B) to finish it up.

OpenDaylight JIRA

[GENIUS-118] Fix any slf4j API abuses, and enforce future non-regressions by enabling builds to fail via findbugs-slf4j