https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/GENIUS-172 genius <p><a href="https://git.opendaylight.org/gerrit/#/c/72782/10/interfacemanager/interfacemanager-impl/src/main/java/org/opendaylight/genius/interfacemanager/InterfacemgrProvider.java@186" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/72782/10/interfacemanager/interfacemanager-impl/src/main/java/org/opendaylight/genius/interfacemanager/InterfacemgrProvider.java@186</a> claims that IdManager createIdPool() "can fail on two nodes but isn't a failure as long as at least one node succeeds", and uses that as the justification why it's OK to <tt>LOG.error</tt> that as "Failed to create idPool for InterfaceMgr", but not <tt>ifmStatusProvider.reportStatus(e);</tt> it for <a href="https://jira.opendaylight.org/browse/GENIUS-108" title="ITM and IFM listeners are registered without waiting for all required initializations to finish" class="issue-link" data-issue-key="GENIUS-108"><del>GENIUS-108</del></a>.</p> <p>If that is true, then IdManager createIdPool() really has a bug. It should never return a failure when actually the idPool was created successfully (on another node).</p> <p>When that is fixed, or if it is determined that it's actually fine, then InterfacemgrProvider should be made to <tt>ifmStatusProvider.reportStatus(e);</tt> in case it "Failed to create idPool for InterfaceMgr".</p> GENIUS-172

IdManager createIdPool should never return false positive Failure, causing wrong "Failed to create idPool for InterfaceMgr" error log but not diagstatus failure

Bug Medium Open Unresolved Ankit Jain Michael Vorburger Mon, 2 Jul 2018 16:18:10 +0000 Fri, 24 Aug 2018 11:19:39 +0000 Neon 0 2 <p>2018-07-16T14:13:17,725 | WARN | opendaylight-cluster-data-shard-dispatcher-68 | ShardDataTree | 229 - org.opendaylight.controller.sal-distributed-datastore - 1.8.0.SNAPSHOT | member-1-shard-default-operational: Store Tx member-1-datastore-operational-fe-0-txn-17-0: Conflicting modification for path /(urn:opendaylight:genius:lockmanager?revision=2016-04-13)locks/lock/lock<span class="error">&#91;\{(urn:opendaylight:genius:lockmanager?revision=2016-04-13)lock-name=groups}&#93;</span>. 2018-07-16T14:13:17,773 | INFO | opendaylight-cluster-data-akka.actor.default-dispatcher-54 | IdManager | 244 - org.opendaylight.genius.idmanager-impl - 0.5.0.SNAPSHOT | createIdPool called with input CreateIdPoolInput{getHigh=254, getLow=0, getPoolName=meters, augmentations={}} 2018-07-16T14:13:17,727 | ERROR | opendaylight-cluster-data-akka.actor.default-dispatcher-38 | LocalThreePhaseCommitCohort | 229 - org.opendaylight.controller.sal-distributed-datastore - 1.8.0.SNAPSHOT | Failed to prepare transaction member-1-datastore-operational-fe-0-txn-17-0 on backend org.opendaylight.mdsal.common.api.OptimisticLockFailedException: Optimistic lock failed for path /(urn:opendaylight:genius:lockmanager?revision=2016-04-13)locks/lock/lock<span class="error">&#91;\{(urn:opendaylight:genius:lockmanager?revision=2016-04-13)lock-name=groups}&#93;</span> at org.opendaylight.controller.cluster.datastore.ShardDataTree.lambda$processNextPendingTransaction$0(ShardDataTree.java:734) ~<span class="error">&#91;229:org.opendaylight.controller.sal-distributed-datastore:1.8.0.SNAPSHOT&#93;</span> at org.opendaylight.controller.cluster.datastore.ShardDataTree.processNextPending(ShardDataTree.java:772) <span class="error">&#91;229:org.opendaylight.controller.sal-distributed-datastore:1.8.0.SNAPSHOT&#93;</span> at org.opendaylight.controller.cluster.datastore.ShardDataTree.processNextPendingTransaction(ShardDataTree.java:719) <span class="error">&#91;229:org.opendaylight.controller.sal-distributed-datastore:1.8.0.SNAPSHOT&#93;</span> at org.opendaylight.controller.cluster.datastore.ShardDataTree.startCanCommit(ShardDataTree.java:873) <span class="error">&#91;229:org.opendaylight.controller.sal-distributed-datastore:1.8.0.SNAPSHOT&#93;</span> at org.opendaylight.controller.cluster.datastore.SimpleShardDataTreeCohort.canCommit(SimpleShardDataTreeCohort.java:99) <span class="error">&#91;229:org.opendaylight.controller.sal-distributed-datastore:1.8.0.SNAPSHOT&#93;</span> at org.opendaylight.controller.cluster.datastore.CohortEntry.canCommit(CohortEntry.java:99) <span class="error">&#91;229:org.opendaylight.controller.sal-distributed-datastore:1.8.0.SNAPSHOT&#93;</span> at org.opendaylight.controller.cluster.datastore.ShardCommitCoordinator.handleCanCommit(ShardCommitCoordinator.java:239) <span class="error">&#91;229:org.opendaylight.controller.sal-distributed-datastore:1.8.0.SNAPSHOT&#93;</span> at org.opendaylight.controller.cluster.datastore.ShardCommitCoordinator.handleReadyLocalTransaction(ShardCommitCoordinator.java:201) <span class="error">&#91;229:org.opendaylight.controller.sal-distributed-datastore:1.8.0.SNAPSHOT&#93;</span> at org.opendaylight.controller.cluster.datastore.Shard.handleReadyLocalTransaction(Shard.java:731) <span class="error">&#91;229:org.opendaylight.controller.sal-distributed-datastore:1.8.0.SNAPSHOT&#93;</span> at org.opendaylight.controller.cluster.datastore.Shard.handleNonRaftCommand(Shard.java:330) <span class="error">&#91;229:org.opendaylight.controller.sal-distributed-datastore:1.8.0.SNAPSHOT&#93;</span> at org.opendaylight.controller.cluster.raft.RaftActor.handleCommand(RaftActor.java:270) <span class="error">&#91;214:org.opendaylight.controller.sal-akka-raft:1.8.0.SNAPSHOT&#93;</span> at org.opendaylight.controller.cluster.common.actor.AbstractUntypedPersistentActor.onReceiveCommand(AbstractUntypedPersistentActor.java:44) <span class="error">&#91;221:org.opendaylight.controller.sal-clustering-commons:1.8.0.SNAPSHOT&#93;</span> at akka.persistence.UntypedPersistentActor.onReceive(PersistentActor.scala:275) <span class="error">&#91;38:com.typesafe.akka.persistence:2.5.11&#93;</span> at org.opendaylight.controller.cluster.common.actor.MeteringBehavior.apply(MeteringBehavior.java:104) <span class="error">&#91;221:org.opendaylight.controller.sal-clustering-commons:1.8.0.SNAPSHOT&#93;</span> at akka.actor.ActorCell$$anonfun$become$1.applyOrElse(ActorCell.scala:608) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> at akka.actor.Actor.aroundReceive(Actor.scala:517) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> at akka.actor.Actor.aroundReceive$(Actor.scala:515) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> at akka.persistence.UntypedPersistentActor.akka$persistence$Eventsourced$$super$aroundReceive(PersistentActor.scala:273) <span class="error">&#91;38:com.typesafe.akka.persistence:2.5.11&#93;</span> at akka.persistence.Eventsourced$$anon$1.stateReceive(Eventsourced.scala:691) <span class="error">&#91;38:com.typesafe.akka.persistence:2.5.11&#93;</span> at akka.persistence.Eventsourced.aroundReceive(Eventsourced.scala:192) <span class="error">&#91;38:com.typesafe.akka.persistence:2.5.11&#93;</span> at akka.persistence.Eventsourced.aroundReceive$(Eventsourced.scala:191) <span class="error">&#91;38:com.typesafe.akka.persistence:2.5.11&#93;</span> at akka.persistence.UntypedPersistentActor.aroundReceive(PersistentActor.scala:273) <span class="error">&#91;38:com.typesafe.akka.persistence:2.5.11&#93;</span> at akka.actor.ActorCell.receiveMessage(ActorCell.scala:590) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> at akka.actor.ActorCell.invoke(ActorCell.scala:559) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> at akka.dispatch.Mailbox.run(Mailbox.scala:224) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> at akka.dispatch.Mailbox.exec(Mailbox.scala:234) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> at akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> at akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> at akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107) <span class="error">&#91;35:com.typesafe.akka.actor:2.5.11&#93;</span> Caused by: org.opendaylight.yangtools.yang.data.api.schema.tree.ConflictingModificationAppliedException: Node was created by other transaction. at org.opendaylight.yangtools.yang.data.impl.schema.tree.SchemaAwareApplyOperation.checkConflicting(SchemaAwareApplyOperation.java:80) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.SchemaAwareApplyOperation.checkWriteApplicable(SchemaAwareApplyOperation.java:182) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.SchemaAwareApplyOperation.checkApplicable(SchemaAwareApplyOperation.java:134) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.checkChildPreconditions(AbstractNodeContainerModificationStrategy.java:302) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.checkMergeApplicable(AbstractNodeContainerModificationStrategy.java:313) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.SchemaAwareApplyOperation.checkApplicable(SchemaAwareApplyOperation.java:137) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.checkChildPreconditions(AbstractNodeContainerModificationStrategy.java:302) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.checkMergeApplicable(AbstractNodeContainerModificationStrategy.java:313) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.SchemaAwareApplyOperation.checkApplicable(SchemaAwareApplyOperation.java:137) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.StructuralContainerModificationStrategy.checkApplicable(StructuralContainerModificationStrategy.java:100) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.checkChildPreconditions(AbstractNodeContainerModificationStrategy.java:302) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.checkTouchApplicable(AbstractNodeContainerModificationStrategy.java:284) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.SchemaAwareApplyOperation.checkApplicable(SchemaAwareApplyOperation.java:131) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.RootModificationApplyOperation.checkApplicable(RootModificationApplyOperation.java:71) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractDataTreeTip.validate(AbstractDataTreeTip.java:38) ~<span class="error">&#91;423:org.opendaylight.yangtools.yang-data-impl:2.0.7&#93;</span> at org.opendaylight.controller.cluster.datastore.ShardDataTree.lambda$processNextPendingTransaction$0(ShardDataTree.java:726) ~<span class="error">&#91;229:org.opendaylight.controller.sal-distributed-datastore:1.8.0.SNAPSHOT&#93;</span> ... 30 more</p> Blocks GENIUS-108 Development Rank 0|i03gaf: