https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/GENIUS-178 genius <p><a href="https://jira.opendaylight.org/browse/NETVIRT-1384" title="Umbrella: Numerous new transaction leaks" class="issue-link" data-issue-key="NETVIRT-1384"><del>NETVIRT-1384</del></a> attachements show transaction leaks in lockmanager.</p> <p>The goal of this issue is to a) fix them, and b) prevent them from coming back, based on how <a href="https://jira.opendaylight.org/browse/GENIUS-177" title="Convert interfacemanger to managed transaction runner, only (and enforce it for non-regression)" class="issue-link" data-issue-key="GENIUS-177"><del>GENIUS-177</del></a> is doing it for interfacemanager.</p> GENIUS-178

Fix new transaction leaks in idmanager

Bug Highest Resolved Done Stephen Kitt Michael Vorburger Wed, 25 Jul 2018 14:20:27 +0000 Fri, 27 Jul 2018 16:22:07 +0000 Fri, 27 Jul 2018 16:22:07 +0000 Oxygen-SR2 Oxygen-SR3 Fluorine 0 2 <p>From <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=SridharG" class="user-hover" rel="SridharG">SridharG</a>'s open-transactions-controller-2.txt attached to <a href="https://jira.opendaylight.org/browse/NETVIRT-1384" title="Umbrella: Numerous new transaction leaks" class="issue-link" data-issue-key="NETVIRT-1384"><del>NETVIRT-1384</del></a> :</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>1187x transactions opened here, which are not closed: (...) org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter.newWriteOnlyTransaction(BindingDOMDataBrokerAdapter.java:69) (...) org.opendaylight.genius.idmanager.IdManager.getIdBlockFromParentPool(IdManager.java:386) org.opendaylight.genius.idmanager.IdManager.getIdFromLocalPoolCache(IdManager.java:356) org.opendaylight.genius.idmanager.IdManager.allocateIdFromLocalPool(IdManager.java:315) org.opendaylight.genius.idmanager.IdManager.lambda$allocateId$6(IdManager.java:219) org.opendaylight.genius.tools.mdsal.rpc.FutureRpcResults.lambda$fromBuilder$0(FutureRpcResults.java:131) org.opendaylight.genius.tools.mdsal.rpc.FutureRpcResults$FutureRpcResultBuilder.build(FutureRpcResults.java:211) org.opendaylight.genius.idmanager.IdManager.allocateId(IdManager.java:221) org.opendaylight.yangtools.yang.binding.util.RpcMethodInvokerWithInput.invokeOn(RpcMethodInvokerWithInput.java:32) org.opendaylight.yangtools.yang.binding.util.AbstractMappedRpcInvoker.invokeRpc(AbstractMappedRpcInvoker.java:53) org.opendaylight.controller.md.sal.binding.impl.BindingDOMRpcImplementationAdapter.invoke(BindingDOMRpcImplementationAdapter.java:83) org.opendaylight.controller.md.sal.binding.impl.BindingDOMRpcImplementationAdapter.invokeRpc(BindingDOMRpcImplementationAdapter.java:70) org.opendaylight.controller.md.sal.dom.broker.impl.GlobalDOMRpcRoutingTableEntry.invokeRpc(GlobalDOMRpcRoutingTableEntry.java:41) org.opendaylight.controller.md.sal.dom.broker.impl.DOMRpcRoutingTable.invokeRpc(DOMRpcRoutingTable.java:178) org.opendaylight.controller.md.sal.dom.broker.impl.DOMRpcRouter.invokeRpc(DOMRpcRouter.java:102) (...) org.opendaylight.controller.md.sal.binding.impl.RpcServiceAdapter.invoke0(RpcServiceAdapter.java:68) org.opendaylight.controller.md.sal.binding.impl.RpcServiceAdapter.access$000(RpcServiceAdapter.java:46) org.opendaylight.controller.md.sal.binding.impl.RpcServiceAdapter$RpcInvocationStrategy.invoke(RpcServiceAdapter.java:165) org.opendaylight.controller.md.sal.binding.impl.RpcServiceAdapter.invoke(RpcServiceAdapter.java:99) com.sun.proxy.$Proxy218.allocateId(Unknown Source) org.opendaylight.netvirt.vpnmanager.VpnUtil.getUniqueId(VpnUtil.java:520) org.opendaylight.netvirt.vpnmanager.populator.impl.L3vpnOverMplsGrePopulator.createOperationalAdjacency(L3vpnOverMplsGrePopulator.java:121) org.opendaylight.netvirt.vpnmanager.VpnInterfaceManager.processVpnInterfaceAdjacencies(VpnInterfaceManager.java:847) org.opendaylight.netvirt.vpnmanager.VpnInterfaceManager.processVpnInterfaceUp(VpnInterfaceManager.java:417) org.opendaylight.netvirt.vpnmanager.InterfaceStateChangeListener.lambda$null$0(InterfaceStateChangeListener.java:149) org.opendaylight.genius.infra.ManagedNewTransactionRunnerImpl.callWithNewWriteOnlyTransactionAndSubmit(ManagedNewTransactionRunnerImpl.java:45) org.opendaylight.netvirt.vpnmanager.InterfaceStateChangeListener.lambda$null$1(InterfaceStateChangeListener.java:117) org.opendaylight.genius.infra.ManagedNewTransactionRunnerImpl.callWithNewWriteOnlyTransactionAndSubmit(ManagedNewTransactionRunnerImpl.java:45) org.opendaylight.netvirt.vpnmanager.InterfaceStateChangeListener.lambda$null$2(InterfaceStateChangeListener.java:115) org.opendaylight.genius.infra.ManagedNewTransactionRunnerImpl.callWithNewWriteOnlyTransactionAndSubmit(ManagedNewTransactionRunnerImpl.java:45) org.opendaylight.netvirt.vpnmanager.InterfaceStateChangeListener.lambda$add$3(InterfaceStateChangeListener.java:113) org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:416) org.opendaylight.infrautils.utils.concurrent.LoggingUncaughtThreadDeathContextRunnable.run(LoggingUncaughtThreadDeathContextRunnable.java:60) java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1402) java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)</pre> </div></div> <p>This is already fixed on master.</p> <p>by one of these here I'm guessing:</p> <ul> <li><a href="https://git.opendaylight.org/gerrit/#/c/73426/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/73426/</a></li> <li><a href="https://git.opendaylight.org/gerrit/#/c/73041/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/73041/</a></li> <li><a href="https://git.opendaylight.org/gerrit/#/c/64726/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/64726/</a></li> </ul> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a> said on IRC he'll cherry-pick the right one from master for Oxygen SR3.</p> <p>Done, TX <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a>! It's noteworthy FTR here that <a href="https://git.opendaylight.org/gerrit/#/c/74467/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/74467/</a> included back-porting the ManagedNewTransactionRunner's new applyWithNewReadWriteTransactionAndSubmit() method to Oxygen - this opens the door for more easily cherry-picking other master changes to Oxygen, if needed (FYI <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=k.faseela" class="user-hover" rel="k.faseela">k.faseela</a>).</p> Blocks GENIUS-176 NETVIRT-1384 GENIUS-179 GENIUS-177 Development Rank 0|i03h1r: